[fineract] branch develop updated: FINERACT-1839: Minor fix for Chargeback transaction relation reprocessing

[ad...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 3f2feceea FINERACT-1839: Minor fix for Chargeback transaction relation reprocessing
3f2feceea is described below

commit 3f2feceea1a213ec2a806e262fd952fbc8652bb0
Author: Adam Saghy <ad...@gmail.com>
AuthorDate: Tue Feb 7 15:15:10 2023 +0100

    FINERACT-1839: Minor fix for Chargeback transaction relation reprocessing
---
 .../AbstractLoanRepaymentScheduleTransactionProcessor.java            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java
index 46d79637a..76a95abbc 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java
@@ -224,8 +224,8 @@ public abstract class AbstractLoanRepaymentScheduleTransactionProcessor implemen
                     LoanTransactionRelation newLoanTransactionRelation = null;
                     LoanTransactionRelation oldLoanTransactionRelation = null;
                     for (LoanTransactionRelation transactionRelation : loanTransaction.getLoanTransactionRelations()) {
-                        if (entry.getKey().equals(transactionRelation.getToTransaction().getId())
-                                && LoanTransactionRelationTypeEnum.CHARGEBACK.equals(transactionRelation.getRelationType())) {
+                        if (LoanTransactionRelationTypeEnum.CHARGEBACK.equals(transactionRelation.getRelationType())
+                                && entry.getKey().equals(transactionRelation.getToTransaction().getId())) {
                             newLoanTransactionRelation = LoanTransactionRelation.linkToTransaction(loanTransaction, entry.getValue(),
                                     LoanTransactionRelationTypeEnum.CHARGEBACK);
                             oldLoanTransactionRelation = transactionRelation;