You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vikram Dixit Kumaraswamy <vi...@gmail.com> on 2013/12/12 10:39:29 UTC
Review Request 16213: HIVE-5973: SMB joins produce incorrect results with
multiple partitions and buckets
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16213/
-----------------------------------------------------------
Review request for hive, Navis Ryu and Harish Butani.
Bugs: HIVE-5973
https://issues.apache.org/jira/browse/HIVE-5973
Repository: hive-git
Description
-------
SMB joins produce incorrect results with multiple partitions and buckets
Diffs
-----
itests/hive-unit/pom.xml dae4e50
itests/qtest/pom.xml 8c249a0
ql/src/java/org/apache/hadoop/hive/ql/exec/DummyStoreOperator.java acdb040
ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q PRE-CREATION
ql/src/test/results/clientpositive/auto_sortmerge_join_16.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/16213/diff/
Testing
-------
New test case added.
Thanks,
Vikram Dixit Kumaraswamy
Re: Review Request 16213: HIVE-5973: SMB joins produce incorrect results
with multiple partitions and buckets
Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16213/#review30381
-----------------------------------------------------------
itests/hive-unit/pom.xml
<https://reviews.apache.org/r/16213/#comment58142>
this change probably goes in another jira
ql/src/java/org/apache/hadoop/hive/ql/exec/DummyStoreOperator.java
<https://reviews.apache.org/r/16213/#comment58143>
can you document your observations on the Priority queue stuff and why this change fixes the problem.
- Harish Butani
On Dec. 12, 2013, 9:39 a.m., Vikram Dixit Kumaraswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16213/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2013, 9:39 a.m.)
>
>
> Review request for hive, Navis Ryu and Harish Butani.
>
>
> Bugs: HIVE-5973
> https://issues.apache.org/jira/browse/HIVE-5973
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> SMB joins produce incorrect results with multiple partitions and buckets
>
>
> Diffs
> -----
>
> itests/hive-unit/pom.xml dae4e50
> itests/qtest/pom.xml 8c249a0
> ql/src/java/org/apache/hadoop/hive/ql/exec/DummyStoreOperator.java acdb040
> ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q PRE-CREATION
> ql/src/test/results/clientpositive/auto_sortmerge_join_16.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16213/diff/
>
>
> Testing
> -------
>
> New test case added.
>
>
> Thanks,
>
> Vikram Dixit Kumaraswamy
>
>
Re: Review Request 16213: HIVE-5973: SMB joins produce incorrect results
with multiple partitions and buckets
Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16213/#review30388
-----------------------------------------------------------
Ship it!
Ship It!
- Harish Butani
On Dec. 13, 2013, 11:10 p.m., Vikram Dixit Kumaraswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16213/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 11:10 p.m.)
>
>
> Review request for hive, Navis Ryu and Harish Butani.
>
>
> Bugs: HIVE-5973
> https://issues.apache.org/jira/browse/HIVE-5973
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> SMB joins produce incorrect results with multiple partitions and buckets
>
>
> Diffs
> -----
>
> itests/qtest/pom.xml 8c249a0
> ql/src/java/org/apache/hadoop/hive/ql/exec/DummyStoreOperator.java acdb040
> ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q PRE-CREATION
> ql/src/test/results/clientpositive/auto_sortmerge_join_16.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16213/diff/
>
>
> Testing
> -------
>
> New test case added.
>
>
> Thanks,
>
> Vikram Dixit Kumaraswamy
>
>
Re: Review Request 16213: HIVE-5973: SMB joins produce incorrect results
with multiple partitions and buckets
Posted by Vikram Dixit Kumaraswamy <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16213/
-----------------------------------------------------------
(Updated Dec. 13, 2013, 11:10 p.m.)
Review request for hive, Navis Ryu and Harish Butani.
Changes
-------
Addressed Harish's comments.
Bugs: HIVE-5973
https://issues.apache.org/jira/browse/HIVE-5973
Repository: hive-git
Description
-------
SMB joins produce incorrect results with multiple partitions and buckets
Diffs (updated)
-----
itests/qtest/pom.xml 8c249a0
ql/src/java/org/apache/hadoop/hive/ql/exec/DummyStoreOperator.java acdb040
ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q PRE-CREATION
ql/src/test/results/clientpositive/auto_sortmerge_join_16.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/16213/diff/
Testing
-------
New test case added.
Thanks,
Vikram Dixit Kumaraswamy