You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrew Donald Kennedy <no...@github.com> on 2016/04/01 23:53:17 UTC

[jclouds/jclouds-labs] Added volumesFrom to Docker template options (#252)

Added new `volumesFrom` option to `DockerTemplateOptions` and tidies up some of the `@Nullable` entries in the configuration domain objects.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/252

-- Commit Summary --

  * Added volumesFrom to Docker template options

-- File Changes --

    M docker/src/main/java/org/jclouds/docker/compute/options/DockerTemplateOptions.java (84)
    M docker/src/main/java/org/jclouds/docker/compute/strategy/DockerComputeServiceAdapter.java (22)
    M docker/src/main/java/org/jclouds/docker/domain/Config.java (40)
    M docker/src/main/java/org/jclouds/docker/domain/HostConfig.java (53)
    M docker/src/main/java/org/jclouds/docker/internal/NullSafeCopies.java (12)
    M docker/src/test/java/org/jclouds/docker/compute/functions/ContainerToNodeMetadataTest.java (1)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/252.patch
https://github.com/jclouds/jclouds-labs/pull/252.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/252

Re: [jclouds/jclouds-labs] Added volumesFrom to Docker template options (#252)

Posted by Andrea Turli <no...@github.com>.

same comments as #252 
probably you don't need to create 2 PRs for master and 1.9.x but once master is merged you can certainly ask to backport it to 1.9.x. This way I think we reduce the number of PRs. Thoughts?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/252#issuecomment-204708281

Re: [jclouds/jclouds-labs] Added volumesFrom to Docker template options (#252)

Posted by Andrea Turli <no...@github.com>.

Closed #252.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/252#event-614857839

Re: [jclouds/jclouds-labs] Added volumesFrom to Docker template options (#252)

Posted by Andrea Turli <no...@github.com>.

thanks @grkvlt. Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/31381953)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/252#issuecomment-205718832