You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/16 13:13:46 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `0.45%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 63.69% 63.24% -0.46%
==========================================
Files 959 960 +1
Lines 47140 47169 +29
Branches 4609 4609
==========================================
- Hits 30025 29830 -195
- Misses 16931 17155 +224
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.67% <ø> (ø)` | |
| python | `63.58% <9.09%> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org