You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/01/06 05:33:37 UTC
[GitHub] [incubator-brpc] zyearn opened a new pull request #1016:
replace_crc32_ts
zyearn opened a new pull request #1016: replace_crc32_ts
URL: https://github.com/apache/incubator-brpc/pull/1016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on a change in pull request
#1016: replace_crc32_ts
Posted by GitBox <gi...@apache.org>.
zyearn commented on a change in pull request #1016: replace_crc32_ts
URL: https://github.com/apache/incubator-brpc/pull/1016#discussion_r363292439
##########
File path: LICENSE
##########
@@ -599,7 +599,7 @@ licensed under the following terms:
--------------------------------------------------------------------------------
-src/brpc/ts.h, src/brpc/ts.cpp, src/brpc/policy/dh.h, src/brpc/policy/dh.cpp: MIT license
+src/brpc/ts.h, src/brpc/policy/dh.h, src/brpc/policy/dh.cpp: MIT license
Review comment:
ts.cpp有两个license，单独提了出来
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on a change in pull request
#1016: replace_crc32_ts
Posted by GitBox <gi...@apache.org>.
jamesge commented on a change in pull request #1016: replace_crc32_ts
URL: https://github.com/apache/incubator-brpc/pull/1016#discussion_r363265626
##########
File path: LICENSE
##########
@@ -619,6 +619,50 @@ src/brpc/ts.h, src/brpc/ts.cpp, src/brpc/policy/dh.h, src/brpc/policy/dh.cpp: MI
--------------------------------------------------------------------------------
+src/brpc/ts.cpp: licensed under the following terms:
+
+ Copyright (c) 2013-2015 SRS(ossrs)
Review comment:
有用到？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on a change in pull request
#1016: replace_crc32_ts
Posted by GitBox <gi...@apache.org>.
jamesge commented on a change in pull request #1016: replace_crc32_ts
URL: https://github.com/apache/incubator-brpc/pull/1016#discussion_r363265575
##########
File path: LICENSE
##########
@@ -599,7 +599,7 @@ licensed under the following terms:
--------------------------------------------------------------------------------
-src/brpc/ts.h, src/brpc/ts.cpp, src/brpc/policy/dh.h, src/brpc/policy/dh.cpp: MIT license
+src/brpc/ts.h, src/brpc/policy/dh.h, src/brpc/policy/dh.cpp: MIT license
Review comment:
为什么要删掉ts.cpp?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on a change in pull request
#1016: replace_crc32_ts
Posted by GitBox <gi...@apache.org>.
zyearn commented on a change in pull request #1016: replace_crc32_ts
URL: https://github.com/apache/incubator-brpc/pull/1016#discussion_r363292673
##########
File path: LICENSE
##########
@@ -619,6 +619,50 @@ src/brpc/ts.h, src/brpc/ts.cpp, src/brpc/policy/dh.h, src/brpc/policy/dh.cpp: MI
--------------------------------------------------------------------------------
+src/brpc/ts.cpp: licensed under the following terms:
+
+ Copyright (c) 2013-2015 SRS(ossrs)
Review comment:
srs copyright一直都在ts.cpp里
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] jamesge merged pull request #1016: replace_crc32_ts
Posted by GitBox <gi...@apache.org>.
jamesge merged pull request #1016: replace_crc32_ts
URL: https://github.com/apache/incubator-brpc/pull/1016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org