You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/08 00:23:07 UTC

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #719: fix: dashboard 2.0 failed to fetch ssl certificate not found

moonming commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519237883



##########
File path: api/internal/handler/ssl/ssl.go
##########
@@ -147,6 +147,7 @@ func (h *Handler) Create(c droplet.Context) (interface{}, error) {
 	}
 
 	ssl.ID = input.ID
+	ssl.Status = 1

Review comment:
       Is this the cause of the bug?  Can you explain the reason?

##########
File path: .github/workflows/e2e-test-backend.yml
##########
@@ -28,7 +28,10 @@ jobs:
           sleep 5
           docker logs docker_managerapi_1
 
+      - name: set hosts
+        working-directory: ./api/test/e2e
+        run: echo "127.0.0.1 www.test2.com" | sudo tee -a /etc/hosts

Review comment:
       why need to change local file?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org