[jira] [Commented] (MJAVADOC-656) Following redirects breaks valid links

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MJAVADOC-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161051#comment-17161051 ] 

Michael Osipov commented on MJAVADOC-656:
-----------------------------------------

There redirects aren't standard, they seem to be specific to the deploy of the specific package on a webserver:
{noformat}
/apidocs -> 301 /apidocs/com/example/package-summary.html
/apidocs/ -> 301 /apidocs/com/example/package-summary.html
{noformat}

How are we supposed to support any kind of custom redirect approach?

> Following redirects breaks valid links
> --------------------------------------
>
>                 Key: MJAVADOC-656
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-656
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>    Affects Versions: 3.0.1, 3.2.0
>            Reporter: Robert Važan
>            Priority: Minor
>
> Version 3.0.1 fixed #427 by following redirects. This feature unfortunately breaks when HTTP server is configured as follows:
> /apidocs/package-list -> 200
>  /apidocs -> 301 /apidocs/com/example/package-summary.html
>  /apidocs/ -> 301 /apidocs/com/example/package-summary.html
>  /apidocs/com/example/package-summary.html -> 200
> Without following redirects (in version 3.0.0), the link is passed to javadoc tool unchanged, the javadoc tool fetches /apidocs/package-list, and everything works fine. Since 3.0.1, javadoc plugin follows one of the redirects (/apidocs or /apidocs/), passes the package summary URL to javadoc tool, which then fails like this:
> [WARNING] javadoc: warning - Error fetching URL: [https://example.com/apidocs/com/example/package-summary.html/]
> And if you have failOnWarnings set to true, this will fail the whole build.
> The solution is fairly simple. Construct the whole URL (.../package-list) and follow redirects on that one. Then check whether the final destination ends in /package-list, strip the /package-list suffix, and pass the result to the javadoc tool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)