Re: [PR] KAFKA-19648: KIP-1170 Unify cluster metadata bootstrapping [kafka]

["jsancio (via GitHub)" <gi...@apache.org>]

jsancio commented on PR #20707:
URL: https://github.com/apache/kafka/pull/20707#issuecomment-3719818486

   Thanks for the changes @mannoopj 
   
   Ideally the PR description should answer the following 3 questions: Why is the PR required? What does the PR change? How does the PR change Kafka?
   
   > StorageTool.scala now checks to see if we the role is Controller before formatting metadata
   Why is this needed? The KIP doesn't mention this change.
   
   > Implementations of RaftClient.handleLoadSnapshot were adjusting to now account for the presence of metadata records within in the zero checkpoint
   
   Technically RaftClient.handleLoadSnapshot is not a definition (implementation) and instead a declaration. Do you mean to say that you changed the implementation of that method in the quorum controller?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org