[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27988: [SPARK-31226][SQL][TEST] SizeBasedCoalesce logic will lose partition

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #27988: [SPARK-31226][SQL][TEST] SizeBasedCoalesce logic will lose partition
URL: https://github.com/apache/spark/pull/27988#discussion_r401861089
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala
 ##########
 @@ -1298,18 +1298,18 @@ class SizeBasedCoalescer(val maxSize: Int) extends PartitionCoalescer with Seria
       val splitSize = fileSplit.getLength
       if (currentSum + splitSize < maxSize) {
         addPartition(partition, splitSize)
-        index += 1
-        if (index == partitions.size) {
-          updateGroups
-        }
       } else {
-        if (currentGroup.partitions.size == 0) {
+        if (currentGroup.partitions.isEmpty) {
           addPartition(partition, splitSize)
-          index += 1
         } else {
-          updateGroups
+          updateGroups()
+          addPartition(partition, splitSize)
         }
       }
+      index += 1
+      if (index == partitions.length) {
+        updateGroups()
+      }
 
 Review comment:
   BTW, the previous code was added at 2.0.0. Did you hit a test flakiness due to this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org