You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/05 13:45:39 UTC
[jira] [Commented] (THRIFT-3600) Make TTwisted server send
exception on unexpected handler error
[ https://issues.apache.org/jira/browse/THRIFT-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134104#comment-15134104 ]
ASF GitHub Bot commented on THRIFT-3600:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/838
THRIFT-3600 Make TTwisted server send exception on unexpected handler…
… error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3600
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/838.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #838
----
commit 4c40723d3bc1447ca285f1c0c5a97e4ec1dd288e
Author: Nobuaki Sukegawa <ns...@apache.org>
Date: 2016-02-05T12:39:17Z
THRIFT-3600 Make TTwisted server send exception on unexpected handler error
----
> Make TTwisted server send exception on unexpected handler error
> ---------------------------------------------------------------
>
> Key: THRIFT-3600
> URL: https://issues.apache.org/jira/browse/THRIFT-3600
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
>
> When unspecified exception occurs inside handler, TTwisted server disconnects the client.
> Many other languages and non TTwisted/Tornado servers sends TApplicationException in such cases.
> There is even a test case that tries to assert this behavior for TTwisted but the test is broken in a way it fails to detect the failure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)