You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2023/12/18 07:31:41 UTC
[PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]
Mryange opened a new pull request, #28559:
URL: https://github.com/apache/doris/pull/28559
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28559:
URL: https://github.com/apache/doris/pull/28559#issuecomment-1859823934
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit bf3c2297f19b695265f4e99998b8569a903120ac, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4696 4438 4457 4438
q2 362 153 158 153
q3 1462 1262 1238 1238
q4 1122 939 925 925
q5 3142 3124 3154 3124
q6 255 132 129 129
q7 984 485 487 485
q8 2204 2199 2178 2178
q9 6670 6676 6648 6648
q10 3243 3259 3288 3259
q11 329 192 193 192
q12 348 208 205 205
q13 4566 3792 3811 3792
q14 244 220 215 215
q15 569 532 529 529
q16 440 379 381 379
q17 997 681 564 564
q18 7239 6817 6956 6817
q19 1520 1466 1375 1375
q20 550 328 279 279
q21 3073 2634 2721 2634
q22 351 273 277 273
Total cold run time: 44366 ms
Total hot run time: 39831 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4364 4339 4386 4339
q2 262 163 173 163
q3 3543 3535 3513 3513
q4 2386 2369 2364 2364
q5 5736 5737 5717 5717
q6 243 119 125 119
q7 2375 1882 1870 1870
q8 3523 3523 3511 3511
q9 9069 9021 8969 8969
q10 3899 3998 3971 3971
q11 498 394 382 382
q12 769 592 586 586
q13 4312 3603 3581 3581
q14 294 254 256 254
q15 580 520 530 520
q16 520 447 488 447
q17 1869 1822 1832 1822
q18 8839 8125 8302 8125
q19 1710 1737 1728 1728
q20 2257 1947 1934 1934
q21 6489 6161 6144 6144
q22 489 431 420 420
Total cold run time: 64026 ms
Total hot run time: 60479 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #28559:
URL: https://github.com/apache/doris/pull/28559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28559:
URL: https://github.com/apache/doris/pull/28559#issuecomment-1859834491
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.95 seconds
stream load tsv: 595 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17221199326 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28559:
URL: https://github.com/apache/doris/pull/28559#issuecomment-1862013216
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #28559:
URL: https://github.com/apache/doris/pull/28559#issuecomment-1859703614
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28559:
URL: https://github.com/apache/doris/pull/28559#issuecomment-1859707490
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #28559:
URL: https://github.com/apache/doris/pull/28559#discussion_r1429604247
##########
be/src/runtime/runtime_filter_mgr.h:
##########
@@ -20,6 +20,7 @@
#include <gen_cpp/PaloInternalService_types.h>
Review Comment:
warning: 'gen_cpp/PaloInternalService_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/PaloInternalService_types.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28559:
URL: https://github.com/apache/doris/pull/28559#issuecomment-1862013253
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28559:
URL: https://github.com/apache/doris/pull/28559#issuecomment-1859711077
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org