[jira] Updated: (SOLR-1990) blockUntilFinished() is called in StreamingUpdateSolrServer more often then it should

["Hoss Man (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-1990:
---------------------------

        Summary: blockUntilFinished() is called in StreamingUpdateSolrServer more often then it should  (was: blockUntilFinished() is called in StreamingUpdateSolrServer when deleing by id)
    Description: 
in the StreamingUpdateSolrServer .request() it identifies a commit/optimize request by having no document...

{code}
    // this happens for commit...
    if( req.getDocuments()==null || req.getDocuments().isEmpty() ) {
      blockUntilFinished();
{code}

...but there are other situations where an UpdateRequest will nave no documents (delete, updates using stream.url or stream.file, etc...)

  was:
in the StreamingUpdateSolrServer .request() it identifies a commit/optimize request by having no document, but also the delete doesn't have a docuemnt.


    // this happens for commit...
    if( req.getDocuments()==null || req.getDocuments().isEmpty() ) {
      blockUntilFinished();



updating summary/description to note that the issue goes beyond just deletes by query.

another example noted on the user list is when doing index updates using stream.url or stream.file -- these are update requests that do not include any documents, and even if it is considered intentional that "deletes" block until the queue is empty, these updates certainly shouldn't.

> blockUntilFinished() is called in StreamingUpdateSolrServer more often then it should
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-1990
>                 URL: https://issues.apache.org/jira/browse/SOLR-1990
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 1.4.1
>            Reporter: ofer fort
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> in the StreamingUpdateSolrServer .request() it identifies a commit/optimize request by having no document...
> {code}
>     // this happens for commit...
>     if( req.getDocuments()==null || req.getDocuments().isEmpty() ) {
>       blockUntilFinished();
> {code}
> ...but there are other situations where an UpdateRequest will nave no documents (delete, updates using stream.url or stream.file, etc...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org