You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jp0317 (via GitHub)" <gi...@apache.org> on 2024/03/01 03:21:30 UTC
[PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
jp0317 opened a new pull request, #10790:
URL: https://github.com/apache/hudi/pull/10790
### Change Logs
Update libraries-bom in hudi-gcp-bundle/pom.xml to 26.15.0, same as hudi-gcp/pom.xml
### Impact
enable newer version of bigquery library for the bundle
### Risk level (write none, low medium or high below)
low
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #10790:
URL: https://github.com/apache/hudi/pull/10790#discussion_r1508611720
##########
pom.xml:
##########
@@ -1757,6 +1757,13 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>com.google.cloud</groupId>
+ <artifactId>libraries-bom</artifactId>
+ <version>26.15.0</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
This should still be kept at the `hudi-gcp` and `hudi-gcp-bundle` module. My suggestion is to define `<gcp.libraries-bom.bersion>26.15.0</gcp.libraries-bom.bersion>` under `<properties>` in the root POM and use that to avoid hard coding the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10790:
URL: https://github.com/apache/hudi/pull/10790#issuecomment-1972780608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701",
"triggerID" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"triggerType" : "PUSH"
}, {
"hash" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703",
"triggerID" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"triggerType" : "PUSH"
}, {
"hash" : "02e56f80b3a9e8892fc1200ca8628dfb789b70d3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "02e56f80b3a9e8892fc1200ca8628dfb789b70d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a43d8619fc1cb6f9e184201d97bbd930d3ff35e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703)
* 02e56f80b3a9e8892fc1200ca8628dfb789b70d3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #10790:
URL: https://github.com/apache/hudi/pull/10790#discussion_r1508489507
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -39,7 +39,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
- <version>25.1.0</version>
+ <version>26.15.0</version>
Review Comment:
Let's define this version in the root pom and use it in both `hudi-gcp` and `hudi-gcp-bundle` modules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10790:
URL: https://github.com/apache/hudi/pull/10790#issuecomment-1972469376
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701",
"triggerID" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b534145697b0a90a604e94b7d6d8c7db385038a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10790:
URL: https://github.com/apache/hudi/pull/10790#issuecomment-1973049178
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701",
"triggerID" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"triggerType" : "PUSH"
}, {
"hash" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703",
"triggerID" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"triggerType" : "PUSH"
}, {
"hash" : "02e56f80b3a9e8892fc1200ca8628dfb789b70d3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22708",
"triggerID" : "02e56f80b3a9e8892fc1200ca8628dfb789b70d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02e56f80b3a9e8892fc1200ca8628dfb789b70d3 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22708)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10790:
URL: https://github.com/apache/hudi/pull/10790#issuecomment-1972616494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701",
"triggerID" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"triggerType" : "PUSH"
}, {
"hash" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703",
"triggerID" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b534145697b0a90a604e94b7d6d8c7db385038a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701)
* 6a43d8619fc1cb6f9e184201d97bbd930d3ff35e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10790:
URL: https://github.com/apache/hudi/pull/10790#issuecomment-1972624712
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701",
"triggerID" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"triggerType" : "PUSH"
}, {
"hash" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703",
"triggerID" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b534145697b0a90a604e94b7d6d8c7db385038a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701)
* 6a43d8619fc1cb6f9e184201d97bbd930d3ff35e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10790:
URL: https://github.com/apache/hudi/pull/10790#issuecomment-1972689270
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701",
"triggerID" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"triggerType" : "PUSH"
}, {
"hash" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703",
"triggerID" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a43d8619fc1cb6f9e184201d97bbd930d3ff35e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "jp0317 (via GitHub)" <gi...@apache.org>.
jp0317 commented on code in PR #10790:
URL: https://github.com/apache/hudi/pull/10790#discussion_r1508673112
##########
pom.xml:
##########
@@ -1757,6 +1757,13 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>com.google.cloud</groupId>
+ <artifactId>libraries-bom</artifactId>
+ <version>26.15.0</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
got it, made some changes, PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #10790:
URL: https://github.com/apache/hudi/pull/10790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "jp0317 (via GitHub)" <gi...@apache.org>.
jp0317 commented on code in PR #10790:
URL: https://github.com/apache/hudi/pull/10790#discussion_r1508515877
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -39,7 +39,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
- <version>25.1.0</version>
+ <version>26.15.0</version>
Review Comment:
sg. done. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10790:
URL: https://github.com/apache/hudi/pull/10790#issuecomment-1972464245
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b534145697b0a90a604e94b7d6d8c7db385038a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10790:
URL: https://github.com/apache/hudi/pull/10790#issuecomment-1972609585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701",
"triggerID" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"triggerType" : "PUSH"
}, {
"hash" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b534145697b0a90a604e94b7d6d8c7db385038a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701)
* 6a43d8619fc1cb6f9e184201d97bbd930d3ff35e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7459] Update hudi-gcp-bundle pom [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10790:
URL: https://github.com/apache/hudi/pull/10790#issuecomment-1972792528
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22701",
"triggerID" : "1b534145697b0a90a604e94b7d6d8c7db385038a",
"triggerType" : "PUSH"
}, {
"hash" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703",
"triggerID" : "6a43d8619fc1cb6f9e184201d97bbd930d3ff35e",
"triggerType" : "PUSH"
}, {
"hash" : "02e56f80b3a9e8892fc1200ca8628dfb789b70d3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22708",
"triggerID" : "02e56f80b3a9e8892fc1200ca8628dfb789b70d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a43d8619fc1cb6f9e184201d97bbd930d3ff35e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22703)
* 02e56f80b3a9e8892fc1200ca8628dfb789b70d3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22708)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org