You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2022/10/20 07:21:25 UTC
[GitHub] [kylin] zznlime opened a new pull request, #2001: KYLIN-5279 Default null collation for Kylin5.0 sqls should be null-last for ASC order and null-first for DESC order.
zznlime opened a new pull request, #2001:
URL: https://github.com/apache/kylin/pull/2001
according to pgsql: https://www.postgresql.org/docs/current/queries-order.html
By default, null values sort as if larger than any non-null value; that is, NULLS FIRST is the default for DESC order, and NULLS LAST otherwise.
## Branch to commit
- [ ] Branch **kylin3** for v2.x to v3.x
- [ ] Branch **kylin4** for v4.x
- [ x ] Branch **kylin5** for v5.x
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ x ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-5279 Make Kylin project open-source"
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
- [ ] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2001: KYLIN-5279 Default null collation for Kylin5.0 sqls should be null-last for ASC order and null-first for DESC order.
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on PR #2001:
URL: https://github.com/apache/kylin/pull/2001#issuecomment-1290073592
Here is my suggestion.You don't need add a new config entry like: `kylin.query.asc-order-null-first-enable`.
Looks like you can reuse existent config entry in `KylinConfigBase#getCalciteExtrasProperties` and remove the overwrite method `defaultNullCollation` of KECalciteConfig. After that, you
just need set "kylin.query.calcite.extras-props.defaultNullCollation=low/high/first/last" in kylin.properties .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zznlime commented on pull request #2001: KYLIN-5279 Default null collation for Kylin5.0 sqls should be null-last for ASC order and null-first for DESC order.
Posted by GitBox <gi...@apache.org>.
zznlime commented on PR #2001:
URL: https://github.com/apache/kylin/pull/2001#issuecomment-1290563309
Thanks for the suggestion! Have remove the config 'kylin.query.asc-order-null-first-enable', and reuse KylinConfigBase#getCalciteExtrasProperties for setting default null collation.
@hit-lacus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2001: KYLIN-5279 Add default null collation configuration with CalciteExtrasProperties for Kylin5.0
Posted by GitBox <gi...@apache.org>.
hit-lacus merged PR #2001:
URL: https://github.com/apache/kylin/pull/2001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zznlime commented on pull request #2001: KYLIN-5279 Default null collation for Kylin5.0 sqls should be null-last for ASC order and null-first for DESC order.
Posted by GitBox <gi...@apache.org>.
zznlime commented on PR #2001:
URL: https://github.com/apache/kylin/pull/2001#issuecomment-1285064622
@hit-lacus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2001: KYLIN-5279 Default null collation for Kylin5.0 sqls should be null-last for ASC order and null-first for DESC order.
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on PR #2001:
URL: https://github.com/apache/kylin/pull/2001#issuecomment-1291530344
LGTM, I will merge it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org