You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Fryguy <gi...@git.apache.org> on 2017/07/18 15:52:11 UTC
[GitHub] qpid-proton pull request #111: Fix mapping of LONG for Ruby 2.4+
GitHub user Fryguy opened a pull request:
https://github.com/apache/qpid-proton/pull/111
Fix mapping of LONG for Ruby 2.4+
(Ruby 2.4.1) > irb
> RUBY_VERSION < "2.4" ? [Fixnum, Bignum] : [Integer]
=> [Integer]
(Ruby 2.3.3) > irb
> RUBY_VERSION < "2.4" ? [Fixnum, Bignum] : [Integer]
=> [Fixnum, Bignum]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Fryguy/qpid-proton fix_mapping_for_ruby24
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #111: Fix mapping of LONG for Ruby 2.4+
Posted by Fryguy <gi...@git.apache.org>.
Github user Fryguy closed the pull request at:
https://github.com/apache/qpid-proton/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #111: Fix mapping of LONG for Ruby 2.4+
Posted by Fryguy <gi...@git.apache.org>.
GitHub user Fryguy reopened a pull request:
https://github.com/apache/qpid-proton/pull/111
Fix mapping of LONG for Ruby 2.4+
```
(Ruby 2.4.1) > irb
> RUBY_VERSION < "2.4" ? [Fixnum, Bignum] : [Integer]
=> [Integer]
(Ruby 2.3.3) > irb
> RUBY_VERSION < "2.4" ? [Fixnum, Bignum] : [Integer]
=> [Fixnum, Bignum]
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Fryguy/qpid-proton fix_mapping_for_ruby24
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit ce10cf90c78d458826b56e9e03e55921dcb8e689
Author: Jason Frey <fr...@gmail.com>
Date: 2017-07-18T15:49:23Z
Fix mapping of LONG for Ruby 2.4+
(Ruby 2.4.1) > irb
> RUBY_VERSION < "2.4" ? [Fixnum, Bignum] : [Integer]
=> [Integer]
(Ruby 2.3.3) > irb
> RUBY_VERSION < "2.4" ? [Fixnum, Bignum] : [Integer]
=> [Fixnum, Bignum]
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #111: Fix mapping of LONG for Ruby 2.4+
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #111: Fix mapping of LONG for Ruby 2.4+
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/111
I applied this fix - that's why it's closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #111: Fix mapping of LONG for Ruby 2.4+
Posted by alanconway <gi...@git.apache.org>.
Github user alanconway commented on the issue:
https://github.com/apache/qpid-proton/pull/111
I'd like to apply this fix - why did you close the PR? Did you find a problem? Please respond on https://issues.apache.org/jira/browse/PROTON-1519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #111: Fix mapping of LONG for Ruby 2.4+
Posted by kbrock <gi...@git.apache.org>.
Github user kbrock commented on the issue:
https://github.com/apache/qpid-proton/pull/111
Also fun:
```
(Ruby 2.4.1) > irb
> Integer == Fixnum
(irb):1: warning: constant ::Fixnum is deprecated
=> true
(Ruby 2.3.3) > irb
> Integer == Fixnum
=> false
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org