You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by cnZach <gi...@git.apache.org> on 2017/10/24 05:52:39 UTC

[GitHub] kafka pull request #4125: KAFKA-6105: load client properties in proper order...

GitHub user cnZach opened a pull request:

    https://github.com/apache/kafka/pull/4125

    KAFKA-6105: load client properties in proper order for EndToEndLatency tool

    Currently, the property file is loaded first, and later a auto generated group.id is used:
    consumerProps.put(ConsumerConfig.GROUP_ID_CONFIG, "test-group-" + System.currentTimeMillis())
    
    so even user gives the group.id in a property file, it is not picked up.
    
    Change it to load client properties in proper order: set default values first, then try to load the custom values set in client.properties file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cnZach/kafka cnZach_KAFKA-6105

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4125
    
----
commit 448ea9df1f735da5362eb3204e9bd7a133516fb2
Author: Yuexin Zhang <za...@gmail.com>
Date:   2017-10-24T05:48:04Z

    load client properties in proper order: set default values first, then try to load the custom values set in client.properties file

----


---