You are viewing a plain text version of this content. The canonical link for it is here.
Posted to npanday-dev@incubator.apache.org by "Brett Porter (JIRA)" <ji...@apache.org> on 2014/07/14 01:47:05 UTC
[jira] [Comment Edited] (NPANDAY-525) Make sure
UnifiedShellCommandExecutor works with BourneShell
[ https://issues.apache.org/jira/browse/NPANDAY-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060269#comment-14060269 ]
Brett Porter edited comment on NPANDAY-525 at 7/14/14 1:45 AM:
---------------------------------------------------------------
Any progress David?
These are what I've found so far:
- some failures occur because the tests check the output of an "echo" command, however echo's handling of quotes is different on Mac, Linux and Windows, so you can't have just one assertion. Either need to adjust the assertions per OS, or use a different command than echo that can equally test quoting
- the tests seem to want to run {{/bin/sh -c echo ...}}, where it should be {{/bin/sh -c "echo ..."}}, which would be a problem in the executor
was (Author: brettporter):
Any progress David?
These are what I've found so far:
- some failures occur because the tests check the output of an "echo" command, however echo's handling of quotes is different on Mac, Linux and Windows, so you can't have just one assertion. Either need to adjust the assertions per OS, or use a different command than echo that can equally test quoting
- the tests seem to want to run {{/bin/sh -c echo ...}}, where it should be /bin/sh -c "echo ...", which would be a problem in the executor
> Make sure UnifiedShellCommandExecutor works with BourneShell
> ------------------------------------------------------------
>
> Key: NPANDAY-525
> URL: https://issues.apache.org/jira/browse/NPANDAY-525
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Reporter: Lars Corneliussen
> Fix For: 1.5.0-incubating
>
>
> As Part of NPANDAY-509 the execution engine for executing shell commands was replaced. We have to make sure, that quoting++ still works as expected on !Windows.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Re: [jira] [Comment Edited] (NPANDAY-525) Make sure UnifiedShellCommandExecutor works with BourneShell
Posted by Brett Porter <br...@apache.org>.
Thanks David - I've also responded on the JIRA ticket.
Do you have any thoughts on how to correct this?
- Brett
On 15 Jul 2014, at 4:23 am, David Akehurst <da...@akehurst.net> wrote:
> I have just tried to do a build on linux, the output is attached.
>
> it doesn't build for me.
>
>
> On 14 July 2014 03:47, Brett Porter (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/NPANDAY-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060269#comment-14060269 ]
>
> Brett Porter edited comment on NPANDAY-525 at 7/14/14 1:45 AM:
> ---------------------------------------------------------------
>
> Any progress David?
>
> These are what I've found so far:
> - some failures occur because the tests check the output of an "echo" command, however echo's handling of quotes is different on Mac, Linux and Windows, so you can't have just one assertion. Either need to adjust the assertions per OS, or use a different command than echo that can equally test quoting
> - the tests seem to want to run {{/bin/sh -c echo ...}}, where it should be {{/bin/sh -c "echo ..."}}, which would be a problem in the executor
>
>
> was (Author: brettporter):
> Any progress David?
>
> These are what I've found so far:
> - some failures occur because the tests check the output of an "echo" command, however echo's handling of quotes is different on Mac, Linux and Windows, so you can't have just one assertion. Either need to adjust the assertions per OS, or use a different command than echo that can equally test quoting
> - the tests seem to want to run {{/bin/sh -c echo ...}}, where it should be /bin/sh -c "echo ...", which would be a problem in the executor
>
> > Make sure UnifiedShellCommandExecutor works with BourneShell
> > ------------------------------------------------------------
> >
> > Key: NPANDAY-525
> > URL: https://issues.apache.org/jira/browse/NPANDAY-525
> > Project: NPanday
> > Issue Type: Improvement
> > Components: Maven Plugins
> > Reporter: Lars Corneliussen
> > Fix For: 1.5.0-incubating
> >
> >
> > As Part of NPANDAY-509 the execution engine for executing shell commands was replaced. We have to make sure, that quoting++ still works as expected on !Windows.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.2#6252)
>
> <out.txt>
Re: [jira] [Comment Edited] (NPANDAY-525) Make sure
UnifiedShellCommandExecutor works with BourneShell
Posted by David Akehurst <da...@akehurst.net>.
I have just tried to do a build on linux, the output is attached.
it doesn't build for me.
On 14 July 2014 03:47, Brett Porter (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/NPANDAY-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060269#comment-14060269
> ]
>
> Brett Porter edited comment on NPANDAY-525 at 7/14/14 1:45 AM:
> ---------------------------------------------------------------
>
> Any progress David?
>
> These are what I've found so far:
> - some failures occur because the tests check the output of an "echo"
> command, however echo's handling of quotes is different on Mac, Linux and
> Windows, so you can't have just one assertion. Either need to adjust the
> assertions per OS, or use a different command than echo that can equally
> test quoting
> - the tests seem to want to run {{/bin/sh -c echo ...}}, where it should
> be {{/bin/sh -c "echo ..."}}, which would be a problem in the executor
>
>
> was (Author: brettporter):
> Any progress David?
>
> These are what I've found so far:
> - some failures occur because the tests check the output of an "echo"
> command, however echo's handling of quotes is different on Mac, Linux and
> Windows, so you can't have just one assertion. Either need to adjust the
> assertions per OS, or use a different command than echo that can equally
> test quoting
> - the tests seem to want to run {{/bin/sh -c echo ...}}, where it should
> be /bin/sh -c "echo ...", which would be a problem in the executor
>
> > Make sure UnifiedShellCommandExecutor works with BourneShell
> > ------------------------------------------------------------
> >
> > Key: NPANDAY-525
> > URL: https://issues.apache.org/jira/browse/NPANDAY-525
> > Project: NPanday
> > Issue Type: Improvement
> > Components: Maven Plugins
> > Reporter: Lars Corneliussen
> > Fix For: 1.5.0-incubating
> >
> >
> > As Part of NPANDAY-509 the execution engine for executing shell commands
> was replaced. We have to make sure, that quoting++ still works as expected
> on !Windows.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.2#6252)
>