You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/19 21:50:10 UTC
[GitHub] [incubator-superset] suddjian opened a new issue #9171: Owner
selectors sometimes display name, other times display username
suddjian opened a new issue #9171: Owner selectors sometimes display name, other times display username
URL: https://github.com/apache/incubator-superset/issues/9171
The Edit Dashboard and Edit Chart modals display the user's full name when selecting an owner from the dropdown, but display the username when simply displaying the existing owners.
The cause of this is that the `/dashboard/related/owners` api endpoint returns full name, while the `/dashboard/:id` endpoint returns only the username, so the modal is just using the information that it has available. Both endpoints return the user id, so this doesn't lead to real bugs, just visual confusion. I think the best solution would be for the endpoints to return more information, but I'm unsure how to accomplish that within FAB. Open to other suggestions as well.
Pinging @dpgaspar for FAB expertise.
### Expected results
Should use the owner's name
### Actual results
Mixed results
#### Screenshots
If applicable, add screenshots to help explain your problem.
#### How to reproduce the bug
1. Go to a chart or a dashboard
2. Click on "edit properties" to open the edit modal
3. Set some owners
4. Reload the modal, owners are now displayed by username instead of name
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #9171: Owner
selectors sometimes display full name, other times username
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #9171: Owner selectors sometimes display full name, other times username
URL: https://github.com/apache/incubator-superset/issues/9171#issuecomment-588494060
Seems like the related endpoint is just using `str(col)` which is configured in FAB, I believe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #9171: Owner
selectors sometimes display full name, other times username
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #9171: Owner selectors sometimes display full name, other times username
URL: https://github.com/apache/incubator-superset/issues/9171#issuecomment-589150511
@nytai The related will use whatever you configure on the model magic method `__repr__(self)`. On this case, Model `USer` is on FAB
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #9171: Owner
selectors sometimes display full name, other times username
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #9171: Owner selectors sometimes display full name, other times username
URL: https://github.com/apache/incubator-superset/issues/9171#issuecomment-588492579
@suddjian These are the fields for the `/dashboard/:id` endpoint https://github.com/apache/incubator-superset/blob/master/superset/views/dashboard/api.py#L144
This is the `/related/:col_name` endpoint https://github.com/apache/incubator-superset/blob/master/superset/views/base_api.py#L132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #9171: Owner selectors sometimes display full name, other times username
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9171:
URL: https://github.com/apache/incubator-superset/issues/9171#issuecomment-618175759
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on issue #9171: Owner selectors sometimes display full name, other times username
Posted by GitBox <gi...@apache.org>.
suddjian commented on issue #9171:
URL: https://github.com/apache/incubator-superset/issues/9171#issuecomment-618213017
This was fixed a while ago
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org