[GitHub] [camel] sdurrenmatt commented on a diff in pull request #10325: CAMEL-19417: camel-spring-rabbitmq - convert all message properties by default

["sdurrenmatt (via GitHub)" <gi...@apache.org>]

sdurrenmatt commented on code in PR #10325:
URL: https://github.com/apache/camel/pull/10325#discussion_r1225493146


##########
components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/DefaultMessagePropertiesConverter.java:
##########
@@ -39,9 +40,64 @@ public DefaultMessagePropertiesConverter(CamelContext camelContext, HeaderFilter
     @Override
     public MessageProperties toMessageProperties(Exchange exchange) {
         MessageProperties answer = new MessageProperties();
-        String contentType = ExchangeHelper.getContentType(exchange);
+
+        Object deliveryMode = exchange.getMessage().removeHeader(SpringRabbitMQConstants.DELIVERY_MODE);
+        if (deliveryMode != null) {
+            answer.setDeliveryMode(deliveryMode instanceof MessageDeliveryMode ? (MessageDeliveryMode) deliveryMode
+                    : MessageDeliveryMode.fromInt(Integer.parseInt(deliveryMode.toString())));
+        }
+        Object type = exchange.getMessage().removeHeader(SpringRabbitMQConstants.TYPE);

Review Comment:
   Yes we do not want it to be copied later on to the RabbitMQ message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org