You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by Kevin Doran <kd...@apache.org> on 2023/01/25 23:34:37 UTC
Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
Hi all,
The issues raised on this thread have all been addressed, so I’d like to
revive this goal to release NiFi NAR Maven Plugin 1.4.0 soon.
Unless anyone is aware of additional items to include, I plan to start
preparing a release candidate this week.
Thanks,
Kevin
On Nov 30, 2022 at 14:28:00, Kevin Doran <kd...@apache.org> wrote:
> Thanks, Bryan! There is no urgency around this release, so I'm happy to
> wait for that.
>
> On Nov 30, 2022 at 14:24:02, Bryan Bende <bb...@gmail.com> wrote:
>
>> Thanks Kevin!
>>
>> There is actually one change I was planning to start working on, and
>> since we don't release the NAR plugin very frequently, I would like to
>> try and get it in before this release.
>>
>> I created this JIRA [1] for the issue, and I can report back here once
>> I start working on it to see if it looks like it will still be
>> something to wait on.
>>
>> [1] https://issues.apache.org/jira/browse/NIFI-10915
>>
>>
>> On Wed, Nov 30, 2022 at 9:43 AM David Handermann
>> <ex...@apache.org> wrote:
>>
>>
>> Mark,
>>
>>
>> The dependency duplication detection is a new optional goal of the NAR
>>
>> plugin. The basic purpose is to detect unnecessary dependencies in the
>>
>> compile scope, which are already provided from a parent NAR dependency.
>>
>>
>> For example, the nifi-standard-service-api-nar includes the
>>
>> nifi-ssl-context-service-api library. The nifi-web-client-provider-service
>>
>> depends on nifi-ssl-context-service-api, and identifies it correctly with
>>
>> the provided scope in the Maven configuration. The
>>
>> nifi-web-client-provider-service-nar bundles
>>
>> nifi-web-client-provider-service, and depends on
>>
>> nifi-standard-service-api-nar. If the nifi-ssl-context-service-api was not
>>
>> marked as provided, the new duplication detection goal would flag the
>>
>> unnecessary inclusion of the nifi-ssl-context-service-api.
>>
>>
>> The duplication detection will help avoid including unnecessary
>>
>> dependencies, and also avoid unexpected runtime behavior. The NiFi NAR
>>
>> class loading hierarchy uses libraries from the parent NAR at runtime, so
>>
>> avoiding unnecessary dependency inclusion is important for these reasons.
>>
>> The goal is optional, and will require additional changes to enable by
>>
>> default in NiFi builds, but it should be very helpful for future releases.
>>
>>
>> Regards,
>>
>> David Handermann
>>
>>
>> On Wed, Nov 30, 2022 at 7:36 AM Mark Bean <ma...@gmail.com> wrote:
>>
>>
>> > Sounds great Kevin. Thanks!
>>
>> >
>>
>> > Can you give a little more detail on the dependency duplication
>> detection?
>>
>> > How does it work? Does it detect different versions of the same
>> dependency?
>>
>> > Is it detecting duplicates only within a given NAR or across multiple
>> NARs?
>>
>> >
>>
>> > Thanks,
>>
>> > Mark
>>
>> >
>>
>> >
>>
>> > On Tue, Nov 29, 2022 at 4:18 PM Kevin Doran <kd...@apache.org> wrote:
>>
>> >
>>
>> > > Hi all,
>>
>> > >
>>
>> > > There’s been a few improvements and bug fixes to the NAR Maven Plugin.
>>
>> > One
>>
>> > > nice new feature is a new maven goal that detects duplicate
>> dependencies
>>
>> > in
>>
>> > > NARs. Another contribution improves our NiFi build reproducibility.
>>
>> > >
>>
>> > > Given all this, I’d like to release a new version of the plugin that
>> we
>>
>> > can
>>
>> > > start using in NiFi. As this includes a feature, this will be a minor
>>
>> > > version bump (1.4.0).
>>
>> > >
>>
>> > > I’m happy to RM. There are two outstanding PRs, and if there are no
>>
>> > > objections on this thread, I’ll wait for those to be merged and then
>>
>> > > prepare a release candidate.
>>
>> > >
>>
>> > > Thanks,
>>
>> > > Kevin
>>
>> > >
>>
>> >
>>
>>
Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
Posted by Kevin Doran <kd...@apache.org>.
Thanks all. Will kickoff the RC soon.
Kevin
On Jan 26, 2023 at 10:22:23, Harry Clarke <ha...@outlook.com> wrote:
> It seems I'm unable to reproduce at the moment anyway (annoyingly working
> even with the same versions as before!)
>
> I'm happy to drop this, and continue this in Slack/Jira if I'm able to get
> any results.
>
> On the plus side, my team may be able to move to Java 17 now!
> ________________________________
> From: Joe Witt <jo...@gmail.com>
> Sent: 26 January 2023 15:11
> To: dev@nifi.apache.org <de...@nifi.apache.org>
> Subject: Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
>
> Bryan - agreed. Those are maven specific issues/settings. I dont think it
> has any relationship to this thread in terms of a nar maven plugin release.
>
> Thanks
>
> On Thu, Jan 26, 2023 at 8:10 AM Bryan Bende <bb...@gmail.com> wrote:
>
> Thanks Kevin.
>
>
> Just to clarify, the Maven issues mentioned here don't sound specific
>
> to the NAR plugin, but sound like general Maven issues? or am I
>
> mis-interpreting?
>
>
> On Wed, Jan 25, 2023 at 6:56 PM Joe Witt <jo...@gmail.com> wrote:
>
> >
>
> > Thanks Kevin. Sounds good.
>
> >
>
> > If you can start that soon I can draft 1.20 off that..
>
> >
>
> > thanks
>
> >
>
> > On Wed, Jan 25, 2023 at 4:46 PM Kevin Doran <kd...@apache.org> wrote:
>
> >
>
> > > Hi Harry,
>
> > >
>
> > > Thanks for the heads up. If you can share those findings, there's a
>
> few of
>
> > > us on this list that could help look into them and see if NiFi can do
>
> > > anything to work around potential Maven issues.
>
> > >
>
> > > Cheers,
>
> > > Kevin
>
> > >
>
> > > On Jan 25, 2023 at 18:42:07, Harry Clarke <ha...@outlook.com>
>
> > > wrote:
>
> > >
>
> > > > I'm not sure how to view what's been worked on since the last
>
> release,
>
> > > but
>
> > > > my team did notice an issue with 3.8.1 of Maven that isn't present in
>
> > > 3.6.1.
>
> > > >
>
> > > > It's hard to nail down exactly what's going on, but it looked to be
>
> that
>
> > > > plugin repository proxy settings weren't being honoured by Maven
>
> within
>
> > > the
>
> > > > settings.xml files, and pom.xml repo declarations were taking
>
> precedence.
>
> > > > Of course, this fails immediately if you're behind a firewall.
>
> > > >
>
> > > > I'll try to dig up where we got to with our investigation, but this
>
> was a
>
> > > > blocker for us moving to Java 17.
>
> > > > ________________________________
>
> > > > From: Kevin Doran <kd...@apache.org>
>
> > > > Sent: 25 January 2023 23:34
>
> > > > To: dev@nifi.apache.org <de...@nifi.apache.org>
>
> > > > Subject: Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
>
> > > >
>
> > > > Hi all,
>
> > > >
>
> > > > The issues raised on this thread have all been addressed, so I’d
>
> like to
>
> > > > revive this goal to release NiFi NAR Maven Plugin 1.4.0 soon.
>
> > > >
>
> > > > Unless anyone is aware of additional items to include, I plan to
>
> start
>
> > > > preparing a release candidate this week.
>
> > > >
>
> > > > Thanks,
>
> > > > Kevin
>
> > > >
>
> > > > On Nov 30, 2022 at 14:28:00, Kevin Doran <kd...@apache.org> wrote:
>
> > > >
>
> > > > Thanks, Bryan! There is no urgency around this release, so I'm happy
>
> to
>
> > > >
>
> > > > wait for that.
>
> > > >
>
> > > >
>
> > > > On Nov 30, 2022 at 14:24:02, Bryan Bende <bb...@gmail.com> wrote:
>
> > > >
>
> > > >
>
> > > > > Thanks Kevin!
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > There is actually one change I was planning to start working on,
>
> and
>
> > > >
>
> > > > > since we don't release the NAR plugin very frequently, I would
>
> like to
>
> > > >
>
> > > > > try and get it in before this release.
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > I created this JIRA [1] for the issue, and I can report back here
>
> once
>
> > > >
>
> > > > > I start working on it to see if it looks like it will still be
>
> > > >
>
> > > > > something to wait on.
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > [1] https://issues.apache.org/jira/browse/NIFI-10915
>
> > > >
>
> > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > On Wed, Nov 30, 2022 at 9:43 AM David Handermann
>
> > > >
>
> > > > > <ex...@apache.org> wrote:
>
> > > >
>
> > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > Mark,
>
> > > >
>
> > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > The dependency duplication detection is a new optional goal of the
>
> NAR
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > plugin. The basic purpose is to detect unnecessary dependencies in
>
> the
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > compile scope, which are already provided from a parent NAR
>
> dependency.
>
> > > >
>
> > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > For example, the nifi-standard-service-api-nar includes the
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > nifi-ssl-context-service-api library. The
>
> > > > nifi-web-client-provider-service
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > depends on nifi-ssl-context-service-api, and identifies it
>
> correctly
>
> > > with
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > the provided scope in the Maven configuration. The
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > nifi-web-client-provider-service-nar bundles
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > nifi-web-client-provider-service, and depends on
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > nifi-standard-service-api-nar. If the nifi-ssl-context-service-api
>
> was
>
> > > > not
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > marked as provided, the new duplication detection goal would flag
>
> the
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > unnecessary inclusion of the nifi-ssl-context-service-api.
>
> > > >
>
> > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > The duplication detection will help avoid including unnecessary
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > dependencies, and also avoid unexpected runtime behavior. The NiFi
>
> NAR
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > class loading hierarchy uses libraries from the parent NAR at
>
> runtime,
>
> > > so
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > avoiding unnecessary dependency inclusion is important for these
>
> > > reasons.
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > The goal is optional, and will require additional changes to
>
> enable by
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > default in NiFi builds, but it should be very helpful for future
>
> > > > releases.
>
> > > >
>
> > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > Regards,
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > David Handermann
>
> > > >
>
> > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > On Wed, Nov 30, 2022 at 7:36 AM Mark Bean <ma...@gmail.com>
>
> > > wrote:
>
> > > >
>
> > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > Sounds great Kevin. Thanks!
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > Can you give a little more detail on the dependency duplication
>
> > > >
>
> > > > > detection?
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > How does it work? Does it detect different versions of the same
>
> > > >
>
> > > > > dependency?
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > Is it detecting duplicates only within a given NAR or across
>
> multiple
>
> > > >
>
> > > > > NARs?
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > Thanks,
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > Mark
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > On Tue, Nov 29, 2022 at 4:18 PM Kevin Doran <kd...@apache.org>
>
> > > wrote:
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > Hi all,
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > There’s been a few improvements and bug fixes to the NAR Maven
>
> > > > Plugin.
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > One
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > nice new feature is a new maven goal that detects duplicate
>
> > > >
>
> > > > > dependencies
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > in
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > NARs. Another contribution improves our NiFi build
>
> reproducibility.
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > Given all this, I’d like to release a new version of the plugin
>
> > > that
>
> > > >
>
> > > > > we
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > can
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > start using in NiFi. As this includes a feature, this will be a
>
> > > minor
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > version bump (1.4.0).
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > I’m happy to RM. There are two outstanding PRs, and if there
>
> are no
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > objections on this thread, I’ll wait for those to be merged and
>
> > > then
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > prepare a release candidate.
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > Thanks,
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > > Kevin
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > > >
>
> > > >
>
> > > >
>
> > >
>
>
>
Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
Posted by Harry Clarke <ha...@outlook.com>.
It seems I'm unable to reproduce at the moment anyway (annoyingly working even with the same versions as before!)
I'm happy to drop this, and continue this in Slack/Jira if I'm able to get any results.
On the plus side, my team may be able to move to Java 17 now!
________________________________
From: Joe Witt <jo...@gmail.com>
Sent: 26 January 2023 15:11
To: dev@nifi.apache.org <de...@nifi.apache.org>
Subject: Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
Bryan - agreed. Those are maven specific issues/settings. I dont think it
has any relationship to this thread in terms of a nar maven plugin release.
Thanks
On Thu, Jan 26, 2023 at 8:10 AM Bryan Bende <bb...@gmail.com> wrote:
> Thanks Kevin.
>
> Just to clarify, the Maven issues mentioned here don't sound specific
> to the NAR plugin, but sound like general Maven issues? or am I
> mis-interpreting?
>
> On Wed, Jan 25, 2023 at 6:56 PM Joe Witt <jo...@gmail.com> wrote:
> >
> > Thanks Kevin. Sounds good.
> >
> > If you can start that soon I can draft 1.20 off that..
> >
> > thanks
> >
> > On Wed, Jan 25, 2023 at 4:46 PM Kevin Doran <kd...@apache.org> wrote:
> >
> > > Hi Harry,
> > >
> > > Thanks for the heads up. If you can share those findings, there's a
> few of
> > > us on this list that could help look into them and see if NiFi can do
> > > anything to work around potential Maven issues.
> > >
> > > Cheers,
> > > Kevin
> > >
> > > On Jan 25, 2023 at 18:42:07, Harry Clarke <ha...@outlook.com>
> > > wrote:
> > >
> > > > I'm not sure how to view what's been worked on since the last
> release,
> > > but
> > > > my team did notice an issue with 3.8.1 of Maven that isn't present in
> > > 3.6.1.
> > > >
> > > > It's hard to nail down exactly what's going on, but it looked to be
> that
> > > > plugin repository proxy settings weren't being honoured by Maven
> within
> > > the
> > > > settings.xml files, and pom.xml repo declarations were taking
> precedence.
> > > > Of course, this fails immediately if you're behind a firewall.
> > > >
> > > > I'll try to dig up where we got to with our investigation, but this
> was a
> > > > blocker for us moving to Java 17.
> > > > ________________________________
> > > > From: Kevin Doran <kd...@apache.org>
> > > > Sent: 25 January 2023 23:34
> > > > To: dev@nifi.apache.org <de...@nifi.apache.org>
> > > > Subject: Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
> > > >
> > > > Hi all,
> > > >
> > > > The issues raised on this thread have all been addressed, so I’d
> like to
> > > > revive this goal to release NiFi NAR Maven Plugin 1.4.0 soon.
> > > >
> > > > Unless anyone is aware of additional items to include, I plan to
> start
> > > > preparing a release candidate this week.
> > > >
> > > > Thanks,
> > > > Kevin
> > > >
> > > > On Nov 30, 2022 at 14:28:00, Kevin Doran <kd...@apache.org> wrote:
> > > >
> > > > Thanks, Bryan! There is no urgency around this release, so I'm happy
> to
> > > >
> > > > wait for that.
> > > >
> > > >
> > > > On Nov 30, 2022 at 14:24:02, Bryan Bende <bb...@gmail.com> wrote:
> > > >
> > > >
> > > > > Thanks Kevin!
> > > >
> > > > >
> > > >
> > > > > There is actually one change I was planning to start working on,
> and
> > > >
> > > > > since we don't release the NAR plugin very frequently, I would
> like to
> > > >
> > > > > try and get it in before this release.
> > > >
> > > > >
> > > >
> > > > > I created this JIRA [1] for the issue, and I can report back here
> once
> > > >
> > > > > I start working on it to see if it looks like it will still be
> > > >
> > > > > something to wait on.
> > > >
> > > > >
> > > >
> > > > > [1] https://issues.apache.org/jira/browse/NIFI-10915
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > On Wed, Nov 30, 2022 at 9:43 AM David Handermann
> > > >
> > > > > <ex...@apache.org> wrote:
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > Mark,
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > The dependency duplication detection is a new optional goal of the
> NAR
> > > >
> > > > >
> > > >
> > > > > plugin. The basic purpose is to detect unnecessary dependencies in
> the
> > > >
> > > > >
> > > >
> > > > > compile scope, which are already provided from a parent NAR
> dependency.
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > For example, the nifi-standard-service-api-nar includes the
> > > >
> > > > >
> > > >
> > > > > nifi-ssl-context-service-api library. The
> > > > nifi-web-client-provider-service
> > > >
> > > > >
> > > >
> > > > > depends on nifi-ssl-context-service-api, and identifies it
> correctly
> > > with
> > > >
> > > > >
> > > >
> > > > > the provided scope in the Maven configuration. The
> > > >
> > > > >
> > > >
> > > > > nifi-web-client-provider-service-nar bundles
> > > >
> > > > >
> > > >
> > > > > nifi-web-client-provider-service, and depends on
> > > >
> > > > >
> > > >
> > > > > nifi-standard-service-api-nar. If the nifi-ssl-context-service-api
> was
> > > > not
> > > >
> > > > >
> > > >
> > > > > marked as provided, the new duplication detection goal would flag
> the
> > > >
> > > > >
> > > >
> > > > > unnecessary inclusion of the nifi-ssl-context-service-api.
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > The duplication detection will help avoid including unnecessary
> > > >
> > > > >
> > > >
> > > > > dependencies, and also avoid unexpected runtime behavior. The NiFi
> NAR
> > > >
> > > > >
> > > >
> > > > > class loading hierarchy uses libraries from the parent NAR at
> runtime,
> > > so
> > > >
> > > > >
> > > >
> > > > > avoiding unnecessary dependency inclusion is important for these
> > > reasons.
> > > >
> > > > >
> > > >
> > > > > The goal is optional, and will require additional changes to
> enable by
> > > >
> > > > >
> > > >
> > > > > default in NiFi builds, but it should be very helpful for future
> > > > releases.
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > Regards,
> > > >
> > > > >
> > > >
> > > > > David Handermann
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > On Wed, Nov 30, 2022 at 7:36 AM Mark Bean <ma...@gmail.com>
> > > wrote:
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > > Sounds great Kevin. Thanks!
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > > > Can you give a little more detail on the dependency duplication
> > > >
> > > > > detection?
> > > >
> > > > >
> > > >
> > > > > > How does it work? Does it detect different versions of the same
> > > >
> > > > > dependency?
> > > >
> > > > >
> > > >
> > > > > > Is it detecting duplicates only within a given NAR or across
> multiple
> > > >
> > > > > NARs?
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > > > Thanks,
> > > >
> > > > >
> > > >
> > > > > > Mark
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > > > On Tue, Nov 29, 2022 at 4:18 PM Kevin Doran <kd...@apache.org>
> > > wrote:
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > > > > Hi all,
> > > >
> > > > >
> > > >
> > > > > > >
> > > >
> > > > >
> > > >
> > > > > > > There’s been a few improvements and bug fixes to the NAR Maven
> > > > Plugin.
> > > >
> > > > >
> > > >
> > > > > > One
> > > >
> > > > >
> > > >
> > > > > > > nice new feature is a new maven goal that detects duplicate
> > > >
> > > > > dependencies
> > > >
> > > > >
> > > >
> > > > > > in
> > > >
> > > > >
> > > >
> > > > > > > NARs. Another contribution improves our NiFi build
> reproducibility.
> > > >
> > > > >
> > > >
> > > > > > >
> > > >
> > > > >
> > > >
> > > > > > > Given all this, I’d like to release a new version of the plugin
> > > that
> > > >
> > > > > we
> > > >
> > > > >
> > > >
> > > > > > can
> > > >
> > > > >
> > > >
> > > > > > > start using in NiFi. As this includes a feature, this will be a
> > > minor
> > > >
> > > > >
> > > >
> > > > > > > version bump (1.4.0).
> > > >
> > > > >
> > > >
> > > > > > >
> > > >
> > > > >
> > > >
> > > > > > > I’m happy to RM. There are two outstanding PRs, and if there
> are no
> > > >
> > > > >
> > > >
> > > > > > > objections on this thread, I’ll wait for those to be merged and
> > > then
> > > >
> > > > >
> > > >
> > > > > > > prepare a release candidate.
> > > >
> > > > >
> > > >
> > > > > > >
> > > >
> > > > >
> > > >
> > > > > > > Thanks,
> > > >
> > > > >
> > > >
> > > > > > > Kevin
> > > >
> > > > >
> > > >
> > > > > > >
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > >
> > >
>
Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
Posted by Joe Witt <jo...@gmail.com>.
Bryan - agreed. Those are maven specific issues/settings. I dont think it
has any relationship to this thread in terms of a nar maven plugin release.
Thanks
On Thu, Jan 26, 2023 at 8:10 AM Bryan Bende <bb...@gmail.com> wrote:
> Thanks Kevin.
>
> Just to clarify, the Maven issues mentioned here don't sound specific
> to the NAR plugin, but sound like general Maven issues? or am I
> mis-interpreting?
>
> On Wed, Jan 25, 2023 at 6:56 PM Joe Witt <jo...@gmail.com> wrote:
> >
> > Thanks Kevin. Sounds good.
> >
> > If you can start that soon I can draft 1.20 off that..
> >
> > thanks
> >
> > On Wed, Jan 25, 2023 at 4:46 PM Kevin Doran <kd...@apache.org> wrote:
> >
> > > Hi Harry,
> > >
> > > Thanks for the heads up. If you can share those findings, there's a
> few of
> > > us on this list that could help look into them and see if NiFi can do
> > > anything to work around potential Maven issues.
> > >
> > > Cheers,
> > > Kevin
> > >
> > > On Jan 25, 2023 at 18:42:07, Harry Clarke <ha...@outlook.com>
> > > wrote:
> > >
> > > > I'm not sure how to view what's been worked on since the last
> release,
> > > but
> > > > my team did notice an issue with 3.8.1 of Maven that isn't present in
> > > 3.6.1.
> > > >
> > > > It's hard to nail down exactly what's going on, but it looked to be
> that
> > > > plugin repository proxy settings weren't being honoured by Maven
> within
> > > the
> > > > settings.xml files, and pom.xml repo declarations were taking
> precedence.
> > > > Of course, this fails immediately if you're behind a firewall.
> > > >
> > > > I'll try to dig up where we got to with our investigation, but this
> was a
> > > > blocker for us moving to Java 17.
> > > > ________________________________
> > > > From: Kevin Doran <kd...@apache.org>
> > > > Sent: 25 January 2023 23:34
> > > > To: dev@nifi.apache.org <de...@nifi.apache.org>
> > > > Subject: Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
> > > >
> > > > Hi all,
> > > >
> > > > The issues raised on this thread have all been addressed, so I’d
> like to
> > > > revive this goal to release NiFi NAR Maven Plugin 1.4.0 soon.
> > > >
> > > > Unless anyone is aware of additional items to include, I plan to
> start
> > > > preparing a release candidate this week.
> > > >
> > > > Thanks,
> > > > Kevin
> > > >
> > > > On Nov 30, 2022 at 14:28:00, Kevin Doran <kd...@apache.org> wrote:
> > > >
> > > > Thanks, Bryan! There is no urgency around this release, so I'm happy
> to
> > > >
> > > > wait for that.
> > > >
> > > >
> > > > On Nov 30, 2022 at 14:24:02, Bryan Bende <bb...@gmail.com> wrote:
> > > >
> > > >
> > > > > Thanks Kevin!
> > > >
> > > > >
> > > >
> > > > > There is actually one change I was planning to start working on,
> and
> > > >
> > > > > since we don't release the NAR plugin very frequently, I would
> like to
> > > >
> > > > > try and get it in before this release.
> > > >
> > > > >
> > > >
> > > > > I created this JIRA [1] for the issue, and I can report back here
> once
> > > >
> > > > > I start working on it to see if it looks like it will still be
> > > >
> > > > > something to wait on.
> > > >
> > > > >
> > > >
> > > > > [1] https://issues.apache.org/jira/browse/NIFI-10915
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > On Wed, Nov 30, 2022 at 9:43 AM David Handermann
> > > >
> > > > > <ex...@apache.org> wrote:
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > Mark,
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > The dependency duplication detection is a new optional goal of the
> NAR
> > > >
> > > > >
> > > >
> > > > > plugin. The basic purpose is to detect unnecessary dependencies in
> the
> > > >
> > > > >
> > > >
> > > > > compile scope, which are already provided from a parent NAR
> dependency.
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > For example, the nifi-standard-service-api-nar includes the
> > > >
> > > > >
> > > >
> > > > > nifi-ssl-context-service-api library. The
> > > > nifi-web-client-provider-service
> > > >
> > > > >
> > > >
> > > > > depends on nifi-ssl-context-service-api, and identifies it
> correctly
> > > with
> > > >
> > > > >
> > > >
> > > > > the provided scope in the Maven configuration. The
> > > >
> > > > >
> > > >
> > > > > nifi-web-client-provider-service-nar bundles
> > > >
> > > > >
> > > >
> > > > > nifi-web-client-provider-service, and depends on
> > > >
> > > > >
> > > >
> > > > > nifi-standard-service-api-nar. If the nifi-ssl-context-service-api
> was
> > > > not
> > > >
> > > > >
> > > >
> > > > > marked as provided, the new duplication detection goal would flag
> the
> > > >
> > > > >
> > > >
> > > > > unnecessary inclusion of the nifi-ssl-context-service-api.
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > The duplication detection will help avoid including unnecessary
> > > >
> > > > >
> > > >
> > > > > dependencies, and also avoid unexpected runtime behavior. The NiFi
> NAR
> > > >
> > > > >
> > > >
> > > > > class loading hierarchy uses libraries from the parent NAR at
> runtime,
> > > so
> > > >
> > > > >
> > > >
> > > > > avoiding unnecessary dependency inclusion is important for these
> > > reasons.
> > > >
> > > > >
> > > >
> > > > > The goal is optional, and will require additional changes to
> enable by
> > > >
> > > > >
> > > >
> > > > > default in NiFi builds, but it should be very helpful for future
> > > > releases.
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > Regards,
> > > >
> > > > >
> > > >
> > > > > David Handermann
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > On Wed, Nov 30, 2022 at 7:36 AM Mark Bean <ma...@gmail.com>
> > > wrote:
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > > > > Sounds great Kevin. Thanks!
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > > > Can you give a little more detail on the dependency duplication
> > > >
> > > > > detection?
> > > >
> > > > >
> > > >
> > > > > > How does it work? Does it detect different versions of the same
> > > >
> > > > > dependency?
> > > >
> > > > >
> > > >
> > > > > > Is it detecting duplicates only within a given NAR or across
> multiple
> > > >
> > > > > NARs?
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > > > Thanks,
> > > >
> > > > >
> > > >
> > > > > > Mark
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > > > On Tue, Nov 29, 2022 at 4:18 PM Kevin Doran <kd...@apache.org>
> > > wrote:
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > > > > Hi all,
> > > >
> > > > >
> > > >
> > > > > > >
> > > >
> > > > >
> > > >
> > > > > > > There’s been a few improvements and bug fixes to the NAR Maven
> > > > Plugin.
> > > >
> > > > >
> > > >
> > > > > > One
> > > >
> > > > >
> > > >
> > > > > > > nice new feature is a new maven goal that detects duplicate
> > > >
> > > > > dependencies
> > > >
> > > > >
> > > >
> > > > > > in
> > > >
> > > > >
> > > >
> > > > > > > NARs. Another contribution improves our NiFi build
> reproducibility.
> > > >
> > > > >
> > > >
> > > > > > >
> > > >
> > > > >
> > > >
> > > > > > > Given all this, I’d like to release a new version of the plugin
> > > that
> > > >
> > > > > we
> > > >
> > > > >
> > > >
> > > > > > can
> > > >
> > > > >
> > > >
> > > > > > > start using in NiFi. As this includes a feature, this will be a
> > > minor
> > > >
> > > > >
> > > >
> > > > > > > version bump (1.4.0).
> > > >
> > > > >
> > > >
> > > > > > >
> > > >
> > > > >
> > > >
> > > > > > > I’m happy to RM. There are two outstanding PRs, and if there
> are no
> > > >
> > > > >
> > > >
> > > > > > > objections on this thread, I’ll wait for those to be merged and
> > > then
> > > >
> > > > >
> > > >
> > > > > > > prepare a release candidate.
> > > >
> > > > >
> > > >
> > > > > > >
> > > >
> > > > >
> > > >
> > > > > > > Thanks,
> > > >
> > > > >
> > > >
> > > > > > > Kevin
> > > >
> > > > >
> > > >
> > > > > > >
> > > >
> > > > >
> > > >
> > > > > >
> > > >
> > > > >
> > > >
> > > > >
> > > >
> > > >
> > >
>
Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
Posted by Bryan Bende <bb...@gmail.com>.
Thanks Kevin.
Just to clarify, the Maven issues mentioned here don't sound specific
to the NAR plugin, but sound like general Maven issues? or am I
mis-interpreting?
On Wed, Jan 25, 2023 at 6:56 PM Joe Witt <jo...@gmail.com> wrote:
>
> Thanks Kevin. Sounds good.
>
> If you can start that soon I can draft 1.20 off that..
>
> thanks
>
> On Wed, Jan 25, 2023 at 4:46 PM Kevin Doran <kd...@apache.org> wrote:
>
> > Hi Harry,
> >
> > Thanks for the heads up. If you can share those findings, there's a few of
> > us on this list that could help look into them and see if NiFi can do
> > anything to work around potential Maven issues.
> >
> > Cheers,
> > Kevin
> >
> > On Jan 25, 2023 at 18:42:07, Harry Clarke <ha...@outlook.com>
> > wrote:
> >
> > > I'm not sure how to view what's been worked on since the last release,
> > but
> > > my team did notice an issue with 3.8.1 of Maven that isn't present in
> > 3.6.1.
> > >
> > > It's hard to nail down exactly what's going on, but it looked to be that
> > > plugin repository proxy settings weren't being honoured by Maven within
> > the
> > > settings.xml files, and pom.xml repo declarations were taking precedence.
> > > Of course, this fails immediately if you're behind a firewall.
> > >
> > > I'll try to dig up where we got to with our investigation, but this was a
> > > blocker for us moving to Java 17.
> > > ________________________________
> > > From: Kevin Doran <kd...@apache.org>
> > > Sent: 25 January 2023 23:34
> > > To: dev@nifi.apache.org <de...@nifi.apache.org>
> > > Subject: Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
> > >
> > > Hi all,
> > >
> > > The issues raised on this thread have all been addressed, so I’d like to
> > > revive this goal to release NiFi NAR Maven Plugin 1.4.0 soon.
> > >
> > > Unless anyone is aware of additional items to include, I plan to start
> > > preparing a release candidate this week.
> > >
> > > Thanks,
> > > Kevin
> > >
> > > On Nov 30, 2022 at 14:28:00, Kevin Doran <kd...@apache.org> wrote:
> > >
> > > Thanks, Bryan! There is no urgency around this release, so I'm happy to
> > >
> > > wait for that.
> > >
> > >
> > > On Nov 30, 2022 at 14:24:02, Bryan Bende <bb...@gmail.com> wrote:
> > >
> > >
> > > > Thanks Kevin!
> > >
> > > >
> > >
> > > > There is actually one change I was planning to start working on, and
> > >
> > > > since we don't release the NAR plugin very frequently, I would like to
> > >
> > > > try and get it in before this release.
> > >
> > > >
> > >
> > > > I created this JIRA [1] for the issue, and I can report back here once
> > >
> > > > I start working on it to see if it looks like it will still be
> > >
> > > > something to wait on.
> > >
> > > >
> > >
> > > > [1] https://issues.apache.org/jira/browse/NIFI-10915
> > >
> > > >
> > >
> > > >
> > >
> > > > On Wed, Nov 30, 2022 at 9:43 AM David Handermann
> > >
> > > > <ex...@apache.org> wrote:
> > >
> > > >
> > >
> > > >
> > >
> > > > Mark,
> > >
> > > >
> > >
> > > >
> > >
> > > > The dependency duplication detection is a new optional goal of the NAR
> > >
> > > >
> > >
> > > > plugin. The basic purpose is to detect unnecessary dependencies in the
> > >
> > > >
> > >
> > > > compile scope, which are already provided from a parent NAR dependency.
> > >
> > > >
> > >
> > > >
> > >
> > > > For example, the nifi-standard-service-api-nar includes the
> > >
> > > >
> > >
> > > > nifi-ssl-context-service-api library. The
> > > nifi-web-client-provider-service
> > >
> > > >
> > >
> > > > depends on nifi-ssl-context-service-api, and identifies it correctly
> > with
> > >
> > > >
> > >
> > > > the provided scope in the Maven configuration. The
> > >
> > > >
> > >
> > > > nifi-web-client-provider-service-nar bundles
> > >
> > > >
> > >
> > > > nifi-web-client-provider-service, and depends on
> > >
> > > >
> > >
> > > > nifi-standard-service-api-nar. If the nifi-ssl-context-service-api was
> > > not
> > >
> > > >
> > >
> > > > marked as provided, the new duplication detection goal would flag the
> > >
> > > >
> > >
> > > > unnecessary inclusion of the nifi-ssl-context-service-api.
> > >
> > > >
> > >
> > > >
> > >
> > > > The duplication detection will help avoid including unnecessary
> > >
> > > >
> > >
> > > > dependencies, and also avoid unexpected runtime behavior. The NiFi NAR
> > >
> > > >
> > >
> > > > class loading hierarchy uses libraries from the parent NAR at runtime,
> > so
> > >
> > > >
> > >
> > > > avoiding unnecessary dependency inclusion is important for these
> > reasons.
> > >
> > > >
> > >
> > > > The goal is optional, and will require additional changes to enable by
> > >
> > > >
> > >
> > > > default in NiFi builds, but it should be very helpful for future
> > > releases.
> > >
> > > >
> > >
> > > >
> > >
> > > > Regards,
> > >
> > > >
> > >
> > > > David Handermann
> > >
> > > >
> > >
> > > >
> > >
> > > > On Wed, Nov 30, 2022 at 7:36 AM Mark Bean <ma...@gmail.com>
> > wrote:
> > >
> > > >
> > >
> > > >
> > >
> > > > > Sounds great Kevin. Thanks!
> > >
> > > >
> > >
> > > > >
> > >
> > > >
> > >
> > > > > Can you give a little more detail on the dependency duplication
> > >
> > > > detection?
> > >
> > > >
> > >
> > > > > How does it work? Does it detect different versions of the same
> > >
> > > > dependency?
> > >
> > > >
> > >
> > > > > Is it detecting duplicates only within a given NAR or across multiple
> > >
> > > > NARs?
> > >
> > > >
> > >
> > > > >
> > >
> > > >
> > >
> > > > > Thanks,
> > >
> > > >
> > >
> > > > > Mark
> > >
> > > >
> > >
> > > > >
> > >
> > > >
> > >
> > > > >
> > >
> > > >
> > >
> > > > > On Tue, Nov 29, 2022 at 4:18 PM Kevin Doran <kd...@apache.org>
> > wrote:
> > >
> > > >
> > >
> > > > >
> > >
> > > >
> > >
> > > > > > Hi all,
> > >
> > > >
> > >
> > > > > >
> > >
> > > >
> > >
> > > > > > There’s been a few improvements and bug fixes to the NAR Maven
> > > Plugin.
> > >
> > > >
> > >
> > > > > One
> > >
> > > >
> > >
> > > > > > nice new feature is a new maven goal that detects duplicate
> > >
> > > > dependencies
> > >
> > > >
> > >
> > > > > in
> > >
> > > >
> > >
> > > > > > NARs. Another contribution improves our NiFi build reproducibility.
> > >
> > > >
> > >
> > > > > >
> > >
> > > >
> > >
> > > > > > Given all this, I’d like to release a new version of the plugin
> > that
> > >
> > > > we
> > >
> > > >
> > >
> > > > > can
> > >
> > > >
> > >
> > > > > > start using in NiFi. As this includes a feature, this will be a
> > minor
> > >
> > > >
> > >
> > > > > > version bump (1.4.0).
> > >
> > > >
> > >
> > > > > >
> > >
> > > >
> > >
> > > > > > I’m happy to RM. There are two outstanding PRs, and if there are no
> > >
> > > >
> > >
> > > > > > objections on this thread, I’ll wait for those to be merged and
> > then
> > >
> > > >
> > >
> > > > > > prepare a release candidate.
> > >
> > > >
> > >
> > > > > >
> > >
> > > >
> > >
> > > > > > Thanks,
> > >
> > > >
> > >
> > > > > > Kevin
> > >
> > > >
> > >
> > > > > >
> > >
> > > >
> > >
> > > > >
> > >
> > > >
> > >
> > > >
> > >
> > >
> >
Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
Posted by Joe Witt <jo...@gmail.com>.
Thanks Kevin. Sounds good.
If you can start that soon I can draft 1.20 off that..
thanks
On Wed, Jan 25, 2023 at 4:46 PM Kevin Doran <kd...@apache.org> wrote:
> Hi Harry,
>
> Thanks for the heads up. If you can share those findings, there's a few of
> us on this list that could help look into them and see if NiFi can do
> anything to work around potential Maven issues.
>
> Cheers,
> Kevin
>
> On Jan 25, 2023 at 18:42:07, Harry Clarke <ha...@outlook.com>
> wrote:
>
> > I'm not sure how to view what's been worked on since the last release,
> but
> > my team did notice an issue with 3.8.1 of Maven that isn't present in
> 3.6.1.
> >
> > It's hard to nail down exactly what's going on, but it looked to be that
> > plugin repository proxy settings weren't being honoured by Maven within
> the
> > settings.xml files, and pom.xml repo declarations were taking precedence.
> > Of course, this fails immediately if you're behind a firewall.
> >
> > I'll try to dig up where we got to with our investigation, but this was a
> > blocker for us moving to Java 17.
> > ________________________________
> > From: Kevin Doran <kd...@apache.org>
> > Sent: 25 January 2023 23:34
> > To: dev@nifi.apache.org <de...@nifi.apache.org>
> > Subject: Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
> >
> > Hi all,
> >
> > The issues raised on this thread have all been addressed, so I’d like to
> > revive this goal to release NiFi NAR Maven Plugin 1.4.0 soon.
> >
> > Unless anyone is aware of additional items to include, I plan to start
> > preparing a release candidate this week.
> >
> > Thanks,
> > Kevin
> >
> > On Nov 30, 2022 at 14:28:00, Kevin Doran <kd...@apache.org> wrote:
> >
> > Thanks, Bryan! There is no urgency around this release, so I'm happy to
> >
> > wait for that.
> >
> >
> > On Nov 30, 2022 at 14:24:02, Bryan Bende <bb...@gmail.com> wrote:
> >
> >
> > > Thanks Kevin!
> >
> > >
> >
> > > There is actually one change I was planning to start working on, and
> >
> > > since we don't release the NAR plugin very frequently, I would like to
> >
> > > try and get it in before this release.
> >
> > >
> >
> > > I created this JIRA [1] for the issue, and I can report back here once
> >
> > > I start working on it to see if it looks like it will still be
> >
> > > something to wait on.
> >
> > >
> >
> > > [1] https://issues.apache.org/jira/browse/NIFI-10915
> >
> > >
> >
> > >
> >
> > > On Wed, Nov 30, 2022 at 9:43 AM David Handermann
> >
> > > <ex...@apache.org> wrote:
> >
> > >
> >
> > >
> >
> > > Mark,
> >
> > >
> >
> > >
> >
> > > The dependency duplication detection is a new optional goal of the NAR
> >
> > >
> >
> > > plugin. The basic purpose is to detect unnecessary dependencies in the
> >
> > >
> >
> > > compile scope, which are already provided from a parent NAR dependency.
> >
> > >
> >
> > >
> >
> > > For example, the nifi-standard-service-api-nar includes the
> >
> > >
> >
> > > nifi-ssl-context-service-api library. The
> > nifi-web-client-provider-service
> >
> > >
> >
> > > depends on nifi-ssl-context-service-api, and identifies it correctly
> with
> >
> > >
> >
> > > the provided scope in the Maven configuration. The
> >
> > >
> >
> > > nifi-web-client-provider-service-nar bundles
> >
> > >
> >
> > > nifi-web-client-provider-service, and depends on
> >
> > >
> >
> > > nifi-standard-service-api-nar. If the nifi-ssl-context-service-api was
> > not
> >
> > >
> >
> > > marked as provided, the new duplication detection goal would flag the
> >
> > >
> >
> > > unnecessary inclusion of the nifi-ssl-context-service-api.
> >
> > >
> >
> > >
> >
> > > The duplication detection will help avoid including unnecessary
> >
> > >
> >
> > > dependencies, and also avoid unexpected runtime behavior. The NiFi NAR
> >
> > >
> >
> > > class loading hierarchy uses libraries from the parent NAR at runtime,
> so
> >
> > >
> >
> > > avoiding unnecessary dependency inclusion is important for these
> reasons.
> >
> > >
> >
> > > The goal is optional, and will require additional changes to enable by
> >
> > >
> >
> > > default in NiFi builds, but it should be very helpful for future
> > releases.
> >
> > >
> >
> > >
> >
> > > Regards,
> >
> > >
> >
> > > David Handermann
> >
> > >
> >
> > >
> >
> > > On Wed, Nov 30, 2022 at 7:36 AM Mark Bean <ma...@gmail.com>
> wrote:
> >
> > >
> >
> > >
> >
> > > > Sounds great Kevin. Thanks!
> >
> > >
> >
> > > >
> >
> > >
> >
> > > > Can you give a little more detail on the dependency duplication
> >
> > > detection?
> >
> > >
> >
> > > > How does it work? Does it detect different versions of the same
> >
> > > dependency?
> >
> > >
> >
> > > > Is it detecting duplicates only within a given NAR or across multiple
> >
> > > NARs?
> >
> > >
> >
> > > >
> >
> > >
> >
> > > > Thanks,
> >
> > >
> >
> > > > Mark
> >
> > >
> >
> > > >
> >
> > >
> >
> > > >
> >
> > >
> >
> > > > On Tue, Nov 29, 2022 at 4:18 PM Kevin Doran <kd...@apache.org>
> wrote:
> >
> > >
> >
> > > >
> >
> > >
> >
> > > > > Hi all,
> >
> > >
> >
> > > > >
> >
> > >
> >
> > > > > There’s been a few improvements and bug fixes to the NAR Maven
> > Plugin.
> >
> > >
> >
> > > > One
> >
> > >
> >
> > > > > nice new feature is a new maven goal that detects duplicate
> >
> > > dependencies
> >
> > >
> >
> > > > in
> >
> > >
> >
> > > > > NARs. Another contribution improves our NiFi build reproducibility.
> >
> > >
> >
> > > > >
> >
> > >
> >
> > > > > Given all this, I’d like to release a new version of the plugin
> that
> >
> > > we
> >
> > >
> >
> > > > can
> >
> > >
> >
> > > > > start using in NiFi. As this includes a feature, this will be a
> minor
> >
> > >
> >
> > > > > version bump (1.4.0).
> >
> > >
> >
> > > > >
> >
> > >
> >
> > > > > I’m happy to RM. There are two outstanding PRs, and if there are no
> >
> > >
> >
> > > > > objections on this thread, I’ll wait for those to be merged and
> then
> >
> > >
> >
> > > > > prepare a release candidate.
> >
> > >
> >
> > > > >
> >
> > >
> >
> > > > > Thanks,
> >
> > >
> >
> > > > > Kevin
> >
> > >
> >
> > > > >
> >
> > >
> >
> > > >
> >
> > >
> >
> > >
> >
> >
>
Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
Posted by Kevin Doran <kd...@apache.org>.
Hi Harry,
Thanks for the heads up. If you can share those findings, there's a few of
us on this list that could help look into them and see if NiFi can do
anything to work around potential Maven issues.
Cheers,
Kevin
On Jan 25, 2023 at 18:42:07, Harry Clarke <ha...@outlook.com> wrote:
> I'm not sure how to view what's been worked on since the last release, but
> my team did notice an issue with 3.8.1 of Maven that isn't present in 3.6.1.
>
> It's hard to nail down exactly what's going on, but it looked to be that
> plugin repository proxy settings weren't being honoured by Maven within the
> settings.xml files, and pom.xml repo declarations were taking precedence.
> Of course, this fails immediately if you're behind a firewall.
>
> I'll try to dig up where we got to with our investigation, but this was a
> blocker for us moving to Java 17.
> ________________________________
> From: Kevin Doran <kd...@apache.org>
> Sent: 25 January 2023 23:34
> To: dev@nifi.apache.org <de...@nifi.apache.org>
> Subject: Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
>
> Hi all,
>
> The issues raised on this thread have all been addressed, so I’d like to
> revive this goal to release NiFi NAR Maven Plugin 1.4.0 soon.
>
> Unless anyone is aware of additional items to include, I plan to start
> preparing a release candidate this week.
>
> Thanks,
> Kevin
>
> On Nov 30, 2022 at 14:28:00, Kevin Doran <kd...@apache.org> wrote:
>
> Thanks, Bryan! There is no urgency around this release, so I'm happy to
>
> wait for that.
>
>
> On Nov 30, 2022 at 14:24:02, Bryan Bende <bb...@gmail.com> wrote:
>
>
> > Thanks Kevin!
>
> >
>
> > There is actually one change I was planning to start working on, and
>
> > since we don't release the NAR plugin very frequently, I would like to
>
> > try and get it in before this release.
>
> >
>
> > I created this JIRA [1] for the issue, and I can report back here once
>
> > I start working on it to see if it looks like it will still be
>
> > something to wait on.
>
> >
>
> > [1] https://issues.apache.org/jira/browse/NIFI-10915
>
> >
>
> >
>
> > On Wed, Nov 30, 2022 at 9:43 AM David Handermann
>
> > <ex...@apache.org> wrote:
>
> >
>
> >
>
> > Mark,
>
> >
>
> >
>
> > The dependency duplication detection is a new optional goal of the NAR
>
> >
>
> > plugin. The basic purpose is to detect unnecessary dependencies in the
>
> >
>
> > compile scope, which are already provided from a parent NAR dependency.
>
> >
>
> >
>
> > For example, the nifi-standard-service-api-nar includes the
>
> >
>
> > nifi-ssl-context-service-api library. The
> nifi-web-client-provider-service
>
> >
>
> > depends on nifi-ssl-context-service-api, and identifies it correctly with
>
> >
>
> > the provided scope in the Maven configuration. The
>
> >
>
> > nifi-web-client-provider-service-nar bundles
>
> >
>
> > nifi-web-client-provider-service, and depends on
>
> >
>
> > nifi-standard-service-api-nar. If the nifi-ssl-context-service-api was
> not
>
> >
>
> > marked as provided, the new duplication detection goal would flag the
>
> >
>
> > unnecessary inclusion of the nifi-ssl-context-service-api.
>
> >
>
> >
>
> > The duplication detection will help avoid including unnecessary
>
> >
>
> > dependencies, and also avoid unexpected runtime behavior. The NiFi NAR
>
> >
>
> > class loading hierarchy uses libraries from the parent NAR at runtime, so
>
> >
>
> > avoiding unnecessary dependency inclusion is important for these reasons.
>
> >
>
> > The goal is optional, and will require additional changes to enable by
>
> >
>
> > default in NiFi builds, but it should be very helpful for future
> releases.
>
> >
>
> >
>
> > Regards,
>
> >
>
> > David Handermann
>
> >
>
> >
>
> > On Wed, Nov 30, 2022 at 7:36 AM Mark Bean <ma...@gmail.com> wrote:
>
> >
>
> >
>
> > > Sounds great Kevin. Thanks!
>
> >
>
> > >
>
> >
>
> > > Can you give a little more detail on the dependency duplication
>
> > detection?
>
> >
>
> > > How does it work? Does it detect different versions of the same
>
> > dependency?
>
> >
>
> > > Is it detecting duplicates only within a given NAR or across multiple
>
> > NARs?
>
> >
>
> > >
>
> >
>
> > > Thanks,
>
> >
>
> > > Mark
>
> >
>
> > >
>
> >
>
> > >
>
> >
>
> > > On Tue, Nov 29, 2022 at 4:18 PM Kevin Doran <kd...@apache.org> wrote:
>
> >
>
> > >
>
> >
>
> > > > Hi all,
>
> >
>
> > > >
>
> >
>
> > > > There’s been a few improvements and bug fixes to the NAR Maven
> Plugin.
>
> >
>
> > > One
>
> >
>
> > > > nice new feature is a new maven goal that detects duplicate
>
> > dependencies
>
> >
>
> > > in
>
> >
>
> > > > NARs. Another contribution improves our NiFi build reproducibility.
>
> >
>
> > > >
>
> >
>
> > > > Given all this, I’d like to release a new version of the plugin that
>
> > we
>
> >
>
> > > can
>
> >
>
> > > > start using in NiFi. As this includes a feature, this will be a minor
>
> >
>
> > > > version bump (1.4.0).
>
> >
>
> > > >
>
> >
>
> > > > I’m happy to RM. There are two outstanding PRs, and if there are no
>
> >
>
> > > > objections on this thread, I’ll wait for those to be merged and then
>
> >
>
> > > > prepare a release candidate.
>
> >
>
> > > >
>
> >
>
> > > > Thanks,
>
> >
>
> > > > Kevin
>
> >
>
> > > >
>
> >
>
> > >
>
> >
>
> >
>
>
Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
Posted by Harry Clarke <ha...@outlook.com>.
I'm not sure how to view what's been worked on since the last release, but my team did notice an issue with 3.8.1 of Maven that isn't present in 3.6.1.
It's hard to nail down exactly what's going on, but it looked to be that plugin repository proxy settings weren't being honoured by Maven within the settings.xml files, and pom.xml repo declarations were taking precedence.
Of course, this fails immediately if you're behind a firewall.
I'll try to dig up where we got to with our investigation, but this was a blocker for us moving to Java 17.
________________________________
From: Kevin Doran <kd...@apache.org>
Sent: 25 January 2023 23:34
To: dev@nifi.apache.org <de...@nifi.apache.org>
Subject: Re: [DISCUSS] Release NiFi NAR Maven Plugin 1.4.0
Hi all,
The issues raised on this thread have all been addressed, so I’d like to
revive this goal to release NiFi NAR Maven Plugin 1.4.0 soon.
Unless anyone is aware of additional items to include, I plan to start
preparing a release candidate this week.
Thanks,
Kevin
On Nov 30, 2022 at 14:28:00, Kevin Doran <kd...@apache.org> wrote:
> Thanks, Bryan! There is no urgency around this release, so I'm happy to
> wait for that.
>
> On Nov 30, 2022 at 14:24:02, Bryan Bende <bb...@gmail.com> wrote:
>
>> Thanks Kevin!
>>
>> There is actually one change I was planning to start working on, and
>> since we don't release the NAR plugin very frequently, I would like to
>> try and get it in before this release.
>>
>> I created this JIRA [1] for the issue, and I can report back here once
>> I start working on it to see if it looks like it will still be
>> something to wait on.
>>
>> [1] https://issues.apache.org/jira/browse/NIFI-10915
>>
>>
>> On Wed, Nov 30, 2022 at 9:43 AM David Handermann
>> <ex...@apache.org> wrote:
>>
>>
>> Mark,
>>
>>
>> The dependency duplication detection is a new optional goal of the NAR
>>
>> plugin. The basic purpose is to detect unnecessary dependencies in the
>>
>> compile scope, which are already provided from a parent NAR dependency.
>>
>>
>> For example, the nifi-standard-service-api-nar includes the
>>
>> nifi-ssl-context-service-api library. The nifi-web-client-provider-service
>>
>> depends on nifi-ssl-context-service-api, and identifies it correctly with
>>
>> the provided scope in the Maven configuration. The
>>
>> nifi-web-client-provider-service-nar bundles
>>
>> nifi-web-client-provider-service, and depends on
>>
>> nifi-standard-service-api-nar. If the nifi-ssl-context-service-api was not
>>
>> marked as provided, the new duplication detection goal would flag the
>>
>> unnecessary inclusion of the nifi-ssl-context-service-api.
>>
>>
>> The duplication detection will help avoid including unnecessary
>>
>> dependencies, and also avoid unexpected runtime behavior. The NiFi NAR
>>
>> class loading hierarchy uses libraries from the parent NAR at runtime, so
>>
>> avoiding unnecessary dependency inclusion is important for these reasons.
>>
>> The goal is optional, and will require additional changes to enable by
>>
>> default in NiFi builds, but it should be very helpful for future releases.
>>
>>
>> Regards,
>>
>> David Handermann
>>
>>
>> On Wed, Nov 30, 2022 at 7:36 AM Mark Bean <ma...@gmail.com> wrote:
>>
>>
>> > Sounds great Kevin. Thanks!
>>
>> >
>>
>> > Can you give a little more detail on the dependency duplication
>> detection?
>>
>> > How does it work? Does it detect different versions of the same
>> dependency?
>>
>> > Is it detecting duplicates only within a given NAR or across multiple
>> NARs?
>>
>> >
>>
>> > Thanks,
>>
>> > Mark
>>
>> >
>>
>> >
>>
>> > On Tue, Nov 29, 2022 at 4:18 PM Kevin Doran <kd...@apache.org> wrote:
>>
>> >
>>
>> > > Hi all,
>>
>> > >
>>
>> > > There’s been a few improvements and bug fixes to the NAR Maven Plugin.
>>
>> > One
>>
>> > > nice new feature is a new maven goal that detects duplicate
>> dependencies
>>
>> > in
>>
>> > > NARs. Another contribution improves our NiFi build reproducibility.
>>
>> > >
>>
>> > > Given all this, I’d like to release a new version of the plugin that
>> we
>>
>> > can
>>
>> > > start using in NiFi. As this includes a feature, this will be a minor
>>
>> > > version bump (1.4.0).
>>
>> > >
>>
>> > > I’m happy to RM. There are two outstanding PRs, and if there are no
>>
>> > > objections on this thread, I’ll wait for those to be merged and then
>>
>> > > prepare a release candidate.
>>
>> > >
>>
>> > > Thanks,
>>
>> > > Kevin
>>
>> > >
>>
>> >
>>
>>