You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TimBarham <gi...@git.apache.org> on 2015/09/03 03:36:34 UTC
[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/295
CB-9604 Fix error adding browser platform with PlatformApi polyfill.
Don't try to create `ConfigParser()` in `PlatformApiPoly` constructor, since we may not have copied the `config.xml` file into place yet. Instead, create it once we know we have the `config.xml` file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9604
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/295.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #295
----
commit 3951a990c8aff149cb45b6fa6af6ace0400ab01c
Author: Tim Barham <ti...@microsoft.com>
Date: 2015-09-03T01:34:19Z
CB-9604 Fix error adding browser platform with PlatformApi polyfill.
Don't try to create ConfigParser() in PlatformApiPoly constructor, since we may not have copied the config.xml file into place yet. Instead, create it once we know we have the config.xml file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/295#issuecomment-137353546
Looks good. However there is another chance to access `this._config` before it will be initialized: https://github.com/MSOpenTech/cordova-lib/blob/CB-9604/cordova-lib/src/platforms/PlatformApiPoly.js#L162.
Probably it makes sense to eliminate "private" `this._config` and always use `platformInfo.projectConfig` instead, which need to be a dynamic property with getter? Your thoughts? I can refactor this by myself after.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/295#issuecomment-137297111
@vladimir-kotikov - does this fix look right to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org