You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "HTHou (via GitHub)" <gi...@apache.org> on 2024/07/08 13:11:19 UTC
[PR] Fix negative compression ratios after restarted [iotdb]
HTHou opened a new pull request, #12879:
URL: https://github.com/apache/iotdb/pull/12879
## Description
There is a bug that may cause negative compression ratios after restarted.
To reproduce, you can try the following operations.
1. insert the following sql `insert into root.sg.d1(time,s1) values(1,1)` twice.
2. kill -9 datanode
3. restart datanode
4. execute `insert into root.sg.d1(time,s2) values(1,false)` and `flush`
5. check the file name in `data/datanode/system/compression_ratio`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix negative compression ratios after restarted [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #12879:
URL: https://github.com/apache/iotdb/pull/12879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix negative compression ratios after restarted [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #12879:
URL: https://github.com/apache/iotdb/pull/12879#issuecomment-2214162925
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12879?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `75.00000%` with `3 lines` in your changes missing coverage. Please review.
> Project coverage is 41.72%. Comparing base [(`7e70bfe`)](https://app.codecov.io/gh/apache/iotdb/commit/7e70bfef7818d4f474696d437e60018ef2f89a4e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b5492ba`)](https://app.codecov.io/gh/apache/iotdb/commit/b5492ba229309cdc066ad126b03fc4576d27662b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/iotdb/pull/12879?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...l/recover/file/UnsealedTsFileRecoverPerformer.java](https://app.codecov.io/gh/apache/iotdb/pull/12879?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fstorageengine%2Fdataregion%2Fwal%2Frecover%2Ffile%2FUnsealedTsFileRecoverPerformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL3dhbC9yZWNvdmVyL2ZpbGUvVW5zZWFsZWRUc0ZpbGVSZWNvdmVyUGVyZm9ybWVyLmphdmE=) | 75.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #12879 +/- ##
=========================================
Coverage 41.72% 41.72%
Complexity 71 71
=========================================
Files 3319 3319
Lines 209963 209975 +12
Branches 24961 24962 +1
=========================================
+ Hits 87604 87616 +12
Misses 122359 122359
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/12879?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix negative compression ratios after restarted [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12879:
URL: https://github.com/apache/iotdb/pull/12879#issuecomment-2214055384
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12879) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=12879&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=12879&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=12879&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12879&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12879&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12879)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org