You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/06/10 18:09:45 UTC

[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #924: [LOG4J2-3534] Fix LevelRangeFilterBuilder to align with log4j1's behavior

ppkarwasz commented on code in PR #924:
URL: https://github.com/apache/logging-log4j2/pull/924#discussion_r894784572


##########
log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationTest.java:
##########
@@ -326,4 +326,9 @@ public void testEnhancedRollingFileAppender() throws Exception {
         }
     }
 
+    @Override

Review Comment:
   `Log4j1ConfigurationFactory` is an old factory that does not use builders. No need to add it there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org