You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/14 16:24:11 UTC

[GitHub] [spark] xinrong-databricks commented on a change in pull request #32867: [SPARK-35721][PYTHON] Path level discover for python unittests

xinrong-databricks commented on a change in pull request #32867:
URL: https://github.com/apache/spark/pull/32867#discussion_r651096165



##########
File path: dev/sparktestsupport/modules.py
##########
@@ -19,10 +19,28 @@
 import itertools
 import os
 import re
+import glob
+
+from sparktestsupport import SPARK_HOME
 
 all_modules = []
 
 
+def _discover_python_unittests(paths):
+    if not paths:
+        return set([])
+    tests = set([])
+    pyspark_path = os.path.join(SPARK_HOME, "python")
+    for path in paths:
+        # Discover the test*.py in every path
+        files = glob.glob(os.path.join(pyspark_path, path, "test*.py"))

Review comment:
       Do we intentionally include `pyspark/pandas/tests.data_type_ops.testing_utils`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org