You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2018/07/18 02:00:00 UTC
[jira] [Commented] (LUCENE-8408) Code cleanup -
TokenStreamFromTermVector - ATTRIBUTE_FACTORY
[ https://issues.apache.org/jira/browse/LUCENE-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547288#comment-16547288 ]
David Smiley commented on LUCENE-8408:
--------------------------------------
Correct; I wrote that. While it used to be of use back in Solr 4, I think it's now obsolete.
> Code cleanup - TokenStreamFromTermVector - ATTRIBUTE_FACTORY
> ------------------------------------------------------------
>
> Key: LUCENE-8408
> URL: https://issues.apache.org/jira/browse/LUCENE-8408
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael Braun
> Priority: Trivial
>
> At the top of TokenStreamFromTermVector:
> {code}
> //This attribute factory uses less memory when captureState() is called.
> public static final AttributeFactory ATTRIBUTE_FACTORY =
> AttributeFactory.getStaticImplementation(
> AttributeFactory.DEFAULT_ATTRIBUTE_FACTORY, PackedTokenAttributeImpl.class);
> {code}
> This is the default if super() was called with no-args from the constructor, so I believe this can go away. CC [~dsmiley]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org