[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r427956371



##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -122,3 +122,13 @@ select to_timestamp("2019-10-06T10:11:12'12", "yyyy-MM-dd'T'HH:mm:ss''SSSS"); --
 select to_timestamp("2019-10-06T10:11:12'", "yyyy-MM-dd'T'HH:mm:ss''"); -- tail
 select to_timestamp("'2019-10-06T10:11:12", "''yyyy-MM-dd'T'HH:mm:ss"); -- head
 select to_timestamp("P2019-10-06T10:11:12", "'P'yyyy-MM-dd'T'HH:mm:ss"); -- head but as single quote
+
+-- Unsupported narrow text style
+select date_format(date '2020-05-23', 'GGGGG');

Review comment:
       This question may beyond the scope of this PR. So far, using an invalid pattern for parsing always returns `NULL`, which is also compatible with 2.4.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org