You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Paul Spencer <pa...@apache.org> on 2006/12/05 19:17:22 UTC
Re: svn commit: r482726 - in /myfaces/core/trunk/api/src/main/java/javax/faces:
component/ webapp/
Grant,
I noticed some of the castings you removed where from generated code.
Is the code generate still in use? If so, does it need to be fixed?
Paul Spencer
grantsmith@apache.org wrote:
> Author: grantsmith
> Date: Tue Dec 5 10:02:43 2006
> New Revision: 482726
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=482726
> Log:
> removed redundant casting & some code cleanup
>
> Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java
> myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java Tue Dec 5 10:02:43 2006
> @@ -170,7 +170,7 @@
> {
> if (_value != null) return _value;
> ValueBinding vb = getValueBinding("value");
> - return vb != null ? (Object)vb.getValue(getFacesContext()) : null;
> + return vb != null ? vb.getValue(getFacesContext()) : null;
> }
>
>
> @@ -183,7 +183,7 @@
> values[2] = saveAttachedState(context, _actionListener);
> values[3] = _immediate;
> values[4] = _value;
> - return ((Object) (values));
> + return values;
> }
>
> public void restoreState(FacesContext context, Object state)
> @@ -193,7 +193,7 @@
> _action = (MethodBinding)restoreAttachedState(context, values[1]);
> _actionListener = (MethodBinding)restoreAttachedState(context, values[2]);
> _immediate = (Boolean)values[3];
> - _value = (Object)values[4];
> + _value = values[4];
> }
> //------------------ GENERATED CODE END ---------------------------------------
> }
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java Tue Dec 5 10:02:43 2006
> @@ -1020,7 +1020,7 @@
> if (_value != null)
> return _value;
> ValueBinding vb = getValueBinding("value");
> - return vb != null ? (Object) vb.getValue(getFacesContext()) : null;
> + return vb != null ? vb.getValue(getFacesContext()) : null;
> }
>
> //------------------ GENERATED CODE END ---------------------------------------
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java Tue Dec 5 10:02:43 2006
> @@ -96,7 +96,7 @@
> {
> if (_value != null) return _value;
> ValueBinding vb = getValueBinding("value");
> - return vb != null ? (Object)vb.getValue(getFacesContext()) : null;
> + return vb != null ? vb.getValue(getFacesContext()) : null;
> }
>
>
> @@ -105,14 +105,14 @@
> Object values[] = new Object[2];
> values[0] = super.saveState(context);
> values[1] = _value;
> - return ((Object) (values));
> + return values;
> }
>
> public void restoreState(FacesContext context, Object state)
> {
> Object values[] = (Object[])state;
> super.restoreState(context, values[0]);
> - _value = (Object)values[1];
> + _value = values[1];
> }
> //------------------ GENERATED CODE END ---------------------------------------
> }
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java Tue Dec 5 10:02:43 2006
> @@ -481,7 +481,7 @@
> values[6] = saveAttachedState(context, _validator);
> values[7] = saveAttachedState(context, _valueChangeListener);
> values[8] = saveAttachedState(context, _validatorList);
> - return ((Object)(values));
> + return values;
> }
>
> public void restoreState(FacesContext context, Object state)
> @@ -491,7 +491,7 @@
> _immediate = (Boolean)values[1];
> _localValueSet = ((Boolean)values[2]).booleanValue();
> _required = (Boolean)values[3];
> - _submittedValue = (Object)values[4];
> + _submittedValue = values[4];
> _valid = ((Boolean)values[5]).booleanValue();
> _validator = (MethodBinding)restoreAttachedState(context, values[6]);
> _valueChangeListener = (MethodBinding)restoreAttachedState(context, values[7]);
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java Tue Dec 5 10:02:43 2006
> @@ -100,7 +100,7 @@
> values[1] = _for;
> values[2] = _showDetail;
> values[3] = _showSummary;
> - return ((Object) (values));
> + return values;
> }
>
> public void restoreState(FacesContext context, Object state)
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java Tue Dec 5 10:02:43 2006
> @@ -100,7 +100,7 @@
> values[1] = _globalOnly;
> values[2] = _showDetail;
> values[3] = _showSummary;
> - return ((Object) (values));
> + return values;
> }
>
> public void restoreState(FacesContext context, Object state)
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java Tue Dec 5 10:02:43 2006
> @@ -77,7 +77,7 @@
> {
> if (_value != null) return _value;
> ValueBinding vb = getValueBinding("value");
> - return vb != null ? (Object)vb.getValue(getFacesContext()) : null;
> + return vb != null ? vb.getValue(getFacesContext()) : null;
> }
>
>
> @@ -87,7 +87,7 @@
> values[0] = super.saveState(context);
> values[1] = saveAttachedState(context, _converter);
> values[2] = _value;
> - return ((Object) (values));
> + return values;
> }
>
> public void restoreState(FacesContext context, Object state)
> @@ -95,7 +95,7 @@
> Object values[] = (Object[])state;
> super.restoreState(context, values[0]);
> _converter = (Converter)restoreAttachedState(context, values[1]);
> - _value = (Object)values[2];
> + _value = values[2];
> }
> //------------------ GENERATED CODE END ---------------------------------------
> }
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java Tue Dec 5 10:02:43 2006
> @@ -68,7 +68,7 @@
> {
> if (_value != null) return _value;
> ValueBinding vb = getValueBinding("value");
> - return vb != null ? (Object)vb.getValue(getFacesContext()) : null;
> + return vb != null ? vb.getValue(getFacesContext()) : null;
> }
>
>
> @@ -78,7 +78,7 @@
> values[0] = super.saveState(context);
> values[1] = _name;
> values[2] = _value;
> - return ((Object) (values));
> + return values;
> }
>
> public void restoreState(FacesContext context, Object state)
> @@ -86,7 +86,7 @@
> Object values[] = (Object[])state;
> super.restoreState(context, values[0]);
> _name = (String)values[1];
> - _value = (Object)values[2];
> + _value = values[2];
> }
> //------------------ GENERATED CODE END ---------------------------------------
>
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java Tue Dec 5 10:02:43 2006
> @@ -42,7 +42,7 @@
> if( value == null )
> value = (Boolean)getValue();
>
> - return value != null ? value.booleanValue() : false;
> + return value != null && value.booleanValue();
> }
>
> public ValueBinding getValueBinding(String name)
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java Tue Dec 5 10:02:43 2006
> @@ -123,7 +123,7 @@
> {
> if (_itemValue != null) return _itemValue;
> ValueBinding vb = getValueBinding("itemValue");
> - return vb != null ? (Object)vb.getValue(getFacesContext()) : null;
> + return vb != null ? vb.getValue(getFacesContext()) : null;
> }
>
> public void setValue(Object value)
> @@ -135,7 +135,7 @@
> {
> if (_value != null) return _value;
> ValueBinding vb = getValueBinding("value");
> - return vb != null ? (Object)vb.getValue(getFacesContext()) : null;
> + return vb != null ? vb.getValue(getFacesContext()) : null;
> }
>
>
> @@ -148,7 +148,7 @@
> values[3] = _itemLabel;
> values[4] = _itemValue;
> values[5] = _value;
> - return ((Object) (values));
> + return values;
> }
>
> public void restoreState(FacesContext context, Object state)
> @@ -158,8 +158,8 @@
> _itemDescription = (String)values[1];
> _itemDisabled = (Boolean)values[2];
> _itemLabel = (String)values[3];
> - _itemValue = (Object)values[4];
> - _value = (Object)values[5];
> + _itemValue = values[4];
> + _value = values[5];
> }
> //------------------ GENERATED CODE END ---------------------------------------
> }
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java Tue Dec 5 10:02:43 2006
> @@ -55,7 +55,7 @@
> {
> if (_value != null) return _value;
> ValueBinding vb = getValueBinding("value");
> - return vb != null ? (Object)vb.getValue(getFacesContext()) : null;
> + return vb != null ? vb.getValue(getFacesContext()) : null;
> }
>
>
> @@ -64,14 +64,14 @@
> Object values[] = new Object[2];
> values[0] = super.saveState(context);
> values[1] = _value;
> - return ((Object) (values));
> + return values;
> }
>
> public void restoreState(FacesContext context, Object state)
> {
> Object values[] = (Object[])state;
> super.restoreState(context, values[0]);
> - _value = (Object)values[1];
> + _value = values[1];
> }
> //------------------ GENERATED CODE END ---------------------------------------
> }
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java Tue Dec 5 10:02:43 2006
> @@ -18,7 +18,6 @@
> */
> package javax.faces.component;
>
> -import javax.faces.component._SelectItemsUtil._ValueConverter;
> import javax.faces.context.FacesContext;
>
> /**
>
> Modified: myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java?view=diff&rev=482726&r1=482725&r2=482726
> ==============================================================================
> --- myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java Tue Dec 5 10:02:43 2006
> @@ -114,12 +114,11 @@
> {
> StringBuffer buffer = new StringBuffer();
>
> - buffer.append(" Someone is trying to access a secure resource : "
> - + pathInfo);
> - buffer.append("\n remote address is " + httpRequest.getRemoteAddr());
> - buffer.append("\n remote host is " + httpRequest.getRemoteHost());
> - buffer.append("\n remote user is " + httpRequest.getRemoteUser());
> - buffer.append("\n request URI is " + httpRequest.getRequestURI());
> + buffer.append(" Someone is trying to access a secure resource : ").append(pathInfo);
> + buffer.append("\n remote address is ").append(httpRequest.getRemoteAddr());
> + buffer.append("\n remote host is ").append(httpRequest.getRemoteHost());
> + buffer.append("\n remote user is ").append(httpRequest.getRemoteUser());
> + buffer.append("\n request URI is ").append(httpRequest.getRequestURI());
>
> log.warn(buffer.toString());
>
>
>
>
Re: svn commit: r482726 - in /myfaces/core/trunk/api/src/main/java/javax/faces: component/ webapp/
Posted by Bruno Aranda <br...@gmail.com>.
And there is a new generator in place for myfaces 1.2 (that at some
point could be adapted to 1.1). It is far more powerful than the
existing one. It is a maven plugin under the trinidad project
sourcecode, called maven-faces-plugin. It can generate:
- The components
- The tags
- A faces-config.xml file with the components
- A facelets taglib
...
from a set of XML file where you define all the component properties
(and java templates if necessary).
You can see that plugin in action in the myfaces 1.2 branch [1], where
all the html components and most of the UI ones are generated that way
now. Work is in progress though...
Trinidad is using the same plugin to generate all the trinidad stuff.
It is really a good thing that we rely in the same mechanism to
generate everything. At some point, this can help to have tomahawk and
the trinidad components closer...
Cheers,
Bruno
[1] https://svn.apache.org/repos/asf/myfaces/current12
On 05/12/06, Grant Smith <wo...@gmail.com> wrote:
> Thats true. There has been some discussion in the past regarding whether or
> not the code generator is still useful. I'll have to check the archives, but
> yes, it should be fixed there too. I believe Manfred is the expert on the
> generator.
>
>
> On 12/5/06, Paul Spencer <pa...@apache.org> wrote:
> > Grant,
> > I noticed some of the castings you removed where from generated code.
> > Is the code generate still in use? If so, does it need to be fixed?
> >
> >
> > Paul Spencer
> >
> >
> > grantsmith@apache.org wrote:
> > > Author: grantsmith
> > > Date: Tue Dec 5 10:02:43 2006
> > > New Revision: 482726
> > >
> > > URL: http://svn.apache.org/viewvc?view=rev&rev=482726
> > > Log:
> > > removed redundant casting & some code cleanup
> > >
> > > Modified:
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java
> > >
> myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java
> Tue Dec 5 10:02:43 2006
> > > @@ -170,7 +170,7 @@
> > > {
> > > if (_value != null) return _value;
> > > ValueBinding vb = getValueBinding("value");
> > > - return vb != null ?
> (Object)vb.getValue(getFacesContext()) : null;
> > > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > > }
> > >
> > >
> > > @@ -183,7 +183,7 @@
> > > values[2] = saveAttachedState(context, _actionListener);
> > > values[3] = _immediate;
> > > values[4] = _value;
> > > - return ((Object) (values));
> > > + return values;
> > > }
> > >
> > > public void restoreState(FacesContext context, Object state)
> > > @@ -193,7 +193,7 @@
> > > _action =
> (MethodBinding)restoreAttachedState(context, values[1]);
> > > _actionListener =
> (MethodBinding)restoreAttachedState(context, values[2]);
> > > _immediate = (Boolean)values[3];
> > > - _value = (Object)values[4];
> > > + _value = values[4];
> > > }
> > > //------------------ GENERATED CODE END
> ---------------------------------------
> > > }
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java
> Tue Dec 5 10:02:43 2006
> > > @@ -1020,7 +1020,7 @@
> > > if (_value != null)
> > > return _value;
> > > ValueBinding vb = getValueBinding("value");
> > > - return vb != null ? (Object) vb.getValue(getFacesContext()) :
> null;
> > > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > > }
> > >
> > > //------------------ GENERATED CODE END
> ---------------------------------------
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java
> Tue Dec 5 10:02:43 2006
> > > @@ -96,7 +96,7 @@
> > > {
> > > if (_value != null) return _value;
> > > ValueBinding vb = getValueBinding("value");
> > > - return vb != null ?
> (Object)vb.getValue(getFacesContext()) : null;
> > > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > > }
> > >
> > >
> > > @@ -105,14 +105,14 @@
> > > Object values[] = new Object[2];
> > > values[0] = super.saveState (context);
> > > values[1] = _value;
> > > - return ((Object) (values));
> > > + return values;
> > > }
> > >
> > > public void restoreState(FacesContext context, Object state)
> > > {
> > > Object values[] = (Object[])state;
> > > super.restoreState(context, values[0]);
> > > - _value = (Object)values[1];
> > > + _value = values[1];
> > > }
> > > //------------------ GENERATED CODE END
> ---------------------------------------
> > > }
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
> Tue Dec 5 10:02:43 2006
> > > @@ -481,7 +481,7 @@
> > > values[6] = saveAttachedState(context, _validator);
> > > values[7] = saveAttachedState(context, _valueChangeListener);
> > > values[8] = saveAttachedState(context, _validatorList);
> > > - return ((Object)(values));
> > > + return values;
> > > }
> > >
> > > public void restoreState(FacesContext context, Object state)
> > > @@ -491,7 +491,7 @@
> > > _immediate = (Boolean)values[1];
> > > _localValueSet =
> ((Boolean)values[2]).booleanValue();
> > > _required = (Boolean)values[3];
> > > - _submittedValue = (Object)values[4];
> > > + _submittedValue = values[4];
> > > _valid = ((Boolean)values[5]).booleanValue();
> > > _validator =
> (MethodBinding)restoreAttachedState(context, values[6]);
> > > _valueChangeListener =
> (MethodBinding)restoreAttachedState(context, values[7]);
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java
> Tue Dec 5 10:02:43 2006
> > > @@ -100,7 +100,7 @@
> > > values[1] = _for;
> > > values[2] = _showDetail;
> > > values[3] = _showSummary;
> > > - return ((Object) (values));
> > > + return values;
> > > }
> > >
> > > public void restoreState(FacesContext context, Object state)
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java
> Tue Dec 5 10:02:43 2006
> > > @@ -100,7 +100,7 @@
> > > values[1] = _globalOnly;
> > > values[2] = _showDetail;
> > > values[3] = _showSummary;
> > > - return ((Object) (values));
> > > + return values;
> > > }
> > >
> > > public void restoreState(FacesContext context, Object state)
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java
> Tue Dec 5 10:02:43 2006
> > > @@ -77,7 +77,7 @@
> > > {
> > > if (_value != null) return _value;
> > > ValueBinding vb = getValueBinding("value");
> > > - return vb != null ?
> (Object)vb.getValue(getFacesContext()) : null;
> > > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > > }
> > >
> > >
> > > @@ -87,7 +87,7 @@
> > > values[0] = super.saveState(context);
> > > values[1] = saveAttachedState(context, _converter);
> > > values[2] = _value;
> > > - return ((Object) (values));
> > > + return values;
> > > }
> > >
> > > public void restoreState(FacesContext context, Object state)
> > > @@ -95,7 +95,7 @@
> > > Object values[] = (Object[])state;
> > > super.restoreState(context, values[0]);
> > > _converter =
> (Converter)restoreAttachedState(context, values[1]);
> > > - _value = (Object)values[2];
> > > + _value = values[2];
> > > }
> > > //------------------ GENERATED CODE END
> ---------------------------------------
> > > }
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java
> Tue Dec 5 10:02:43 2006
> > > @@ -68,7 +68,7 @@
> > > {
> > > if (_value != null) return _value;
> > > ValueBinding vb = getValueBinding("value");
> > > - return vb != null ?
> (Object)vb.getValue(getFacesContext()) : null;
> > > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > > }
> > >
> > >
> > > @@ -78,7 +78,7 @@
> > > values[0] = super.saveState(context);
> > > values[1] = _name;
> > > values[2] = _value;
> > > - return ((Object) (values));
> > > + return values;
> > > }
> > >
> > > public void restoreState(FacesContext context, Object state)
> > > @@ -86,7 +86,7 @@
> > > Object values[] = (Object[])state;
> > > super.restoreState(context, values[0]);
> > > _name = (String)values[1];
> > > - _value = (Object)values[2];
> > > + _value = values[2];
> > > }
> > > //------------------ GENERATED CODE END
> ---------------------------------------
> > >
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java
> Tue Dec 5 10:02:43 2006
> > > @@ -42,7 +42,7 @@
> > > if( value == null )
> > > value = (Boolean)getValue();
> > >
> > > - return value != null ? value.booleanValue() : false;
> > > + return value != null && value.booleanValue();
> > > }
> > >
> > > public ValueBinding getValueBinding(String name)
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java
> Tue Dec 5 10:02:43 2006
> > > @@ -123,7 +123,7 @@
> > > {
> > > if (_itemValue != null) return _itemValue;
> > > ValueBinding vb = getValueBinding("itemValue");
> > > - return vb != null ?
> (Object)vb.getValue(getFacesContext()) : null;
> > > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > > }
> > >
> > > public void setValue(Object value)
> > > @@ -135,7 +135,7 @@
> > > {
> > > if (_value != null) return _value;
> > > ValueBinding vb = getValueBinding("value");
> > > - return vb != null ?
> (Object)vb.getValue(getFacesContext()) : null;
> > > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > > }
> > >
> > >
> > > @@ -148,7 +148,7 @@
> > > values[3] = _itemLabel;
> > > values[4] = _itemValue;
> > > values[5] = _value;
> > > - return ((Object) (values));
> > > + return values;
> > > }
> > >
> > > public void restoreState(FacesContext context, Object state)
> > > @@ -158,8 +158,8 @@
> > > _itemDescription = (String)values[1];
> > > _itemDisabled = (Boolean)values[2];
> > > _itemLabel = (String)values[3];
> > > - _itemValue = (Object)values[4];
> > > - _value = (Object)values[5];
> > > + _itemValue = values[4];
> > > + _value = values[5];
> > > }
> > > //------------------ GENERATED CODE END
> ---------------------------------------
> > > }
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java
> Tue Dec 5 10:02:43 2006
> > > @@ -55,7 +55,7 @@
> > > {
> > > if (_value != null) return _value;
> > > ValueBinding vb = getValueBinding("value");
> > > - return vb != null ?
> (Object)vb.getValue(getFacesContext()) : null;
> > > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > > }
> > >
> > >
> > > @@ -64,14 +64,14 @@
> > > Object values[] = new Object[2];
> > > values[0] = super.saveState (context);
> > > values[1] = _value;
> > > - return ((Object) (values));
> > > + return values;
> > > }
> > >
> > > public void restoreState(FacesContext context, Object state)
> > > {
> > > Object values[] = (Object[])state;
> > > super.restoreState(context, values[0]);
> > > - _value = (Object)values[1];
> > > + _value = values[1];
> > > }
> > > //------------------ GENERATED CODE END
> ---------------------------------------
> > > }
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java
> Tue Dec 5 10:02:43 2006
> > > @@ -18,7 +18,6 @@
> > > */
> > > package javax.faces.component;
> > >
> > > -import
> javax.faces.component._SelectItemsUtil._ValueConverter;
> > > import javax.faces.context.FacesContext;
> > >
> > > /**
> > >
> > > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java
> > > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java?view=diff&rev=482726&r1=482725&r2=482726
> > >
> ==============================================================================
> > > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java
> (original)
> > > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java
> Tue Dec 5 10:02:43 2006
> > > @@ -114,12 +114,11 @@
> > > {
> > > StringBuffer buffer = new StringBuffer();
> > >
> > > - buffer.append(" Someone is trying to access a secure
> resource : "
> > > - + pathInfo);
> > > - buffer.append("\n remote address is " +
> httpRequest.getRemoteAddr());
> > > - buffer.append("\n remote host is " +
> httpRequest.getRemoteHost ());
> > > - buffer.append("\n remote user is " +
> httpRequest.getRemoteUser());
> > > - buffer.append("\n request URI is " +
> httpRequest.getRequestURI());
> > > + buffer.append(" Someone is trying to access a secure
> resource : ").append(pathInfo);
> > > + buffer.append("\n remote address is
> ").append(httpRequest.getRemoteAddr());
> > > + buffer.append("\n remote host is
> ").append(httpRequest.getRemoteHost());
> > > + buffer.append("\n remote user is
> ").append(httpRequest.getRemoteUser());
> > > + buffer.append ("\n request URI is
> ").append(httpRequest.getRequestURI());
> > >
> > > log.warn(buffer.toString());
> > >
> > >
> > >
> > >
> >
> >
>
>
>
> --
> Grant Smith
>
Re: svn commit: r482726 - in /myfaces/core/trunk/api/src/main/java/javax/faces: component/ webapp/
Posted by Grant Smith <wo...@gmail.com>.
Thats true. There has been some discussion in the past regarding whether or
not the code generator is still useful. I'll have to check the archives, but
yes, it should be fixed there too. I believe Manfred is the expert on the
generator.
On 12/5/06, Paul Spencer <pa...@apache.org> wrote:
>
> Grant,
> I noticed some of the castings you removed where from generated code.
> Is the code generate still in use? If so, does it need to be fixed?
>
>
> Paul Spencer
>
>
> grantsmith@apache.org wrote:
> > Author: grantsmith
> > Date: Tue Dec 5 10:02:43 2006
> > New Revision: 482726
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=482726
> > Log:
> > removed redundant casting & some code cleanup
> >
> > Modified:
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java
> >
> myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UICommand.java
> Tue Dec 5 10:02:43 2006
> > @@ -170,7 +170,7 @@
> > {
> > if (_value != null) return _value;
> > ValueBinding vb = getValueBinding("value");
> > - return vb != null ? (Object)vb.getValue(getFacesContext()) :
> null;
> > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > }
> >
> >
> > @@ -183,7 +183,7 @@
> > values[2] = saveAttachedState(context, _actionListener);
> > values[3] = _immediate;
> > values[4] = _value;
> > - return ((Object) (values));
> > + return values;
> > }
> >
> > public void restoreState(FacesContext context, Object state)
> > @@ -193,7 +193,7 @@
> > _action = (MethodBinding)restoreAttachedState(context,
> values[1]);
> > _actionListener = (MethodBinding)restoreAttachedState(context,
> values[2]);
> > _immediate = (Boolean)values[3];
> > - _value = (Object)values[4];
> > + _value = values[4];
> > }
> > //------------------ GENERATED CODE END
> ---------------------------------------
> > }
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java Tue
> Dec 5 10:02:43 2006
> > @@ -1020,7 +1020,7 @@
> > if (_value != null)
> > return _value;
> > ValueBinding vb = getValueBinding("value");
> > - return vb != null ? (Object) vb.getValue(getFacesContext()) :
> null;
> > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > }
> >
> > //------------------ GENERATED CODE END
> ---------------------------------------
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIGraphic.java
> Tue Dec 5 10:02:43 2006
> > @@ -96,7 +96,7 @@
> > {
> > if (_value != null) return _value;
> > ValueBinding vb = getValueBinding("value");
> > - return vb != null ? (Object)vb.getValue(getFacesContext()) :
> null;
> > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > }
> >
> >
> > @@ -105,14 +105,14 @@
> > Object values[] = new Object[2];
> > values[0] = super.saveState(context);
> > values[1] = _value;
> > - return ((Object) (values));
> > + return values;
> > }
> >
> > public void restoreState(FacesContext context, Object state)
> > {
> > Object values[] = (Object[])state;
> > super.restoreState(context, values[0]);
> > - _value = (Object)values[1];
> > + _value = values[1];
> > }
> > //------------------ GENERATED CODE END
> ---------------------------------------
> > }
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java Tue
> Dec 5 10:02:43 2006
> > @@ -481,7 +481,7 @@
> > values[6] = saveAttachedState(context, _validator);
> > values[7] = saveAttachedState(context, _valueChangeListener);
> > values[8] = saveAttachedState(context, _validatorList);
> > - return ((Object)(values));
> > + return values;
> > }
> >
> > public void restoreState(FacesContext context, Object state)
> > @@ -491,7 +491,7 @@
> > _immediate = (Boolean)values[1];
> > _localValueSet = ((Boolean)values[2]).booleanValue();
> > _required = (Boolean)values[3];
> > - _submittedValue = (Object)values[4];
> > + _submittedValue = values[4];
> > _valid = ((Boolean)values[5]).booleanValue();
> > _validator = (MethodBinding)restoreAttachedState(context,
> values[6]);
> > _valueChangeListener =
> (MethodBinding)restoreAttachedState(context, values[7]);
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessage.java
> Tue Dec 5 10:02:43 2006
> > @@ -100,7 +100,7 @@
> > values[1] = _for;
> > values[2] = _showDetail;
> > values[3] = _showSummary;
> > - return ((Object) (values));
> > + return values;
> > }
> >
> > public void restoreState(FacesContext context, Object state)
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIMessages.java
> Tue Dec 5 10:02:43 2006
> > @@ -100,7 +100,7 @@
> > values[1] = _globalOnly;
> > values[2] = _showDetail;
> > values[3] = _showSummary;
> > - return ((Object) (values));
> > + return values;
> > }
> >
> > public void restoreState(FacesContext context, Object state)
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIOutput.java Tue
> Dec 5 10:02:43 2006
> > @@ -77,7 +77,7 @@
> > {
> > if (_value != null) return _value;
> > ValueBinding vb = getValueBinding("value");
> > - return vb != null ? (Object)vb.getValue(getFacesContext()) :
> null;
> > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > }
> >
> >
> > @@ -87,7 +87,7 @@
> > values[0] = super.saveState(context);
> > values[1] = saveAttachedState(context, _converter);
> > values[2] = _value;
> > - return ((Object) (values));
> > + return values;
> > }
> >
> > public void restoreState(FacesContext context, Object state)
> > @@ -95,7 +95,7 @@
> > Object values[] = (Object[])state;
> > super.restoreState(context, values[0]);
> > _converter = (Converter)restoreAttachedState(context,
> values[1]);
> > - _value = (Object)values[2];
> > + _value = values[2];
> > }
> > //------------------ GENERATED CODE END
> ---------------------------------------
> > }
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UIParameter.java
> Tue Dec 5 10:02:43 2006
> > @@ -68,7 +68,7 @@
> > {
> > if (_value != null) return _value;
> > ValueBinding vb = getValueBinding("value");
> > - return vb != null ? (Object)vb.getValue(getFacesContext()) :
> null;
> > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > }
> >
> >
> > @@ -78,7 +78,7 @@
> > values[0] = super.saveState(context);
> > values[1] = _name;
> > values[2] = _value;
> > - return ((Object) (values));
> > + return values;
> > }
> >
> > public void restoreState(FacesContext context, Object state)
> > @@ -86,7 +86,7 @@
> > Object values[] = (Object[])state;
> > super.restoreState(context, values[0]);
> > _name = (String)values[1];
> > - _value = (Object)values[2];
> > + _value = values[2];
> > }
> > //------------------ GENERATED CODE END
> ---------------------------------------
> >
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectBoolean.java
> Tue Dec 5 10:02:43 2006
> > @@ -42,7 +42,7 @@
> > if( value == null )
> > value = (Boolean)getValue();
> >
> > - return value != null ? value.booleanValue() : false;
> > + return value != null && value.booleanValue();
> > }
> >
> > public ValueBinding getValueBinding(String name)
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItem.java
> Tue Dec 5 10:02:43 2006
> > @@ -123,7 +123,7 @@
> > {
> > if (_itemValue != null) return _itemValue;
> > ValueBinding vb = getValueBinding("itemValue");
> > - return vb != null ? (Object)vb.getValue(getFacesContext()) :
> null;
> > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > }
> >
> > public void setValue(Object value)
> > @@ -135,7 +135,7 @@
> > {
> > if (_value != null) return _value;
> > ValueBinding vb = getValueBinding("value");
> > - return vb != null ? (Object)vb.getValue(getFacesContext()) :
> null;
> > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > }
> >
> >
> > @@ -148,7 +148,7 @@
> > values[3] = _itemLabel;
> > values[4] = _itemValue;
> > values[5] = _value;
> > - return ((Object) (values));
> > + return values;
> > }
> >
> > public void restoreState(FacesContext context, Object state)
> > @@ -158,8 +158,8 @@
> > _itemDescription = (String)values[1];
> > _itemDisabled = (Boolean)values[2];
> > _itemLabel = (String)values[3];
> > - _itemValue = (Object)values[4];
> > - _value = (Object)values[5];
> > + _itemValue = values[4];
> > + _value = values[5];
> > }
> > //------------------ GENERATED CODE END
> ---------------------------------------
> > }
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectItems.java
> Tue Dec 5 10:02:43 2006
> > @@ -55,7 +55,7 @@
> > {
> > if (_value != null) return _value;
> > ValueBinding vb = getValueBinding("value");
> > - return vb != null ? (Object)vb.getValue(getFacesContext()) :
> null;
> > + return vb != null ? vb.getValue(getFacesContext()) : null;
> > }
> >
> >
> > @@ -64,14 +64,14 @@
> > Object values[] = new Object[2];
> > values[0] = super.saveState(context);
> > values[1] = _value;
> > - return ((Object) (values));
> > + return values;
> > }
> >
> > public void restoreState(FacesContext context, Object state)
> > {
> > Object values[] = (Object[])state;
> > super.restoreState(context, values[0]);
> > - _value = (Object)values[1];
> > + _value = values[1];
> > }
> > //------------------ GENERATED CODE END
> ---------------------------------------
> > }
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectOne.java
> Tue Dec 5 10:02:43 2006
> > @@ -18,7 +18,6 @@
> > */
> > package javax.faces.component;
> >
> > -import javax.faces.component._SelectItemsUtil._ValueConverter;
> > import javax.faces.context.FacesContext;
> >
> > /**
> >
> > Modified:
> myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java?view=diff&rev=482726&r1=482725&r2=482726
> >
> ==============================================================================
> > ---
> myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java
> (original)
> > +++
> myfaces/core/trunk/api/src/main/java/javax/faces/webapp/FacesServlet.java
> Tue Dec 5 10:02:43 2006
> > @@ -114,12 +114,11 @@
> > {
> > StringBuffer buffer = new StringBuffer();
> >
> > - buffer.append(" Someone is trying to access a secure
> resource : "
> > - + pathInfo);
> > - buffer.append("\n remote address is " +
> httpRequest.getRemoteAddr());
> > - buffer.append("\n remote host is " +
> httpRequest.getRemoteHost());
> > - buffer.append("\n remote user is " +
> httpRequest.getRemoteUser());
> > - buffer.append("\n request URI is " +
> httpRequest.getRequestURI());
> > + buffer.append(" Someone is trying to access a secure
> resource : ").append(pathInfo);
> > + buffer.append("\n remote address is ").append(
> httpRequest.getRemoteAddr());
> > + buffer.append("\n remote host is ").append(
> httpRequest.getRemoteHost());
> > + buffer.append("\n remote user is ").append(
> httpRequest.getRemoteUser());
> > + buffer.append("\n request URI is ").append(
> httpRequest.getRequestURI());
> >
> > log.warn(buffer.toString());
> >
> >
> >
> >
>
>
--
Grant Smith