You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2005/01/18 13:51:04 UTC

[PATCH] Clarify the semantics of file locking

The locking functional specification is not completely clear.  Do you agree 
with this clarification and, if so, may I commit it?

(An alternative interpretation of the first part could be: "The restriction on 
moving or deleting a locked file is a restriction on changing its membership of 
its immediate parent directory.  Thus, moving or renaming any parent directory 
is still allowed as long as this file retains its current name within its 
immediate parent.")

- Julian



Clarify the semantics of file locking.

* notes/locking/locking-functional-spec.txt

Index: notes/locking/locking-functional-spec.txt
===================================================================
--- notes/locking/locking-functional-spec.txt   (revision 12757)
+++ notes/locking/locking-functional-spec.txt   (working copy)
@@ -48,12 +48,21 @@ II. New Client Behaviors
           right to change the file's text and properties, to delete the
           file, and to move the file.

+         The restriction on moving or deleting a locked file is a
+         restriction on changing its full path name in any way,
+         including by moving or renaming or deleting any of its
+         parent directories.
+
+         (A locked file can still be read and copied, and any copy of it
+         will not automatically be locked.)
+
     B. Client requirements for locking

        1. Enforcement system

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Clarify the semantics of file locking

Posted by Ben Collins-Sussman <su...@collab.net>.
+1



On Jan 18, 2005, at 7:51 AM, Julian Foad wrote:

> The locking functional specification is not completely clear.  Do you 
> agree with this clarification and, if so, may I commit it?
>
> (An alternative interpretation of the first part could be: "The 
> restriction on moving or deleting a locked file is a restriction on 
> changing its membership of its immediate parent directory.  Thus, 
> moving or renaming any parent directory is still allowed as long as 
> this file retains its current name within its immediate parent.")
>
> - Julian
>
>
>
> Clarify the semantics of file locking.
>
> * notes/locking/locking-functional-spec.txt
>
> Index: notes/locking/locking-functional-spec.txt
> ===================================================================
> --- notes/locking/locking-functional-spec.txt   (revision 12757)
> +++ notes/locking/locking-functional-spec.txt   (working copy)
> @@ -48,12 +48,21 @@ II. New Client Behaviors
>           right to change the file's text and properties, to delete the
>           file, and to move the file.
>
> +         The restriction on moving or deleting a locked file is a
> +         restriction on changing its full path name in any way,
> +         including by moving or renaming or deleting any of its
> +         parent directories.
> +
> +         (A locked file can still be read and copied, and any copy of 
> it
> +         will not automatically be locked.)
> +
>     B. Client requirements for locking
>
>        1. Enforcement system
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Clarify the semantics of file locking

Posted by Julian Foad <ju...@btopenworld.com>.
Thanks Ben and Fitz.  Committed in r12781.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Clarify the semantics of file locking

Posted by "Brian W. Fitzpatrick" <fi...@collab.net>.
+1

On Jan 18, 2005, at 8:10 AM, Julian Foad wrote:

> Sorry, the patch was malformed because I deleted some irrelevant stuff 
> from the end and didn't adjust the line numbers.  Here it is with the 
> correct numbers.
>
> - Julian
>
>
> Clarify the semantics of file locking.
>
> * notes/locking/locking-functional-spec.txt
>
> Index: notes/locking/locking-functional-spec.txt
> ===================================================================
> --- notes/locking/locking-functional-spec.txt   (revision 12757)
> +++ notes/locking/locking-functional-spec.txt   (working copy)
> @@ -48,6 +48,14 @@ II. New Client Behaviors
>           right to change the file's text and properties, to delete the
>           file, and to move the file.
>
> +         The restriction on moving or deleting a locked file is a
> +         restriction on changing its full path name in any way,
> +         including by moving or renaming or deleting any of its
> +         parent directories.
> +
> +         (A locked file can still be read and copied, and any copy of 
> it
> +         will not automatically be locked.)
> +
>     B. Client requirements for locking
>
>        1. Enforcement system
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Clarify the semantics of file locking

Posted by Julian Foad <ju...@btopenworld.com>.
Sorry, the patch was malformed because I deleted some irrelevant stuff from the 
end and didn't adjust the line numbers.  Here it is with the correct numbers.

- Julian


Clarify the semantics of file locking.

* notes/locking/locking-functional-spec.txt

Index: notes/locking/locking-functional-spec.txt
===================================================================
--- notes/locking/locking-functional-spec.txt   (revision 12757)
+++ notes/locking/locking-functional-spec.txt   (working copy)
@@ -48,6 +48,14 @@ II. New Client Behaviors
           right to change the file's text and properties, to delete the
           file, and to move the file.

+         The restriction on moving or deleting a locked file is a
+         restriction on changing its full path name in any way,
+         including by moving or renaming or deleting any of its
+         parent directories.
+
+         (A locked file can still be read and copied, and any copy of it
+         will not automatically be locked.)
+
     B. Client requirements for locking

        1. Enforcement system

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org