You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/14 03:29:52 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1910:
Adapting partial code(file name start with A) to the sonar cloud rules
codecov-io commented on issue #1910: Adapting partial code(file name start with A) to the sonar cloud rules
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1910#issuecomment-586081111
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910?src=pr&el=h1) Report
> Merging [#1910](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4a25127f6dbf485657eefdcff654ed6cb3fb7a11?src=pr&el=desc) will **increase** coverage by `2.87%`.
> The diff coverage is `12.5%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1910 +/- ##
============================================
+ Coverage 24.31% 27.19% +2.87%
- Complexity 0 1383 +1383
============================================
Files 298 312 +14
Lines 14388 16638 +2250
Branches 2371 2045 -326
============================================
+ Hits 3498 4524 +1026
- Misses 10461 11637 +1176
- Partials 429 477 +48
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/dolphinscheduler/dao/AlertDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL0FsZXJ0RGFvLmphdmE=) | `1.72% <ø> (-1.67%)` | `1 <0> (+1)` | |
| [.../org/apache/dolphinscheduler/dao/entity/Alert.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BbGVydC5qYXZh) | `47.05% <ø> (+38.36%)` | `26 <0> (+26)` | :arrow_up: |
| [...che/dolphinscheduler/api/ApiApplicationServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL0FwaUFwcGxpY2F0aW9uU2VydmVyLmphdmE=) | `33.33% <ø> (+33.33%)` | `1 <0> (+1)` | :arrow_up: |
| [...olphinscheduler/api/service/AlertGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQWxlcnRHcm91cFNlcnZpY2UuamF2YQ==) | `88.88% <ø> (+0.12%)` | `17 <0> (+17)` | :arrow_up: |
| [...lphinscheduler/common/task/AbstractParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svQWJzdHJhY3RQYXJhbWV0ZXJzLmphdmE=) | `9.09% <ø> (+9.09%)` | `1 <0> (+1)` | :arrow_up: |
| [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `40.1% <0%> (-2.4%)` | `14 <0> (+14)` | |
| [...he/dolphinscheduler/server/utils/AlertManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL0FsZXJ0TWFuYWdlci5qYXZh) | `2.97% <0%> (ø)` | `2 <0> (+2)` | :arrow_up: |
| [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...scheduler/api/controller/AlertGroupController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQWxlcnRHcm91cENvbnRyb2xsZXIuamF2YQ==) | `4.08% <0%> (+1.99%)` | `2 <0> (+2)` | :arrow_up: |
| ... and [284 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910?src=pr&el=footer). Last update [4a25127...46a1cdd](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services