[jira] Commented: (SOLR-423) SolrRequestHandler close notification

["Ryan McKinley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546427 ] 

Ryan McKinley commented on SOLR-423:
------------------------------------

Aaaah that freaking interface!  So far, we have not broken API compatibility in 1.3 (though I have tried!) so I think we ought to find another way.

Off hand I see two options:

1.  Add close( SolrCore core ) to the SolrCoreAware interface
2.  Put the close method in RequestHandlerBase and have RequestHandlers.closeHandlers() check instanceof

#1 seems interesting because it would also give access to close() for QueryResponseWriters and SearchComponents

----

side note, where you have:

+ for (Iterator<SolrRequestHandler> objectIterator = handlers.values().iterator(); objectIterator.hasNext();) {
+      SolrRequestHandler handler = objectIterator.next();
+      handler.close();
+    }

with java 1.5 this could be:

for( SolrRequestHandler handler : handlers ) {
  handler.close();
}



> SolrRequestHandler close notification
> -------------------------------------
>
>                 Key: SOLR-423
>                 URL: https://issues.apache.org/jira/browse/SOLR-423
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-423.patch
>
>
> It may be beneficial for implementations of SolrRequestHandler to be notified that the SolrCore is closing so that they can release any resources that they may have open.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Commented: (SOLR-423) SolrRequestHandler close notification

[Grant Ingersoll <gs...@apache.org>]

On Nov 28, 2007, at 5:02 PM, Ryan McKinley (JIRA) wrote:

>
> with java 1.5 this could be:
>
> for( SolrRequestHandler handler : handlers ) {
>  handler.close();
> }
>

Old habits die hard.  Especially when I am so used to typing "itco" in  
IntelliJ for the Live Template mechanism.