You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/07/17 03:23:04 UTC
Review Request 23597: Fix 3rdparty libprocess todo and namespace style
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23597/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
Repository: mesos-git
Description
-------
Fix 3rdparty libprocess todo and namespace style
Diffs
-----
3rdparty/libprocess/include/process/event.hpp 3c860f4b11c4764964d89728cd16bba41bdd82b9
3rdparty/libprocess/include/process/metrics/timer.hpp 0b253aae7e6f1fb48c2f082b331c86f3dde95417
3rdparty/libprocess/include/process/protobuf.hpp a232107389d8506aaa5ac0d89e646e08f4fe1b3a
3rdparty/libprocess/include/process/tuples/tuples.hpp ac1198e9048ccd020a3ac6e5afa66d19ccab9742
3rdparty/libprocess/src/decoder.hpp c32988217a3e259078c6d48ef4c26112b6d3c6d8
3rdparty/libprocess/src/process.cpp 0c0fca7acf870fdc7ca89d471cbff63af7799eef
Diff: https://reviews.apache.org/r/23597/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 23597: Fix 3rdparty libprocess todo and namespace style
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23597/#review47987
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23597]
All tests passed.
- Mesos ReviewBot
On July 17, 2014, 1:23 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23597/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 1:23 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix 3rdparty libprocess todo and namespace style
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/event.hpp 3c860f4b11c4764964d89728cd16bba41bdd82b9
> 3rdparty/libprocess/include/process/metrics/timer.hpp 0b253aae7e6f1fb48c2f082b331c86f3dde95417
> 3rdparty/libprocess/include/process/protobuf.hpp a232107389d8506aaa5ac0d89e646e08f4fe1b3a
> 3rdparty/libprocess/include/process/tuples/tuples.hpp ac1198e9048ccd020a3ac6e5afa66d19ccab9742
> 3rdparty/libprocess/src/decoder.hpp c32988217a3e259078c6d48ef4c26112b6d3c6d8
> 3rdparty/libprocess/src/process.cpp 0c0fca7acf870fdc7ca89d471cbff63af7799eef
>
> Diff: https://reviews.apache.org/r/23597/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 23597: Fix 3rdparty libprocess todo and namespace style
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23597/#review48775
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On July 19, 2014, 1:50 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23597/
> -----------------------------------------------------------
>
> (Updated July 19, 2014, 1:50 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix 3rdparty libprocess todo and namespace style
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/event.hpp 3c860f4b11c4764964d89728cd16bba41bdd82b9
> 3rdparty/libprocess/include/process/metrics/timer.hpp 0b253aae7e6f1fb48c2f082b331c86f3dde95417
> 3rdparty/libprocess/include/process/protobuf.hpp a232107389d8506aaa5ac0d89e646e08f4fe1b3a
> 3rdparty/libprocess/include/process/tuples/tuples.hpp ac1198e9048ccd020a3ac6e5afa66d19ccab9742
> 3rdparty/libprocess/src/decoder.hpp c32988217a3e259078c6d48ef4c26112b6d3c6d8
> 3rdparty/libprocess/src/process.cpp 0c0fca7acf870fdc7ca89d471cbff63af7799eef
>
> Diff: https://reviews.apache.org/r/23597/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 23597: Fix 3rdparty libprocess todo and namespace style
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23597/#review49067
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On July 19, 2014, 1:50 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23597/
> -----------------------------------------------------------
>
> (Updated July 19, 2014, 1:50 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix 3rdparty libprocess todo and namespace style
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/event.hpp 3c860f4b11c4764964d89728cd16bba41bdd82b9
> 3rdparty/libprocess/include/process/metrics/timer.hpp 0b253aae7e6f1fb48c2f082b331c86f3dde95417
> 3rdparty/libprocess/include/process/protobuf.hpp a232107389d8506aaa5ac0d89e646e08f4fe1b3a
> 3rdparty/libprocess/include/process/tuples/tuples.hpp ac1198e9048ccd020a3ac6e5afa66d19ccab9742
> 3rdparty/libprocess/src/decoder.hpp c32988217a3e259078c6d48ef4c26112b6d3c6d8
> 3rdparty/libprocess/src/process.cpp 0c0fca7acf870fdc7ca89d471cbff63af7799eef
>
> Diff: https://reviews.apache.org/r/23597/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 23597: Fix 3rdparty libprocess todo and namespace style
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23597/
-----------------------------------------------------------
(Updated July 19, 2014, 8:50 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
Repository: mesos-git
Description
-------
Fix 3rdparty libprocess todo and namespace style
Diffs
-----
3rdparty/libprocess/include/process/event.hpp 3c860f4b11c4764964d89728cd16bba41bdd82b9
3rdparty/libprocess/include/process/metrics/timer.hpp 0b253aae7e6f1fb48c2f082b331c86f3dde95417
3rdparty/libprocess/include/process/protobuf.hpp a232107389d8506aaa5ac0d89e646e08f4fe1b3a
3rdparty/libprocess/include/process/tuples/tuples.hpp ac1198e9048ccd020a3ac6e5afa66d19ccab9742
3rdparty/libprocess/src/decoder.hpp c32988217a3e259078c6d48ef4c26112b6d3c6d8
3rdparty/libprocess/src/process.cpp 0c0fca7acf870fdc7ca89d471cbff63af7799eef
Diff: https://reviews.apache.org/r/23597/diff/
Testing
-------
make check
Thanks,
Timothy Chen