[GitHub] [superset] sebastianliebscher commented on a diff in pull request #24504: build(docker): simplification of assembly to facilitate further support

["sebastianliebscher (via GitHub)" <gi...@apache.org>]

sebastianliebscher commented on code in PR #24504:
URL: https://github.com/apache/superset/pull/24504#discussion_r1240870453


##########
.github/workflows/docker.yml:
##########
@@ -50,7 +50,7 @@ jobs:
           mkdir -p ./build
           echo ${{ github.sha }} > ./build/SHA
           echo ${{ github.event.pull_request.number }} > ./build/PR-NUM
-          docker build --target ci -t ${{ github.sha }} -t "pr-${{ github.event.pull_request.number }}" .
+          DOCKER_BUILDKIT=1 docker build --target ci -t ${{ github.sha }} -t "pr-${{ github.event.pull_request.number }}" .

Review Comment:
   The runner already uses docker-buildx by default. Have a look [here](https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#tools). So I don't think it is necessary setting this variable `DOCKER_BUILDKIT=1` explicitly. Please correct me if I am wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org