[jira] Updated: (HADOOP-3896) MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found

["Steve Loughran (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated HADOOP-3896:
-----------------------------------

    Priority: Minor  (was: Major)

marking as minor; the method is only used in TestDatanodeDeath

> MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3896
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3896
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Steve Loughran
>            Priority: Minor
>
> The stopDataNode method will shut down the last node in the list of nodes, if one matching a specific name is not found
> This is possibly not what was intended. Better to return false or fail in some other manner if the named node was not located
>  synchronized boolean stopDataNode(String name) {
>     int i;
>     for (i = 0; i < dataNodes.size(); i++) {
>       DataNode dn = dataNodes.get(i).datanode;
>       if (dn.dnRegistration.getName().equals(name)) {
>         break;
>       }
>     }
>     return stopDataNode(i);
>   }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.