You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2014/06/12 02:07:10 UTC

Review Request 22486: Remove red from the config grouping

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22486/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.


Bugs: AURORA-525
    https://issues.apache.org/jira/browse/AURORA-525


Repository: aurora


Description
-------

Remove red from the config grouping


Diffs
-----

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 556df0c9a38468e5735c5785dfa73cba553746e5 

Diff: https://reviews.apache.org/r/22486/diff/


Testing
-------


File Attachments
----------------

Two groups
  https://reviews.apache.org/media/uploaded/files/2014/06/12/3d2c0cd6-6b1f-473b-943a-20db33fd1d90__Screen_Shot_2014-06-11_at_5.02.03_PM.png
All colours.
  https://reviews.apache.org/media/uploaded/files/2014/06/12/961a9dd5-6bea-4378-92f5-0f34b34d43df__Screen_Shot_2014-06-11_at_5.03.24_PM.png


Thanks,

David McLaughlin

Re: Review Request 22486: Remove red from the config grouping

Posted by Kevin Sweeney <ke...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22486/#review45450
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On June 11, 2014, 5:07 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22486/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 5:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-525
>     https://issues.apache.org/jira/browse/AURORA-525
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove red from the config grouping
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 556df0c9a38468e5735c5785dfa73cba553746e5 
> 
> Diff: https://reviews.apache.org/r/22486/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Two groups
>   https://reviews.apache.org/media/uploaded/files/2014/06/12/3d2c0cd6-6b1f-473b-943a-20db33fd1d90__Screen_Shot_2014-06-11_at_5.02.03_PM.png
> All colours.
>   https://reviews.apache.org/media/uploaded/files/2014/06/12/961a9dd5-6bea-4378-92f5-0f34b34d43df__Screen_Shot_2014-06-11_at_5.03.24_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 22486: Remove red from the config grouping

Posted by David McLaughlin <da...@dmclaughlin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22486/#review45962
-----------------------------------------------------------


Ping. 

- David McLaughlin


On June 12, 2014, 12:07 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22486/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 12:07 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-525
>     https://issues.apache.org/jira/browse/AURORA-525
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove red from the config grouping
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 556df0c9a38468e5735c5785dfa73cba553746e5 
> 
> Diff: https://reviews.apache.org/r/22486/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Two groups
>   https://reviews.apache.org/media/uploaded/files/2014/06/12/3d2c0cd6-6b1f-473b-943a-20db33fd1d90__Screen_Shot_2014-06-11_at_5.02.03_PM.png
> All colours.
>   https://reviews.apache.org/media/uploaded/files/2014/06/12/961a9dd5-6bea-4378-92f5-0f34b34d43df__Screen_Shot_2014-06-11_at_5.03.24_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 22486: Remove red from the config grouping

Posted by Joe Smith <ya...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22486/#review45644
-----------------------------------------------------------

Ship it!


Ship It!

- Joe Smith


On June 11, 2014, 5:07 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22486/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 5:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-525
>     https://issues.apache.org/jira/browse/AURORA-525
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove red from the config grouping
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 556df0c9a38468e5735c5785dfa73cba553746e5 
> 
> Diff: https://reviews.apache.org/r/22486/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Two groups
>   https://reviews.apache.org/media/uploaded/files/2014/06/12/3d2c0cd6-6b1f-473b-943a-20db33fd1d90__Screen_Shot_2014-06-11_at_5.02.03_PM.png
> All colours.
>   https://reviews.apache.org/media/uploaded/files/2014/06/12/961a9dd5-6bea-4378-92f5-0f34b34d43df__Screen_Shot_2014-06-11_at_5.03.24_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 22486: Remove red from the config grouping

Posted by Mark Chu-Carroll <mc...@twopensource.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22486/#review46463
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Chu-Carroll


On June 11, 2014, 8:07 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22486/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 8:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-525
>     https://issues.apache.org/jira/browse/AURORA-525
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove red from the config grouping
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 556df0c9a38468e5735c5785dfa73cba553746e5 
> 
> Diff: https://reviews.apache.org/r/22486/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Two groups
>   https://reviews.apache.org/media/uploaded/files/2014/06/12/3d2c0cd6-6b1f-473b-943a-20db33fd1d90__Screen_Shot_2014-06-11_at_5.02.03_PM.png
> All colours.
>   https://reviews.apache.org/media/uploaded/files/2014/06/12/961a9dd5-6bea-4378-92f5-0f34b34d43df__Screen_Shot_2014-06-11_at_5.03.24_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>