You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by wa...@apache.org on 2021/11/26 03:17:59 UTC

[echarts] branch ssr created (now 1916e1d)

This is an automated email from the ASF dual-hosted git repository.

wangzx pushed a change to branch ssr
in repository https://gitbox.apache.org/repos/asf/echarts.git.


      at 1916e1d  chore(core): remove `ssr` limit for `renderToSVGString`

This branch includes the following new commits:

     new 1916e1d  chore(core): remove `ssr` limit for `renderToSVGString`

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[echarts] 01/01: chore(core): remove `ssr` limit for `renderToSVGString`

Posted by wa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

wangzx pushed a commit to branch ssr
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit 1916e1d04c02563f118889cac28b0c8352dfd4dd
Author: Zhongxiang.Wang <yh...@all-my-life.cn>
AuthorDate: Fri Nov 26 11:17:24 2021 +0800

    chore(core): remove `ssr` limit for `renderToSVGString`
---
 src/core/echarts.ts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/core/echarts.ts b/src/core/echarts.ts
index b0ad6bd..7130c0b 100644
--- a/src/core/echarts.ts
+++ b/src/core/echarts.ts
@@ -713,9 +713,6 @@ class ECharts extends Eventful<ECEventDefinition> {
     renderToSVGString(): string {
         const painter = this._zr.painter;
         if (__DEV__) {
-            if (!this._ssr) {
-                throw new Error('renderToSVGString can only been used in SSR mode.');
-            }
             if (painter.type !== 'svg') {
                 throw new Error('renderToSVGString can only been used in the svg renderer.');
             }

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org