[jira] [Comment Edited] (HBASE-20070) website generation is failing

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377672#comment-16377672 ] 

Sean Busbey edited comment on HBASE-20070 at 2/26/18 10:06 PM:
---------------------------------------------------------------

-3
  - starts forcing {{-e}} instead of relying on how the script is called
  - adds command line arg parsing, including optional working directory, local repo, and publishing
  - creates a working directory in {{/tmp}} if one isn't given
  - adds an explicit error message if we get a blank "current hash" for the hbase repo

Note that invoking the script is totally different now:

{code}
 bash hbase/dev-support/jenkins-scripts/generate-hbase-website.sh --help
Usage: hbase/dev-support/jenkins-scripts/generate-hbase-website.sh [options] /path/to/hbase/checkout

    --working-dir /path/to/use  Path for writing logs and a local checkout of hbase-site repo.
                                if given must exist.
                                defaults to making a directory in /tmp.
    --local-repo /path/for/maven/.m2  Path for putting local maven repo.
                                if given must exist.
                                defaults to making a clean directory in --working-dir.
    --publish                   if given, will attempt to push results back to the hbase-site repo.
    --help                      show this usage message.
{code}

Also note that even if you pass in the {{--publish}} flag, the actual push to git is still commented out.


was (Author: busbey):
-3
  - starts forcing {{-e}} instead of relying on how the script is called
  - adds command line arg parsing, including optional working directory, local repo, and publishing
  - creates a working directory in {{/tmp}} if one isn't given

Note that invoking the script is totally different now:

{code}
 bash hbase/dev-support/jenkins-scripts/generate-hbase-website.sh --help
Usage: hbase/dev-support/jenkins-scripts/generate-hbase-website.sh [options] /path/to/hbase/checkout

    --working-dir /path/to/use  Path for writing logs and a local checkout of hbase-site repo.
                                if given must exist.
                                defaults to making a directory in /tmp.
    --local-repo /path/for/maven/.m2  Path for putting local maven repo.
                                if given must exist.
                                defaults to making a clean directory in --working-dir.
    --publish                   if given, will attempt to push results back to the hbase-site repo.
    --help                      show this usage message.
{code}

Also note that even if you pass in the {{--publish}} flag, the actual push to git is still commented out.

> website generation is failing
> -----------------------------
>
>                 Key: HBASE-20070
>                 URL: https://issues.apache.org/jira/browse/HBASE-20070
>             Project: HBase
>          Issue Type: Bug
>          Components: website
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Blocker
>         Attachments: HBASE-20070-misty.patch, HBASE-20070-misty.patch.1, HBASE-20070-misty.patch.3, HBASE-20070.0.patch, HBASE-20070.1.patch, HBASE-20070.2.patch, HBASE-20070.3.patch, hbase-install-log-a29b3caf4dbc7b8833474ef5da5438f7f6907e00.txt
>
>
> website generation has been failing since Feb 20th
> {code}
> Checking out files: 100% (68971/68971), done.
> Usage: grep [OPTION]... PATTERN [FILE]...
> Try 'grep --help' for more information.
> PUSHED is 2
>  is not yet mentioned in the hbase-site commit log. Assuming we don't have it yet. 2
> Building HBase
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
> Failure: mvn clean site
> Build step 'Execute shell' marked build as failure
> {code}
> The status email says
> {code}
> Build status: Still Failing
> The HBase website has not been updated to incorporate HBase commit ${CURRENT_HBASE_COMMIT}.
> {code}
> Looking at the code where that grep happens, it looks like the env variable CURRENT_HBASE_COMMIT isn't getting set. That comes from some git command. I'm guessing the version of git changed on the build hosts and upended our assumptions.
> we should fix this to 1) rely on git's porcelain interface, and 2) fail as soon as that git command fails



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)