You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Lefty Leverenz <le...@gmail.com> on 2015/02/01 08:52:46 UTC
Re: Review Request 29807: HIVE-9253: MetaStore server should support
timeout for long running requests
> On Jan. 20, 2015, 10:43 p.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 372-374
> > <https://reviews.apache.org/r/29807/diff/2/?file=827704#file827704line372>
> >
> > Shouldn't "long" & "LONG" be included in the names "hive.metastore.server.running.method.timeout" & "METASTORE_SERVER_RUNNING_METHOD_TIMEOUT"?
> >
> > Also, please specify the JIRA number (HIVE-9253) in this review request, either under Bugs in the Information section or in the Summary, or both.
>
> Dong Chen wrote:
> Thanks for your review and suggestion! Lefty.
> I have renamed it in the new patch.
Thanks very much.
- Lefty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29807/#review68878
-----------------------------------------------------------
On Jan. 28, 2015, 12:58 a.m., Dong Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29807/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 12:58 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-9253: MetaStore server should support timeout for long running requests
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 66f436b
> metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/DeadlineException.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java fc6f067
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 574141c
> metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 01ad36a
> metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java PRE-CREATION
> metastore/src/test/org/apache/hadoop/hive/metastore/TestDeadline.java PRE-CREATION
> metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29807/diff/
>
>
> Testing
> -------
>
> UT passed
>
>
> Thanks,
>
> Dong Chen
>
>