You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/02/27 15:23:50 UTC

[GitHub] incubator-brooklyn pull request: Cobertura to use maven plugin rat...

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/455#issuecomment-76401478
  
    dropping java1.6 support coverage sounds fine
    
    this runs fine even without #534 (fixed problem with antrun cobertura); it must be using a different directory structure.
    
    however not only does this compile twice (which is understandable at least in `/src/main` as we need the instrumented and non-instrumented versions of classes), this **runs** all the tests twice which seems bad; acceptable but a major slow-down.
    
    do we have a way to run the coverage check with both unit and integration tests activated?  the latter is important especially for packages such as `ssh`.
    
    @duncangrant do you suggest we merge this now (with the faults which have been noted here) or close this and you reopen it when ready?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---