You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ps...@apache.org on 2007/11/17 03:18:42 UTC
svn commit: r595897 - in /commons/sandbox/performance/trunk/src:
java/org/apache/commons/performance/dbcp/
java/org/apache/commons/performance/pool/
test/org/apache/commons/performance/pool/
Author: psteitz
Date: Fri Nov 16 18:18:42 2007
New Revision: 595897
URL: http://svn.apache.org/viewvc?rev=595897&view=rev
Log:
Added missing minIdle configuration.
Modified:
commons/sandbox/performance/trunk/src/java/org/apache/commons/performance/dbcp/DBCPSoak.java
commons/sandbox/performance/trunk/src/java/org/apache/commons/performance/pool/PoolSoak.java
commons/sandbox/performance/trunk/src/test/org/apache/commons/performance/pool/PoolSoakTest.java
commons/sandbox/performance/trunk/src/test/org/apache/commons/performance/pool/config-pool.xml
Modified: commons/sandbox/performance/trunk/src/java/org/apache/commons/performance/dbcp/DBCPSoak.java
URL: http://svn.apache.org/viewvc/commons/sandbox/performance/trunk/src/java/org/apache/commons/performance/dbcp/DBCPSoak.java?rev=595897&r1=595896&r2=595897&view=diff
==============================================================================
--- commons/sandbox/performance/trunk/src/java/org/apache/commons/performance/dbcp/DBCPSoak.java (original)
+++ commons/sandbox/performance/trunk/src/java/org/apache/commons/performance/dbcp/DBCPSoak.java Fri Nov 16 18:18:42 2007
@@ -217,6 +217,7 @@
String testWhileIdle, String type) throws ConfigurationException {
this.maxActive = Integer.parseInt(maxActive);
this.maxIdle = Integer.parseInt(maxIdle);
+ this.minIdle = Integer.parseInt(minIdle);
this.maxWait = Long.parseLong(maxWait);
this.testOnBorrow = Boolean.parseBoolean(testOnBorrow);
this.testOnReturn = Boolean.parseBoolean(testOnReturn);
Modified: commons/sandbox/performance/trunk/src/java/org/apache/commons/performance/pool/PoolSoak.java
URL: http://svn.apache.org/viewvc/commons/sandbox/performance/trunk/src/java/org/apache/commons/performance/pool/PoolSoak.java?rev=595897&r1=595896&r2=595897&view=diff
==============================================================================
--- commons/sandbox/performance/trunk/src/java/org/apache/commons/performance/pool/PoolSoak.java (original)
+++ commons/sandbox/performance/trunk/src/java/org/apache/commons/performance/pool/PoolSoak.java Fri Nov 16 18:18:42 2007
@@ -199,6 +199,7 @@
String testWhileIdle, String type) throws ConfigurationException {
this.maxActive = Integer.parseInt(maxActive);
this.maxIdle = Integer.parseInt(maxIdle);
+ this.minIdle = Integer.parseInt(minIdle);
this.maxWait = Long.parseLong(maxWait);
this.testOnBorrow = Boolean.parseBoolean(testOnBorrow);
this.testOnReturn = Boolean.parseBoolean(testOnReturn);
Modified: commons/sandbox/performance/trunk/src/test/org/apache/commons/performance/pool/PoolSoakTest.java
URL: http://svn.apache.org/viewvc/commons/sandbox/performance/trunk/src/test/org/apache/commons/performance/pool/PoolSoakTest.java?rev=595897&r1=595896&r2=595897&view=diff
==============================================================================
--- commons/sandbox/performance/trunk/src/test/org/apache/commons/performance/pool/PoolSoakTest.java (original)
+++ commons/sandbox/performance/trunk/src/test/org/apache/commons/performance/pool/PoolSoakTest.java Fri Nov 16 18:18:42 2007
@@ -68,7 +68,7 @@
GenericObjectPool pool = poolSoak.getPool();
assertEquals(15, pool.getMaxActive());
assertEquals(15, pool.getMaxIdle());
- assertEquals(0, pool.getMinIdle());
+ assertEquals(10, pool.getMinIdle());
assertEquals(-1, pool.getMaxWait());
assertEquals(GenericObjectPool.WHEN_EXHAUSTED_BLOCK,
pool.getWhenExhaustedAction());
Modified: commons/sandbox/performance/trunk/src/test/org/apache/commons/performance/pool/config-pool.xml
URL: http://svn.apache.org/viewvc/commons/sandbox/performance/trunk/src/test/org/apache/commons/performance/pool/config-pool.xml?rev=595897&r1=595896&r2=595897&view=diff
==============================================================================
--- commons/sandbox/performance/trunk/src/test/org/apache/commons/performance/pool/config-pool.xml (original)
+++ commons/sandbox/performance/trunk/src/test/org/apache/commons/performance/pool/config-pool.xml Fri Nov 16 18:18:42 2007
@@ -35,7 +35,7 @@
<type>GenericObjectPool</type>
<max-active>15</max-active>
<max-idle>15</max-idle>
- <min-idle>0</min-idle>
+ <min-idle>10</min-idle>
<max-wait>-1</max-wait>
<!-- block, fail, or grow -->
<exhausted-action>block</exhausted-action>