You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Namita Chaudhari <na...@sungard.com> on 2014/08/05 12:00:35 UTC
Review Request 24306: Review request for CLOUDSTACK-2694 - [Firewall Rule]
Able to configure duplicate firewall rule with protocol and no ports
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24306/
-----------------------------------------------------------
Review request for cloudstack and Jayapal Reddy.
Bugs: CLOUDSTACK-2694 and https://issues.apache.org/jira/browse/CLOUDSTACK-2694
https://issues.apache.org/jira/browse/CLOUDSTACK-2694
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2694
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol and no ports
When a duplicate firewall rule is created with same cidr, protocol and no ports, an error popup appears for duplicate firewall rule.
Diffs
-----
server/src/com/cloud/network/firewall/FirewallManagerImpl.java dd928d8
Diff: https://reviews.apache.org/r/24306/diff/
Testing
-------
Testing done based on the test cases updated in the bug.
Thanks,
Namita Chaudhari
Re: Review Request 24306: Review request for CLOUDSTACK-2694 -
[Firewall Rule] Able to configure duplicate firewall rule with protocol and
no ports
Posted by Jayapal Reddy Uradi <ja...@citrix.com>.
Hi Namita,
The patch is applied on master.
Please close the review ticket.
Thanks,
Jayapal
On 05-Aug-2014, at 5:57 PM, Jayapal Reddy <ja...@citrix.com>>
wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24306/
Ship it!
Ship It!
- Jayapal Reddy
On August 5th, 2014, 10 a.m. UTC, Namita Chaudhari wrote:
Review request for cloudstack and Jayapal Reddy.
By Namita Chaudhari.
Updated Aug. 5, 2014, 10 a.m.
Bugs: CLOUDSTACK-2694<https://issues.apache.org/jira/browse/CLOUDSTACK-2694>, https://issues.apache.org/jira/browse/CLOUDSTACK-2694<https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2694>
Repository: cloudstack-git
Description
CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol and no ports
When a duplicate firewall rule is created with same cidr, protocol and no ports, an error popup appears for duplicate firewall rule.
Testing
Testing done based on the test cases updated in the bug.
Diffs
* server/src/com/cloud/network/firewall/FirewallManagerImpl.java (dd928d8)
View Diff<https://reviews.apache.org/r/24306/diff/>
Re: Review Request 24306: Review request for CLOUDSTACK-2694 - [Firewall
Rule] Able to configure duplicate firewall rule with protocol and no ports
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24306/#review49593
-----------------------------------------------------------
Ship it!
Ship It!
- Jayapal Reddy
On Aug. 5, 2014, 10 a.m., Namita Chaudhari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24306/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 10 a.m.)
>
>
> Review request for cloudstack and Jayapal Reddy.
>
>
> Bugs: CLOUDSTACK-2694 and https://issues.apache.org/jira/browse/CLOUDSTACK-2694
> https://issues.apache.org/jira/browse/CLOUDSTACK-2694
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2694
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol and no ports
>
> When a duplicate firewall rule is created with same cidr, protocol and no ports, an error popup appears for duplicate firewall rule.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/firewall/FirewallManagerImpl.java dd928d8
>
> Diff: https://reviews.apache.org/r/24306/diff/
>
>
> Testing
> -------
>
> Testing done based on the test cases updated in the bug.
>
>
> Thanks,
>
> Namita Chaudhari
>
>
Re: Review Request 24306: Review request for CLOUDSTACK-2694 - [Firewall
Rule] Able to configure duplicate firewall rule with protocol and no ports
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24306/#review49594
-----------------------------------------------------------
Commit fce2880b9f20a372dd0a005c4575ffab526bac0b in cloudstack's branch refs/heads/master from namita.chaudhari
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fce2880 ]
CLOUDSTACK-2694: Able to configure duplicate firewall rule with protocol and no ports
Signed-off-by: Jayapal <ja...@apache.org>
- ASF Subversion and Git Services
On Aug. 5, 2014, 10 a.m., Namita Chaudhari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24306/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 10 a.m.)
>
>
> Review request for cloudstack and Jayapal Reddy.
>
>
> Bugs: CLOUDSTACK-2694 and https://issues.apache.org/jira/browse/CLOUDSTACK-2694
> https://issues.apache.org/jira/browse/CLOUDSTACK-2694
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2694
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol and no ports
>
> When a duplicate firewall rule is created with same cidr, protocol and no ports, an error popup appears for duplicate firewall rule.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/firewall/FirewallManagerImpl.java dd928d8
>
> Diff: https://reviews.apache.org/r/24306/diff/
>
>
> Testing
> -------
>
> Testing done based on the test cases updated in the bug.
>
>
> Thanks,
>
> Namita Chaudhari
>
>