You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Bayer <no...@github.com> on 2014/02/14 23:50:39 UTC

[jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

You can merge this Pull Request by running:

  git pull https://github.com/abayer/jclouds-1 jclouds-470-for-1.7.x

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/294

-- Commit Summary --

  * JCLOUDS-470. Include region in group name for AWSEC2SecurityGroupExtension.

-- File Changes --

    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/extensions/AWSEC2SecurityGroupExtension.java (18)
    M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/extensions/AWSEC2SecurityGroupExtensionExpectTest.java (76)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/294.patch
https://github.com/jclouds/jclouds/pull/294.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1146](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1146/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-44234552

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Jeremy Daggett <no...@github.com>.
@demobox @abayer Is this ready to be merged?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-47946095

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Andrew Phillips <no...@github.com>.
Also pinging the PR builders on this one...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-44232321

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Andrew Phillips <no...@github.com>.
> Was this merged?

I don't think so - there doesn't seem to be anything [in the issue](https://issues.apache.org/jira/browse/JCLOUDS-470) or [the commit log](https://github.com/jclouds/jclouds/commits/1.7.x?page=2).

@everett-toews: I've removed the 1.7.3 fix version as a consequence.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-44232262

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1301](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1301/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-44233624

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Andrew Phillips <no...@github.com>.
> jclouds-pull-requests #830 UNSTABLE

Well, at least it didn't fail! And the [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-compute/830/testReport/junit/org.jclouds.compute.callables/BlockUntilInitScriptStatusIsZeroThenReturnOutputTest/testloopUntilTrueOrThrowCancellationExceptionReturnsWhenPredicateIsTrueSecondTimeWhileNotCancelled/) is unrelated.

There are a [bunch of Checkstyle violations](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/830/violations/), but again, none of them related to this PR, as far as I can see. And since this is a backport, we probably should be addressing that kind of thing in a different PR.

So +1 again from me!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-44234968

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Andrew Phillips <no...@github.com>.
Reopened #294.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#event-124937947

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Zack Shoylev <no...@github.com>.
Was this merged?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-43691263

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Andrew Phillips <no...@github.com>.
Pending PR builders, +1 - looks good to me!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-35133169

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Andrew Phillips <no...@github.com>.
Merged to [1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=c0d7b3d). Thanks for the reminder, @jdaggett!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-47950314

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Andrew Phillips <no...@github.com>.
Closed #294.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#event-124937943

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #830](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/830/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-44234760

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Andrew Phillips <no...@github.com>.
> jclouds-java-7-pull-requests #1301 FAILURE

Can't even really figure out why this one failed?! Let's wait for the other ones...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#issuecomment-44234556

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

Posted by Andrew Phillips <no...@github.com>.
Closed #294.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/294#event-137978323