You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Adam Nichols (JIRA)" <ji...@apache.org> on 2010/05/01 01:14:58 UTC

[jira] Created: (PDFBOX-716) right parenthess are not handled properly in bookmarks

right parenthess are not handled properly in bookmarks
------------------------------------------------------

                 Key: PDFBOX-716
                 URL: https://issues.apache.org/jira/browse/PDFBOX-716
             Project: PDFBox
          Issue Type: Bug
          Components: Parsing
         Environment: Windows Vista 32-bit, Java 1.5.0_06, PDFBox HEAD tag (revision 939870)
            Reporter: Adam Nichols
             Fix For: 1.2.0
         Attachments: parentheses_fail.pdf

Bookmarks with a right parenthesis are not parsed correctly.  Instead of a right parenthesis ")", a backslash "\" is output.  For example "(L(I((S)P)))" becomes "(L(I((S\P\\\".

I'm attaching a file which demonstrates the issue.  Sample code segment to reproduce this:
doc = PDDocument.load(inputFile);
PDDocumentOutline root = doc.getDocumentCatalog().getDocumentOutline();
if(root != null) {
    PDOutlineItem item = root.getFirstChild();
    System.out.println("title = " + item.getTitle());
}

I'll post a patch if I can figure out where this issue lies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PDFBOX-716) right parenthess are not handled properly in bookmarks

Posted by "Adam Nichols (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862925#action_12862925 ] 

Adam Nichols commented on PDFBOX-716:
-------------------------------------

Issue not present in 1.1.0 tag.

> right parenthess are not handled properly in bookmarks
> ------------------------------------------------------
>
>                 Key: PDFBOX-716
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-716
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>         Environment: Windows Vista 32-bit, Java 1.5.0_06, PDFBox HEAD tag (revision 939870)
>            Reporter: Adam Nichols
>             Fix For: 1.2.0
>
>         Attachments: parentheses_fail.pdf
>
>
> Bookmarks with a right parenthesis are not parsed correctly.  Instead of a right parenthesis ")", a backslash "\" is output.  For example "(L(I((S)P)))" becomes "(L(I((S\P\\\".
> I'm attaching a file which demonstrates the issue.  Sample code segment to reproduce this:
> doc = PDDocument.load(inputFile);
> PDDocumentOutline root = doc.getDocumentCatalog().getDocumentOutline();
> if(root != null) {
>     PDOutlineItem item = root.getFirstChild();
>     System.out.println("title = " + item.getTitle());
> }
> I'll post a patch if I can figure out where this issue lies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PDFBOX-716) right parenthess are not handled properly in bookmarks

Posted by "Adam Nichols (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862933#action_12862933 ] 

Adam Nichols commented on PDFBOX-716:
-------------------------------------

This bug was introduced in revsion 939013 which was a patch for PDFBOX-276.  I reverted the changes that were made to org.apache.pdfbox.pdfparser.BaseParser and it tested just fine.

> right parenthess are not handled properly in bookmarks
> ------------------------------------------------------
>
>                 Key: PDFBOX-716
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-716
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>         Environment: Windows Vista 32-bit, Java 1.5.0_06, PDFBox HEAD tag (revision 939870)
>            Reporter: Adam Nichols
>             Fix For: 1.2.0
>
>         Attachments: parentheses_fail.pdf
>
>
> Bookmarks with a right parenthesis are not parsed correctly.  Instead of a right parenthesis ")", a backslash "\" is output.  For example "(L(I((S)P)))" becomes "(L(I((S\P\\\".
> I'm attaching a file which demonstrates the issue.  Sample code segment to reproduce this:
> doc = PDDocument.load(inputFile);
> PDDocumentOutline root = doc.getDocumentCatalog().getDocumentOutline();
> if(root != null) {
>     PDOutlineItem item = root.getFirstChild();
>     System.out.println("title = " + item.getTitle());
> }
> I'll post a patch if I can figure out where this issue lies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PDFBOX-716) right parenthess are not handled properly in bookmarks

Posted by "Andreas Lehmkühler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PDFBOX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Lehmkühler resolved PDFBOX-716.
---------------------------------------

    Resolution: Fixed

Instead of reverting peters patch I've fixed it with version 939998.

> right parenthess are not handled properly in bookmarks
> ------------------------------------------------------
>
>                 Key: PDFBOX-716
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-716
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>         Environment: Windows Vista 32-bit, Java 1.5.0_06, PDFBox HEAD tag (revision 939870)
>            Reporter: Adam Nichols
>             Fix For: 1.2.0
>
>         Attachments: parentheses_fail.pdf, PDFBOX-276_removal.patch
>
>
> Bookmarks with a right parenthesis are not parsed correctly.  Instead of a right parenthesis ")", a backslash "\" is output.  For example "(L(I((S)P)))" becomes "(L(I((S\P\\\".
> I'm attaching a file which demonstrates the issue.  Sample code segment to reproduce this:
> doc = PDDocument.load(inputFile);
> PDDocumentOutline root = doc.getDocumentCatalog().getDocumentOutline();
> if(root != null) {
>     PDOutlineItem item = root.getFirstChild();
>     System.out.println("title = " + item.getTitle());
> }
> I'll post a patch if I can figure out where this issue lies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PDFBOX-716) right parenthess are not handled properly in bookmarks

Posted by "Adam Nichols (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PDFBOX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Nichols updated PDFBOX-716:
--------------------------------

    Attachment: parentheses_fail.pdf

> right parenthess are not handled properly in bookmarks
> ------------------------------------------------------
>
>                 Key: PDFBOX-716
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-716
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>         Environment: Windows Vista 32-bit, Java 1.5.0_06, PDFBox HEAD tag (revision 939870)
>            Reporter: Adam Nichols
>             Fix For: 1.2.0
>
>         Attachments: parentheses_fail.pdf
>
>
> Bookmarks with a right parenthesis are not parsed correctly.  Instead of a right parenthesis ")", a backslash "\" is output.  For example "(L(I((S)P)))" becomes "(L(I((S\P\\\".
> I'm attaching a file which demonstrates the issue.  Sample code segment to reproduce this:
> doc = PDDocument.load(inputFile);
> PDDocumentOutline root = doc.getDocumentCatalog().getDocumentOutline();
> if(root != null) {
>     PDOutlineItem item = root.getFirstChild();
>     System.out.println("title = " + item.getTitle());
> }
> I'll post a patch if I can figure out where this issue lies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PDFBOX-716) right parenthess are not handled properly in bookmarks

Posted by "Adam Nichols (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PDFBOX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Nichols updated PDFBOX-716:
--------------------------------

    Attachment: PDFBOX-276_removal.patch

Here's a patch to revert the changes made by PDFBOX-276.  This will fix the parser to handle right parenthesis correctly, but reintroduces the issue reported in PDFBOX-276.  Applying this patch will fix issues with valid PDFs, but PDFs which are out of spec may have issues.

> right parenthess are not handled properly in bookmarks
> ------------------------------------------------------
>
>                 Key: PDFBOX-716
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-716
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>         Environment: Windows Vista 32-bit, Java 1.5.0_06, PDFBox HEAD tag (revision 939870)
>            Reporter: Adam Nichols
>             Fix For: 1.2.0
>
>         Attachments: parentheses_fail.pdf, PDFBOX-276_removal.patch
>
>
> Bookmarks with a right parenthesis are not parsed correctly.  Instead of a right parenthesis ")", a backslash "\" is output.  For example "(L(I((S)P)))" becomes "(L(I((S\P\\\".
> I'm attaching a file which demonstrates the issue.  Sample code segment to reproduce this:
> doc = PDDocument.load(inputFile);
> PDDocumentOutline root = doc.getDocumentCatalog().getDocumentOutline();
> if(root != null) {
>     PDOutlineItem item = root.getFirstChild();
>     System.out.println("title = " + item.getTitle());
> }
> I'll post a patch if I can figure out where this issue lies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (PDFBOX-716) right parenthess are not handled properly in bookmarks

Posted by "Andreas Lehmkühler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PDFBOX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863015#action_12863015 ] 

Andreas Lehmkühler edited comment on PDFBOX-716 at 5/1/10 8:41 AM:
-------------------------------------------------------------------

Instead of reverting peters patch I've fixed it with version 939998.

Thanks for the bug report

      was (Author: lehmi):
    Instead of reverting peters patch I've fixed it with version 939998.
  
> right parenthess are not handled properly in bookmarks
> ------------------------------------------------------
>
>                 Key: PDFBOX-716
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-716
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>         Environment: Windows Vista 32-bit, Java 1.5.0_06, PDFBox HEAD tag (revision 939870)
>            Reporter: Adam Nichols
>             Fix For: 1.2.0
>
>         Attachments: parentheses_fail.pdf, PDFBOX-276_removal.patch
>
>
> Bookmarks with a right parenthesis are not parsed correctly.  Instead of a right parenthesis ")", a backslash "\" is output.  For example "(L(I((S)P)))" becomes "(L(I((S\P\\\".
> I'm attaching a file which demonstrates the issue.  Sample code segment to reproduce this:
> doc = PDDocument.load(inputFile);
> PDDocumentOutline root = doc.getDocumentCatalog().getDocumentOutline();
> if(root != null) {
>     PDOutlineItem item = root.getFirstChild();
>     System.out.println("title = " + item.getTitle());
> }
> I'll post a patch if I can figure out where this issue lies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.