[jira] [Commented] (MAPREDUCE-6435) MapReduce client assumes the world is x86

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637544#comment-14637544 ] 

Hadoop QA commented on MAPREDUCE-6435:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | patch |   0m  0s | The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. |
| {color:blue}0{color} | pre-patch |   5m 22s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 42s | There were no new javac warning messages. |
| {color:green}+1{color} | release audit |   0m 19s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 20s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | mapreduce tests |  10m 49s | Tests passed in hadoop-mapreduce-client-nativetask. |
| | |  26m  8s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12746618/MAPREDUCE-6435 |
| Optional Tests | javac unit |
| git revision | trunk / 06e5dd2 |
| hadoop-mapreduce-client-nativetask test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5902/artifact/patchprocess/testrun_hadoop-mapreduce-client-nativetask.txt |
| Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5902/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5902/console |


This message was automatically generated.

> MapReduce client assumes the world is x86
> -----------------------------------------
>
>                 Key: MAPREDUCE-6435
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6435
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: client
>    Affects Versions: 2.7.1
>            Reporter: Alan Burlison
>            Assignee: Alan Burlison
>         Attachments: MAPREDUCE-6435
>
>
> hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/Checksum.cc contains x86-only code and assumes it's going to work by default. The logic should be inverted so that it only uses the x86 code when built on x86 and otherwise defaults to the architecture-independent code. That will prevent changes having to be made for each new architecture.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)