You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2023/04/27 01:46:14 UTC

[GitHub] [doris] xinyiZzz opened a new pull request, #19130: [fix](memory) Fix SchemaChange memory leak due to incorrect aggfunc destroy

xinyiZzz opened a new pull request, #19130:
URL: https://github.com/apache/doris/pull/19130

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   ```
   Direct leak of 192 byte(s) in 6 object(s) allocated from:
       #0 0x5598a4329bee in malloc (/mnt/hdd01/dorisTestEnv/VEC_ASAN/be/lib/doris_be+0x14cd1bee) (BuildId: 0e35cb6207c3ab7c)
       #1 0x5598a48e85c5 in Allocator<false, true>::alloc(unsigned long, unsigned long) /doris/be/src/vec/common/all
   ocator.h:157:27
       #2 0x5598a500adb6 in doris::vectorized::Allocator_<void* phmap::priv::Allocate<8ul, doris::vectorized::Allocator_<unsigned long>>(doris::vectorized::Alloc
   ator_<unsigned long>*, unsigned long)::M>::allocate(unsigned long) /doris/be/src/vec/common/hash_table/phmap_fwd_
   decl.h:39:73
       #3 0x5598a500ad6e in phmap::allocator_traits<doris::vectorized::Allocator_<void* phmap::priv::Allocate<8ul, doris::vectorized::Allocator_<unsigned long>>(
   doris::vectorized::Allocator_<unsigned long>*, unsigned long)::M>>::allocate(doris::vectorized::Allocator_<void* phmap::priv::Allocate<8ul, doris::vectorized:
   :Allocator_<unsigned long>>(doris::vectorized::Allocator_<unsigned long>*, unsigned long)::M>&, unsigned long) /d
   oris/thirdparty/installed/include/parallel_hashmap/phmap_base.h:1468:18
       #4 0x5598a500a919 in void* phmap::priv::Allocate<8ul, doris::vectorized::Allocator_<unsigned long>>(doris::vectorized::Allocator_<unsigned long>*, unsigne
   d long) /doris/thirdparty/installed/include/parallel_hashmap/phmap_base.h:4356:13
   
   ...
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #19130: [fix](memory) Fix SchemaChange memory leak due to incorrect aggfunc destroy

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19130:
URL: https://github.com/apache/doris/pull/19130#issuecomment-1524582301

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #19130: [fix](memory) Fix SchemaChange memory leak due to incorrect aggfunc destroy

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19130:
URL: https://github.com/apache/doris/pull/19130#issuecomment-1524441098

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #19130: [fix](memory) Fix SchemaChange memory leak due to incorrect aggfunc destroy

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19130:
URL: https://github.com/apache/doris/pull/19130#issuecomment-1524427541

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] xinyiZzz commented on pull request #19130: [fix](memory) Fix SchemaChange memory leak due to incorrect aggfunc destroy

Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #19130:
URL: https://github.com/apache/doris/pull/19130#issuecomment-1524581798

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] xinyiZzz commented on pull request #19130: [fix](memory) Fix SchemaChange memory leak due to incorrect aggfunc destroy

Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #19130:
URL: https://github.com/apache/doris/pull/19130#issuecomment-1524438605

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #19130: [fix](memory) Fix SchemaChange memory leak due to incorrect aggfunc destroy

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #19130:
URL: https://github.com/apache/doris/pull/19130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] xinyiZzz commented on pull request #19130: [fix](memory) Fix SchemaChange memory leak due to incorrect aggfunc destroy

Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #19130:
URL: https://github.com/apache/doris/pull/19130#issuecomment-1524423272

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org