You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by nolanlawson <gi...@git.apache.org> on 2017/02/15 08:35:33 UTC
[GitHub] couchdb-fauxton pull request #852: trim moment locale using IgnorePlugin
GitHub user nolanlawson opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/852
trim moment locale using IgnorePlugin
This trims the release bundle.js size from 2554776 bytes to 2372243 bytes. Apparently there is a large part of the bundle taken up by moment.js, but AFAICT we're not actually using moment/locale anywhere, so this removes it.
See https://github.com/moment/moment/issues/2373 for why this seemed like a good idea.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nolanlawson/couchdb-fauxton trim-moment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #852
----
commit df56aeb443334ef4e4ad1ba35b7cd2e201d0832c
Author: Nolan Lawson <no...@gmail.com>
Date: 2017-02-15T08:25:42Z
trim moment locale using IgnorePlugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #852: trim moment locale using IgnorePlugin
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/852
This is awesome. Managing the bundle size is definitely a neglected side of Fauxton. The builds are taking long to run today. But soon as they have built I will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #852: trim moment locale using IgnorePlugin
Posted by nolanlawson <gi...@git.apache.org>.
Github user nolanlawson commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/852
Context: I'm using webpack-bundle-analyzer to try to figure out where we can trim the JS bundle:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #852: trim moment locale using IgnorePlugin
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/852
I've documented your ideas here https://issues.apache.org/jira/browse/COUCHDB-3303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #852: trim moment locale using IgnorePlugin
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/852
Thanks. I've merged it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #852: trim moment locale using IgnorePlugin
Posted by nolanlawson <gi...@git.apache.org>.
Github user nolanlawson commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/852
Yeah the long build times seem entirely related to Webpack, but I'm not super familiar with Webpack so I'm not sure how to optimize.
In any case there is some other stuff I wanted to do to improve build time but haven't gotten around to:
- split `brace` into separate code-split bundle using `require.ensure()`
- use modular lodash, e.g. with `babel-plugin-lodash` and `lodash-webpack-plugin`, or just stuff like `var map = require('lodash/map')`
- use rollup to compress the size of files we control, e.g. that whole app/ folder should be one big JS file rather than separate modules (seems [rollup-loader](https://github.com/egoist/rollup-loader) would work well for this)
- alternatively, upgrade to webpack 2 because it seems that would cut down the react-bootstrap size since it's exposed as an ES module and therefore the tree-shaking would automatically trim a lot of the cruft. potentially rollup-loader could also do this but needs investigation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #852: trim moment locale using IgnorePlugin
Posted by nolanlawson <gi...@git.apache.org>.
Github user nolanlawson closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/852
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---