You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2015/07/09 00:10:27 UTC
Review Request 36335: Reset the static fields in static class
JoinStatsRule in StatsRulesProcFactory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36335/
-----------------------------------------------------------
Review request for hive, John Pullokkaran and Mostafa Mokhtar.
Repository: hive-git
Description
-------
The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059
Diff: https://reviews.apache.org/r/36335/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 36335: Reset the static fields in static class
JoinStatsRule in StatsRulesProcFactory
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36335/#review91020
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java (line 1246)
<https://reviews.apache.org/r/36335/#comment144238>
Could you change the name of getSelectivity to getCardinality or some thing similar. This method is actually returning cardinality as opposed to selectivity.
- John Pullokkaran
On July 8, 2015, 10:10 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36335/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 10:10 p.m.)
>
>
> Review request for hive, John Pullokkaran and Mostafa Mokhtar.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059
>
> Diff: https://reviews.apache.org/r/36335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 36335: Reset the fields in class JoinStatsRule in
StatsRulesProcFactory
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36335/#review91173
-----------------------------------------------------------
Ship it!
Ship It!
- John Pullokkaran
On July 8, 2015, 11:37 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36335/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 11:37 p.m.)
>
>
> Review request for hive, John Pullokkaran and Mostafa Mokhtar.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059
>
> Diff: https://reviews.apache.org/r/36335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 36335: Reset the fields in class JoinStatsRule in
StatsRulesProcFactory
Posted by Mostafa Mokhtar <mm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36335/#review91057
-----------------------------------------------------------
Ship it!
Ship It!
- Mostafa Mokhtar
On July 8, 2015, 11:37 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36335/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 11:37 p.m.)
>
>
> Review request for hive, John Pullokkaran and Mostafa Mokhtar.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059
>
> Diff: https://reviews.apache.org/r/36335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 36335: Reset the fields in class JoinStatsRule in
StatsRulesProcFactory
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36335/
-----------------------------------------------------------
(Updated July 8, 2015, 11:37 p.m.)
Review request for hive, John Pullokkaran and Mostafa Mokhtar.
Repository: hive-git
Description
-------
The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059
Diff: https://reviews.apache.org/r/36335/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 36335: Reset the fields in class JoinStatsRule in
StatsRulesProcFactory
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36335/
-----------------------------------------------------------
(Updated July 8, 2015, 11:32 p.m.)
Review request for hive, John Pullokkaran and Mostafa Mokhtar.
Summary (updated)
-----------------
Reset the fields in class JoinStatsRule in StatsRulesProcFactory
Repository: hive-git
Description
-------
The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059
Diff: https://reviews.apache.org/r/36335/diff/
Testing
-------
Thanks,
pengcheng xiong