You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2015/04/27 00:34:32 UTC
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/466
THRIFT-3083 consolidate simple and threaded server run loops
Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and extract out the specific differences to limit code duplication.
The server processing loop which is common to TSimpleServer, TThreadedServer, TThreadPoolServer is now in one place. This improves the predictability of thrift and helps improve maintainability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3083-following-THRIFT-3081-merge-to-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 0446bc77d855afa13cb9791011f01f37c91db386
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-26T22:30:26Z
THRIFT-3083 consolidate simple and threaded server run loops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/466
THRIFT-3083 consolidate simple and threaded server run loops
Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and extract out the specific differences to limit code duplication.
The server processing loop which is common to TSimpleServer, TThreadedServer, TThreadPoolServer is now in one place. This improves the predictability of thrift and helps improve maintainability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3083-following-THRIFT-3081-merge-to-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 0446bc77d855afa13cb9791011f01f37c91db386
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-26T22:30:26Z
THRIFT-3083 consolidate simple and threaded server run loops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/466
THRIFT-3083 consolidate simple and threaded server run loops
Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and extract out the specific differences to limit code duplication.
The server processing loop which is common to TSimpleServer, TThreadedServer, TThreadPoolServer is now in one place. This improves the predictability of thrift and helps improve maintainability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3083-following-THRIFT-3081-merge-to-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 0446bc77d855afa13cb9791011f01f37c91db386
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-26T22:30:26Z
THRIFT-3083 consolidate simple and threaded server run loops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/466
THRIFT-3083 consolidate simple and threaded server run loops
Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and extract out the specific differences to limit code duplication.
The server processing loop which is common to TSimpleServer, TThreadedServer, TThreadPoolServer is now in one place. This improves the predictability of thrift and helps improve maintainability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3083-following-THRIFT-3081-merge-to-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 0446bc77d855afa13cb9791011f01f37c91db386
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-26T22:30:26Z
THRIFT-3083 consolidate simple and threaded server run loops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/466#issuecomment-96895697
Failed strangely - recycling.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/466#issuecomment-97396400
Giving a rebuild one more try in CI, if it fails then I'll rebase with master and see...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by henrique <gi...@git.apache.org>.
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/466#issuecomment-97618902
Hi James,
As you do this on your own fork I thought you'd have the access to restart the Travis build manually, without the need of closing and opening the PR's. Have you set your service hook on your fork settings?
i.e. https://travis-ci.org/jeking3/thrift
- Henrique
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/466#issuecomment-97616177
package code.google.com/p/gomock/gomock: https://code.google.com/p/gomock/source/checkout?repo=: 502 Bad Gateway
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/466
THRIFT-3083 consolidate simple and threaded server run loops
Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and extract out the specific differences to limit code duplication.
The server processing loop which is common to TSimpleServer, TThreadedServer, TThreadPoolServer is now in one place. This improves the predictability of thrift and helps improve maintainability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3083-following-THRIFT-3081-merge-to-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 0446bc77d855afa13cb9791011f01f37c91db386
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-26T22:30:26Z
THRIFT-3083 consolidate simple and threaded server run loops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/466
THRIFT-3083 consolidate simple and threaded server run loops
Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and extract out the specific differences to limit code duplication.
The server processing loop which is common to TSimpleServer, TThreadedServer, TThreadPoolServer is now in one place. This improves the predictability of thrift and helps improve maintainability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3083-following-THRIFT-3081-merge-to-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 0446bc77d855afa13cb9791011f01f37c91db386
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-26T22:30:26Z
THRIFT-3083 consolidate simple and threaded server run loops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/466#issuecomment-97620293
Wow, the build passed! I have an account on travis, but I have been submitting pull requests into the apache/thrift master, so I have to control them here as far as I know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/466
THRIFT-3083 consolidate simple and threaded server run loops
Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and extract out the specific differences to limit code duplication.
The server processing loop which is common to TSimpleServer, TThreadedServer, TThreadPoolServer is now in one place. This improves the predictability of thrift and helps improve maintainability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3083-following-THRIFT-3081-merge-to-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 0446bc77d855afa13cb9791011f01f37c91db386
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-26T22:30:26Z
THRIFT-3083 consolidate simple and threaded server run loops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/466#issuecomment-97616416
Sadly, Travis CI really isn't very stable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/466#issuecomment-97154526
There is a "make cross" error that is unrelated to my changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/466
THRIFT-3083 consolidate simple and threaded server run loops
Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and extract out the specific differences to limit code duplication.
The server processing loop which is common to TSimpleServer, TThreadedServer, TThreadPoolServer is now in one place. This improves the predictability of thrift and helps improve maintainability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3083-following-THRIFT-3081-merge-to-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 0446bc77d855afa13cb9791011f01f37c91db386
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-26T22:30:26Z
THRIFT-3083 consolidate simple and threaded server run loops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/466#issuecomment-97593757
Last build failed because of one make cross failure between java and go - two components I did not affect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/466
THRIFT-3083 consolidate simple and threaded server run loops
Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and extract out the specific differences to limit code duplication.
The server processing loop which is common to TSimpleServer, TThreadedServer, TThreadPoolServer is now in one place. This improves the predictability of thrift and helps improve maintainability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3083-following-THRIFT-3081-merge-to-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 0446bc77d855afa13cb9791011f01f37c91db386
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-26T22:30:26Z
THRIFT-3083 consolidate simple and threaded server run loops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/466#issuecomment-97736680
As this was merged, closing the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---