[jira] [Commented] (MESOS-3872) Investigate adding color to `support/post-reviews.py` on Windows

["Andrew Schwartzmeyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936817#comment-15936817 ] 

Andrew Schwartzmeyer commented on MESOS-3872:
---------------------------------------------

Weirder yet: it works _sometimes_. This is a weird repro, but hear me out:

Using `post-reviews.py` after executing `git help log` will cause the colors to be interpreted correctly (displayed in color) in Windows 10. But you can then break it again by running `git diff` and then the script, it'll go back to broken escape codes.

> Investigate adding color to `support/post-reviews.py` on Windows
> ----------------------------------------------------------------
>
>                 Key: MESOS-3872
>                 URL: https://issues.apache.org/jira/browse/MESOS-3872
>             Project: Mesos
>          Issue Type: Bug
>          Components: general
>            Reporter: Alex Clemmer
>            Assignee: Alex Clemmer
>              Labels: mesosphere, windows
>
> From the comments:
> # TODO(hausdorff): We have disabled colors for the diffs on Windows, as piping them through `subprocess` causes us to emit ANSI escape codes, which the command prompt doesn't recognize. Presumably we are being routed through some TTY that causes git to not emit the colors using `cmd`'s color codes API (which is entirely different from ANSI. See [1] for more information and MESOS-3872.
> #
> # [1] http://stackoverflow.com/questions/5921556/in-git-bash-on-windows-7-colors-display-as-code-when-running-cucumber-or-rspec



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)