You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/09/09 09:06:29 UTC

[GitHub] [zookeeper] paurkedal opened a new pull request #1452: Handle float metrics in check_zookeeper.

paurkedal opened a new pull request #1452:
URL: https://github.com/apache/zookeeper/pull/1452


   After upgrading to Zookeeper 3.6, Nagios tests for zk_avg_latency started failing due to floating point metrics being compared as strings.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] paurkedal commented on pull request #1452: ZOOKEEPER-3935: Handle float metrics in check_zookeeper

Posted by GitBox <gi...@apache.org>.
paurkedal commented on pull request #1452:
URL: https://github.com/apache/zookeeper/pull/1452#issuecomment-691880967


   Will create a ticket first next time. Thanks for merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] paurkedal commented on pull request #1452: Handle float metrics in check_zookeeper.

Posted by GitBox <gi...@apache.org>.
paurkedal commented on pull request #1452:
URL: https://github.com/apache/zookeeper/pull/1452#issuecomment-690948386


   I did, or rather, we're using the patched version in production.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] paurkedal commented on pull request #1452: Handle float metrics in check_zookeeper.

Posted by GitBox <gi...@apache.org>.
paurkedal commented on pull request #1452:
URL: https://github.com/apache/zookeeper/pull/1452#issuecomment-690948386


   I did, or rather, we're using the patched version in production.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1452: ZOOKEEPER-3935: Handle float metrics in check_zookeeper

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1452:
URL: https://github.com/apache/zookeeper/pull/1452#issuecomment-691865770


   pushed, thanks @paurkedal for your contribution! 🎉 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1452: Handle float metrics in check_zookeeper.

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1452:
URL: https://github.com/apache/zookeeper/pull/1452#issuecomment-691858746


   I'll merge it now to master and branch-3.6
   @paurkedal Am I correct that this is not an issue for 3.5?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1452: Handle float metrics in check_zookeeper.

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1452:
URL: https://github.com/apache/zookeeper/pull/1452#issuecomment-691862918


   hmm.. I see no Jira issue for this ticket, I created [ZOOKEEPER-3935](https://issues.apache.org/jira/browse/ZOOKEEPER-3935)
   @paurkedal please create ZooKeeper Jira tickets first next time, before you would submit a PR. See: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] paurkedal commented on pull request #1452: Handle float metrics in check_zookeeper.

Posted by GitBox <gi...@apache.org>.
paurkedal commented on pull request #1452:
URL: https://github.com/apache/zookeeper/pull/1452#issuecomment-690948386






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] asfgit closed pull request #1452: ZOOKEEPER-3935: Handle float metrics in check_zookeeper

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1452:
URL: https://github.com/apache/zookeeper/pull/1452


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] paurkedal commented on pull request #1452: Handle float metrics in check_zookeeper.

Posted by GitBox <gi...@apache.org>.
paurkedal commented on pull request #1452:
URL: https://github.com/apache/zookeeper/pull/1452#issuecomment-690948386


   I did, or rather, we're using the patched version in production.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org