[GitHub] [beam] pabloem commented on a change in pull request #15832: [BEAM-13149] Changing readWithPartitions to work with longs. Removing untested (non-working) code path

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #15832:
URL: https://github.com/apache/beam/pull/15832#discussion_r739395488



##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1060,53 +1060,36 @@ public void populateDisplayData(DisplayData.Builder builder) {
           getUpperBound() - getLowerBound() >= getNumPartitions(),
           "The specified number of partitions is more than the difference between upper bound and lower bound");
 
-      if (getUpperBound() == MAX_VALUE || getLowerBound() == 0) {
-        refineBounds(input);
-      }
-
-      int stride = (getUpperBound() - getLowerBound()) / getNumPartitions();
-      PCollection<List<Integer>> params =
+      PCollection<KV<Integer, KV<Long, Long>>> params =
           input.apply(
               Create.of(
                   Collections.singletonList(
-                      Arrays.asList(getLowerBound(), getUpperBound(), getNumPartitions()))));
-      PCollection<KV<String, Iterable<Integer>>> ranges =
+                      KV.of(getNumPartitions(), KV.of(getLowerBound(), getUpperBound())))));

Review comment:
       I changed this to KVs because I left the `numPartitions` variable as Integer. This used to be represented as a list, but the list had to have a single type (all ints or all longs) - so that's why I changed it to KV<Integer, KV<Long, Long>> to represent (numPartitions, (Start, End))




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org